Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp2014936imm;
        Thu, 14 Jun 2018 07:29:23 -0700 (PDT)
X-Google-Smtp-Source: ADUXVKK1l0Wx1i+GTuNYi4iT8NA/5rcCygScUJIJRo9aHHRNMWsWSiK0o883EWRzTtLvq2TJOo3Q
X-Received: by 2002:a65:5086:: with SMTP id r6-v6mr2489048pgp.375.1528986563601;
        Thu, 14 Jun 2018 07:29:23 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1528986563; cv=none;
        d=google.com; s=arc-20160816;
        b=i8IFto3G1qj1GbEoNTNjbgbqTu/BfBSW7WPyV6LwIuWFnEc8UbCsT1Df3UCvlwkx6y
         9xn2tV2uPHZor4qhrnE3nF1n135li97vw18T0MahlZl2KC597xkTrwSi3JGCSCY7xSJx
         sFiuqLZxxG2dm4sDVGlanGtd6rfU84RdVmXxtPYeeQ4CMj4ipUVzXEgZ4hsuEtgpdijR
         D1gK3aWGsrTtXmxEw4XIxqHUVQ0BUlBmdDi3c4Au6iH860jImv+LWkTHCeileRc37E9w
         BIkgpanBCcZ8dCDHgwGf+QJsL6GOzh1CxL+jdQWrmQXhhpMeFEhN69O7xHsM8Mr8N9FZ
         pZqQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:cc:to:subject:message-id:date:from
         :references:in-reply-to:mime-version:dkim-signature
         :arc-authentication-results;
        bh=6D7FRzcKkf1mtcCgqKoPcGMQEGQXfdycYZdpgoORS1I=;
        b=C0cR5mS58Tjx+uZRCJbblfBuCSude0qJI9xczdM+HvktYEU7mrqzJDsiYNqvWaE7Gw
         P0+aBIPI6fbqdqtm958UeTd1AJf37jF4fa3vJ5bFDc36KNG7iUjXgNM2DTJV4LO618do
         qlTJY2xeMP4A2sTFziMMf4D/Vank/pyVikmFccYd2zelNGNdDoS1sxEoPePQjLJD+l5D
         bcosokFrs5eJxm8RoyanSRaFno5b0DK9IdiVHqcNyIOC6sxgJMlfbYPBA6+ei4L2UBn/
         7UYmmVDxxaUl6RNPB7HiZ+H8C1ZJU4bd1Am0k40XS6TKD3A3WsjbhXUi7M2rJj9Y1Sa8
         1gOQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@linaro.org header.s=google header.b="M+XX/JlH";
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id p18-v6si5681889pfe.150.2018.06.14.07.29.09;
        Thu, 14 Jun 2018 07:29:23 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@linaro.org header.s=google header.b="M+XX/JlH";
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S965793AbeFNO1a (ORCPT <rfc822;yingkeliu@gmail.com> + 99 others);
        Thu, 14 Jun 2018 10:27:30 -0400
Received: from mail-it0-f67.google.com ([209.85.214.67]:56067 "EHLO
        mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S965633AbeFNO11 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 14 Jun 2018 10:27:27 -0400
Received: by mail-it0-f67.google.com with SMTP id 16-v6so8572711itl.5
        for <linux-kernel@vger.kernel.org>; Thu, 14 Jun 2018 07:27:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc;
        bh=6D7FRzcKkf1mtcCgqKoPcGMQEGQXfdycYZdpgoORS1I=;
        b=M+XX/JlHp4XQKH7aGc/DkA3zau8kIaGq2Fv0PEJCVH7obmE+d8nNtvJJUgITe3gO/n
         lWLDoldWkMxWZTxCgVPSidteo34kxkkHlSdj6hbV+NA4yTkjV6RIQb/KQZAE5egBikS4
         6XDQk4VuB5lCK8UCiPj5ZH/Enh+3p8agCIS8M=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:in-reply-to:references:from:date
         :message-id:subject:to:cc;
        bh=6D7FRzcKkf1mtcCgqKoPcGMQEGQXfdycYZdpgoORS1I=;
        b=gVAA+Xtue/c4D+Q+n9a4anpI6d6Ww+Io4ny4uetylTfk7scHHIDP2ryWny2t2oCGAn
         IzODomHT4OHtEK8nfIznIM8keNtuaLaNbqqNK2aWzTN2wP4vDvS4SmMHUXiE5Ckt0MwL
         4Y7wP07tsgHbNSUzY54z4+HrOP00EMK7VdhIHgnU8WsPtl+R5d3ee+vBlt1g/MNFpJCL
         YrZyf5IhPMkFrxEZ4nzSQITy2LAn3NnCEBYweaNDRnaXOhKrJLg7tywnwZBXZSvkCf/7
         lXCdq2tgbIPBBB1MyvpSpnaNz7oSMfsZ/nDHT/GIfeEnRZYaBGaf8Scasj/iOW/GA8VF
         eNmA==
X-Gm-Message-State: APt69E1zwHezD4ozTJZFTwVN/PipQ1Dyj0TaZV7NXGQphxMtz+N4NiY/
        U+ArATs6Gdjr0ylUr9QJZ//TR8gBK5UAUm5uHE+60g==
X-Received: by 2002:a24:19ca:: with SMTP id b193-v6mr2429963itb.135.1528986446419;
 Thu, 14 Jun 2018 07:27:26 -0700 (PDT)
MIME-Version: 1.0
Received: by 2002:a4f:78c9:0:0:0:0:0 with HTTP; Thu, 14 Jun 2018 07:27:25
 -0700 (PDT)
In-Reply-To: <1528774132-38287-1-git-send-email-jiazhouyang09@gmail.com>
References: <1528774132-38287-1-git-send-email-jiazhouyang09@gmail.com>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Thu, 14 Jun 2018 16:27:25 +0200
Message-ID: <CACRpkdbjMLiJtxUpuSuvOBKD-rbybF8baJUBjvP6Hv5baeWY7w@mail.gmail.com>
Subject: Re: [PATCH] gpio: max732x: add error handling for i2c_new_dummy
To:     Zhouyang Jia <jiazhouyang09@gmail.com>
Cc:     "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 12, 2018 at 5:28 AM, Zhouyang Jia <jiazhouyang09@gmail.com> wrote:

> When i2c_new_dummy fails, the lack of error-handling code may
> cause unexpected results.
>
> This patch adds error-handling code after calling i2c_new_dummy.
>
> Signed-off-by: Zhouyang Jia <jiazhouyang09@gmail.com>

Patch applied for non-critical fixes.

Yours,
Linus Walleij