Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp2126760imm; Thu, 14 Jun 2018 09:08:09 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIsR61d3LJqYANy5ZRpPpfJYnKyAeALUc0LWOBMiAJPiprd+iMQZtI8Z/qY7yojOCy1nj2B X-Received: by 2002:a63:9402:: with SMTP id m2-v6mr2809563pge.8.1528992489883; Thu, 14 Jun 2018 09:08:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528992489; cv=none; d=google.com; s=arc-20160816; b=g8PXv4AKb0/oU7oLwy7kIv6Rk3D8Tp5VAZk+/+r5Y8j32DsN+C94fSfV6ZlRjidill tzwc3BVoI4fjdTuvVUchBiajzLfeLlN8LD93qFXg25OzwKwOrlKQXT3X9V/o+1acMrs8 rgAIjk9fLBmpKQEu0qBNt5rzxSv5l8W+yVd1t+PmdM0IbBqqQbB8BsCI8IeCGXWafKDM HX8rbkqi61KhMlRRsCiVMn8zVvU4JxbjZ3UWmb3ECSFB58laMZT6Sj7oyqO2L3/rHI3c 4IxqUzd9iOM4er0oRbLhu/GlDplbc96Bg0a6aCURhGDR83wC6fYiBvPtCYqs+NyQ5roK Y1AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:subject:cc:to:from:message-id:date :arc-authentication-results; bh=dGsGMxFa58HewQiTd9wON8ufmnH5bSGjleNnOS2kYS8=; b=SDLVasV6KPAjGEHFe6/5P9HSu6PtBr/GY43SXHjeI9F9KON+vjrId6IIRN13m9sJh/ a65VAd5XSNmSvHoC47+ggS/WxeJya5ttNT71i+mmdjnVvZL0AfNxNsZKRF0QidFUN6bu RdxIWX1Ase6roFqiLTew/pfozHgx8YHGdQvgBtOUAPYCuoL8LS7zi2tpz2xm/79tacGM j/Qct+XaTRFxjGu69IX0Ws24ItQscthTG6gJTgCgQ4a5sl/9cd79VbbdHoxwpWEy4XKv un2glV2NSRbyUgKsTVI2aKpaqM3zDGh3M3sC5tZ0dKnOSQv9Z22COwCaJ17nQidN4tpO on2Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v28-v6si4678244pgc.531.2018.06.14.09.07.55; Thu, 14 Jun 2018 09:08:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755243AbeFNQH1 (ORCPT + 99 others); Thu, 14 Jun 2018 12:07:27 -0400 Received: from mx2.suse.de ([195.135.220.15]:41290 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755010AbeFNQH0 (ORCPT ); Thu, 14 Jun 2018 12:07:26 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext-too.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id C358FAD03; Thu, 14 Jun 2018 16:07:25 +0000 (UTC) Date: Thu, 14 Jun 2018 18:07:25 +0200 Message-ID: From: Takashi Iwai To: Jorge Sanjuan Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, ruslan.bilovol@gmail.com Subject: Re: [PATCH v2 0/4] ALSA: usb-audio: Insertion Control for BADD Adaptors. In-Reply-To: <20180614140558.28277-1-jorge.sanjuan@codethink.co.uk> References: <20180612143201.29988-1-jorge.sanjuan@codethink.co.uk> <20180614140558.28277-1-jorge.sanjuan@codethink.co.uk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 Jun 2018 16:05:54 +0200, Jorge Sanjuan wrote: > > Thanks for review! > > Here is what's new in this V2: > - Split the patchset into a more sensible series. > > This patchset adds support for the Insertion Control for BADD devices > (subset of UAC3). > > This control is only pressent in the HEADSET ADAPTER BADD profile. The USB > interrupt pipe shall be present for this profile so the status pipe > creation should also happen for BADD devices. > > Also, the bi-directional type codes have been defined so they can be used > as inferred values for the Input and Output terminals for this adapter > profile. > > Based on tag: next-20180612 > > Jorge Sanjuan (4): > ALSA: usb-audio: Add bi-directional terminal types. > ALSA: usb-audio: Change in connectors control creation interface > ALSA: usb-audio: UAC3. Add insertion control for BADD. > ALSA: usb-audio: Always create the interrupt pipe for the mixer Thanks, this looks nicer, each of changes is smaller and clearer. Although it's a bit too late for the merge window, this is a change that is fairly safe for the existing UAC1/UAC2, I merged it now. Oh, and the subjects were slightly fixed; no need of period at the tail in a subject line. Takashi