Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 14 Jun 2018 22:12:47 +0200
Message-ID: <s5hh8m5uny8.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Ruslan Bilovol <ruslan.bilovol@gmail.com>
Cc:     Jorge Sanjuan <jorge.sanjuan@codethink.co.uk>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/4] ALSA: usb-audio: Insertion Control for BADD Adaptors.
In-Reply-To: <CAB=otbRkXJwMUXebJuLtVaZkUG-RY=O65rRNT9oL+u2_cipgXQ@mail.gmail.com>
References: <20180612143201.29988-1-jorge.sanjuan@codethink.co.uk>
        <20180614140558.28277-1-jorge.sanjuan@codethink.co.uk>
        <s5ha7rx2vya.wl-tiwai@suse.de>
        <CAB=otbRkXJwMUXebJuLtVaZkUG-RY=O65rRNT9oL+u2_cipgXQ@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 14 Jun 2018 21:18:10 +0200,
Ruslan Bilovol wrote:
> 
> On Thu, Jun 14, 2018 at 7:07 PM, Takashi Iwai <tiwai@suse.de> wrote:
> > On Thu, 14 Jun 2018 16:05:54 +0200,
> > Jorge Sanjuan wrote:
> >>
> >> Thanks for review!
> >>
> >> Here is what's new in this V2:
> >>  - Split the patchset into a more sensible series.
> >>
> >> This patchset adds support for the Insertion Control for BADD devices
> >> (subset of UAC3).
> >>
> >> This control is only pressent in the HEADSET ADAPTER BADD profile. The USB
> >> interrupt pipe shall be present for this profile so the status pipe
> >> creation should also happen for BADD devices.
> >>
> >> Also, the bi-directional type codes have been defined so they can be used
> >> as inferred values for the Input and Output terminals for this adapter
> >> profile.
> >>
> >> Based on tag: next-20180612
> >>
> >> Jorge Sanjuan (4):
> >>   ALSA: usb-audio: Add bi-directional terminal types.
> >>   ALSA: usb-audio: Change in connectors control creation interface
> >>   ALSA: usb-audio: UAC3. Add insertion control for BADD.
> >>   ALSA: usb-audio: Always create the interrupt pipe for the mixer
> >
> > Thanks, this looks nicer, each of changes is smaller and clearer.
> > Although it's a bit too late for the merge window, this is a change
> > that is fairly safe for the existing UAC1/UAC2, I merged it now.
> >
> 
> It's too late probably, but I just finished reviewing these patches
> and don't have any objections.

Yeah, I already pushed out.  But thanks for reviewing.


Takashi