Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp2382877imm; Thu, 14 Jun 2018 13:24:52 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKnocQZ6UfTGppY3FRtMG9/6neFVf0IwQAQcbpdlpS7+JpbndX3XprP7UwnVpfIsTPGowJA X-Received: by 2002:a17:902:4203:: with SMTP id g3-v6mr4509344pld.315.1529007892546; Thu, 14 Jun 2018 13:24:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529007892; cv=none; d=google.com; s=arc-20160816; b=FS5o2ZMHJxxuFjAmj2xTIe3qOTzAvaV130Yyef4TsqsprHN9KCzQQVi0aFxhe2BAy1 QVVMLvq5zSIpNPH2aNBG4MPZ/6vD+VVM+oSgfnCcJccEFcKAAiXlTpmLOpaBjIf8Xb7W snLlEDu7P6/1Fp1J+x4SGQ1cNN2hWW/lxeG2tsD+EXROQdRG1f3gHXCgjPF/2jITvegs I3GyUvWZ3QdT7jPG2BMgQ4YZxS6uWxjxi2InGHu9K5yESS9KudavIkVy/2k9w7dwXUWc XJ89gwgdlgzRD9CyznGtrwqGXXd23e/I6PRqy+oJYjsjc0U38ymaagNNpW/js6O0e4oU 87vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=OlU9KPj45wfbrwiu9Wq5EXBdKiovhVJWVmUm/9FpiPY=; b=p9BimCl3xkzetq0yvUNpGnP5Gcqd9Z6Vb+Wu6w9BNLz2KetQg+IlS3jKc+h/m/Rq3z sJpoPajg/TpN3/akT3MM/vU4Flmz7/vCcHTSg9L6pydfm5HHmDXmw5xFO728UZngYcb5 v6t1wAXL982TH2IZyKEBqZaF1+ilYh7EGbVbvlC2rPQtLTkpYroKMvidpAB9u1e/jf1H Zgkk//B7R35NGQfXULOkj2RP1x626jMiYr6BrcZ7pKLSIxAYTjkK+aytpPH1QADNR+NE 5tiaePuS0yGch2FZ2+QQ+CHDc04MWwJevD3JYzLkCbsuI1rg2uadmO97LqhWCcppq/o0 eNnQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a5-v6si6162446plh.340.2018.06.14.13.24.38; Thu, 14 Jun 2018 13:24:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755472AbeFNUXR (ORCPT + 99 others); Thu, 14 Jun 2018 16:23:17 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:47650 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755429AbeFNUXO (ORCPT ); Thu, 14 Jun 2018 16:23:14 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4F744406E897; Thu, 14 Jun 2018 20:23:13 +0000 (UTC) Received: from madcap2.tricolour.ca (ovpn-112-45.rdu2.redhat.com [10.10.112.45]) by smtp.corp.redhat.com (Postfix) with ESMTP id C94AD1116700; Thu, 14 Jun 2018 20:23:11 +0000 (UTC) From: Richard Guy Briggs To: Linux-Audit Mailing List , LKML Cc: eparis@parisplace.org, Paul Moore , Steve Grubb , Alexander Viro , Richard Guy Briggs Subject: [RFC PATCH ghak59 V1 2/6] audit: add syscall information to CONFIG_CHANGE records Date: Thu, 14 Jun 2018 16:21:12 -0400 Message-Id: <244a8049197a23b0cee37dc3f00d070e646fd1b7.1529003588.git.rgb@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Thu, 14 Jun 2018 20:23:13 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Thu, 14 Jun 2018 20:23:13 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'rgb@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tie syscall information to all CONFIG_CHANGE calls since they are all a result of user actions. See: https://github.com/linux-audit/audit-kernel/issues/59 See: https://github.com/linux-audit/audit-kernel/issues/50 Signed-off-by: Richard Guy Briggs --- kernel/audit.c | 4 ++-- kernel/audit_fsnotify.c | 2 +- kernel/audit_tree.c | 2 +- kernel/audit_watch.c | 2 +- kernel/auditfilter.c | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/kernel/audit.c b/kernel/audit.c index ad54339..e469234 100644 --- a/kernel/audit.c +++ b/kernel/audit.c @@ -400,7 +400,7 @@ static int audit_log_config_change(char *function_name, u32 new, u32 old, struct audit_buffer *ab; int rc = 0; - ab = audit_log_start(NULL, GFP_KERNEL, AUDIT_CONFIG_CHANGE); + ab = audit_log_start(audit_context(), GFP_KERNEL, AUDIT_CONFIG_CHANGE); if (unlikely(!ab)) return rc; audit_log_format(ab, "op=set %s=%u old=%u", function_name, new, old); @@ -1067,7 +1067,7 @@ static void audit_log_common_recv_msg(struct audit_buffer **ab, u16 msg_type) return; } - *ab = audit_log_start(NULL, GFP_KERNEL, msg_type); + *ab = audit_log_start(audit_context(), GFP_KERNEL, msg_type); if (unlikely(!*ab)) return; audit_log_format(*ab, "pid=%d uid=%u", pid, uid); diff --git a/kernel/audit_fsnotify.c b/kernel/audit_fsnotify.c index 52f368b..1640eb6 100644 --- a/kernel/audit_fsnotify.c +++ b/kernel/audit_fsnotify.c @@ -127,7 +127,7 @@ static void audit_mark_log_rule_change(struct audit_fsnotify_mark *audit_mark, c if (!audit_enabled) return; - ab = audit_log_start(NULL, GFP_NOFS, AUDIT_CONFIG_CHANGE); + ab = audit_log_start(audit_context(), GFP_NOFS, AUDIT_CONFIG_CHANGE); if (unlikely(!ab)) return; audit_log_format(ab, "auid=%u ses=%u op=%s", diff --git a/kernel/audit_tree.c b/kernel/audit_tree.c index 5e9d1e5..a01b9da 100644 --- a/kernel/audit_tree.c +++ b/kernel/audit_tree.c @@ -499,7 +499,7 @@ static void audit_tree_log_remove_rule(struct audit_krule *rule) if (!audit_enabled) return; - ab = audit_log_start(NULL, GFP_KERNEL, AUDIT_CONFIG_CHANGE); + ab = audit_log_start(audit_context(), GFP_KERNEL, AUDIT_CONFIG_CHANGE); if (unlikely(!ab)) return; audit_log_format(ab, "op=remove_rule"); diff --git a/kernel/audit_watch.c b/kernel/audit_watch.c index 9b4836b..da2978b 100644 --- a/kernel/audit_watch.c +++ b/kernel/audit_watch.c @@ -242,7 +242,7 @@ static void audit_watch_log_rule_change(struct audit_krule *r, struct audit_watc if (!audit_enabled) return; - ab = audit_log_start(NULL, GFP_NOFS, AUDIT_CONFIG_CHANGE); + ab = audit_log_start(audit_context(), GFP_NOFS, AUDIT_CONFIG_CHANGE); if (!ab) return; audit_log_format(ab, "auid=%u ses=%u op=%s", diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c index eaa3201..6e19acb 100644 --- a/kernel/auditfilter.c +++ b/kernel/auditfilter.c @@ -1093,7 +1093,7 @@ static void audit_log_rule_change(char *action, struct audit_krule *rule, int re if (!audit_enabled) return; - ab = audit_log_start(NULL, GFP_KERNEL, AUDIT_CONFIG_CHANGE); + ab = audit_log_start(audit_context(), GFP_KERNEL, AUDIT_CONFIG_CHANGE); if (!ab) return; audit_log_session_info(ab); -- 1.8.3.1