Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
To:     Ben Hutchings <ben.hutchings@codethink.co.uk>
Cc:     Jeremy Cline <jeremy@jcline.org>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        stable@vger.kernel.org, Li Ning <lining916740672@icloud.com>,
        Sasha Levin <alexander.levin@microsoft.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4.4 128/268] scsi: sd: Keep disk read-only when re-reading partition
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
References: <20180528100202.045206534@linuxfoundation.org>
        <20180528100216.627623125@linuxfoundation.org>
        <1528925110.2289.175.camel@codethink.co.uk>
Date:   Thu, 14 Jun 2018 21:41:30 -0400
In-Reply-To: <1528925110.2289.175.camel@codethink.co.uk> (Ben Hutchings's
        message of "Wed, 13 Jun 2018 22:25:10 +0100")
Message-ID: <yq1fu1oltbp.fsf@oracle.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Hi Ben,

> (The log message about Write Protect status also reports the
> underlying SCSI device flag and not the combined ro flag, but maybe
> that was intentional.)

I'd prefer for the printk in question to reflect the device-reported
state, not the state of the block device.

> I think this commit should be reverted, both in stable and upstream.
> A proper fix would involve splitting the ro flag into two flags=E2=80=94o=
ne
> controlled by user-space and one read from the device=E2=80=94with the
> effective read-only status being the logical-or of those two.

I don't have a problem with distinguishing between current state and an
override flag in the block layer. However, I think an incremental patch
to fix that up is fine. SCSI devices don't typically switch write
protection state on a whim.

--=20
Martin K. Petersen	Oracle Linux Engineering