Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Daniel Sangorrin" <daniel.sangorrin@toshiba.co.jp>
To:     "'Greg Kroah-Hartman'" <gregkh@linuxfoundation.org>,
        <linux-kernel@vger.kernel.org>
Cc:     <stable@vger.kernel.org>, "'Andy Lutomirski'" <luto@kernel.org>,
        "'Rik van Riel'" <riel@redhat.com>,
        "'Borislav Petkov'" <bp@alien8.de>,
        "'Brian Gerst'" <brgerst@gmail.com>,
        "'Dave Hansen'" <dave.hansen@linux.intel.com>,
        "'Denys Vlasenko'" <dvlasenk@redhat.com>,
        "'Fenghua Yu'" <fenghua.yu@intel.com>,
        "'H. Peter Anvin'" <hpa@zytor.com>,
        "'Josh Poimboeuf'" <jpoimboe@redhat.com>,
        "'Linus Torvalds'" <torvalds@linux-foundation.org>,
        "'Oleg Nesterov'" <oleg@redhat.com>,
        "'Peter Zijlstra'" <peterz@infradead.org>,
        "'Quentin Casasnovas'" <quentin.casasnovas@oracle.com>,
        "'Thomas Gleixner'" <tglx@linutronix.de>, <pbonzini@redhat.com>,
        "'Ingo Molnar'" <mingo@kernel.org>
References: <20180614132724.483802160@linuxfoundation.org> <20180614132724.905032027@linuxfoundation.org>
In-Reply-To: <20180614132724.905032027@linuxfoundation.org>
Subject: RE: [PATCH 4.4 10/24] x86/fpu: Hard-disable lazy FPU mode
Date:   Fri, 15 Jun 2018 13:24:27 +0900
Message-ID: <000c01d40460$bfc97710$3f5c6530$@toshiba.co.jp>
MIME-Version: 1.0
Content-Type: text/plain;
        charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Thread-Index: AQGUQj4igkaupq7EehpFPqRFc6I8UgHKB38SpNHsNUA=
Content-Language: ja
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Greg,

>  /* Intel-defined CPU features, CPUID level 0x00000001 (ecx), word 4 */
> --- a/arch/x86/include/asm/fpu/internal.h
> +++ b/arch/x86/include/asm/fpu/internal.h
> @@ -58,7 +58,7 @@ extern u64 fpu__get_supported_xfeatures_
>   */
>  static __always_inline __pure bool use_eager_fpu(void)
>  {
> -	return static_cpu_has_safe(X86_FEATURE_EAGER_FPU);
> +	return true;
>  }

Since this function returns always true then we can remove the code depending on lazy FPU mode.
Actually this has already been done in "x86/fpu: Remove use_eager_fpu()"
Ref: https://patchwork.kernel.org/patch/9365883/

>  static void __init fpu__init_parse_early_param(void)
>  {
> -	if (cmdline_find_option_bool(boot_command_line, "eagerfpu=off")) {
> -		eagerfpu = DISABLE;
> -		fpu__clear_eager_fpu_features();
> -	}

Since this patch removes the kernel boot parameter "eagerfpu", maybe we should remove it from the Documentation.
This has also been done by commit "x86/fpu: Finish excising 'eagerfpu'"
Ref: https://patchwork.kernel.org/patch/9380673/

I will try backporting those patches unless anyone has any objections.

Thanks,
Daniel Sangorrin