Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp385537imm; Thu, 14 Jun 2018 22:45:56 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLRV+npedqyBbzgrpXS8ZktVKbpc4Ppfez4gmDcj8mnYyc+gLbcXgot0904xIF0pY/RkXLx X-Received: by 2002:a62:ae06:: with SMTP id q6-v6mr314263pff.17.1529041556724; Thu, 14 Jun 2018 22:45:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529041556; cv=none; d=google.com; s=arc-20160816; b=Ia6lPL21L0OXFH/fFDfy0EKh6czJ9BwUapEqnljGCSJML1rLHSrvcPl/5V+izNVtQV x6qt9Q4mP/JNKSB8qjDRw/vLZWGpa1njvztYx9MqKpkBVu0LoVTyhs7YkX2sDYxsQ8g7 QKXo4zXLeM6ZAITrhHfVWTIcV4JHb9CnNdyBjtbVLFK/wvKdPws4kPxq0mM3hJHYKuT0 +bVM6w7Blr1oxN/LZ25O+M6+RwX3OmUzYpw+DtJVoDX+3rQqqMdOOXBfU3FUA90saJMG GbYgHrTRIfOFq++qo7WraLkG/zJjK4BzBmb3gi1znMGDmrqqusgLC5bNWIidhQRwZXEz R1xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=121SQ5T38D3R57XSFYse0PMj5QKhJ/t7nvUiri2iYXc=; b=oWdyHOzsOKa6iPSgjwWjYQ2ZcnYF6wvCdvAt7cLbnPjNu7eaLVgSL59Sy5GRHyMw5A FKW4p43+5YplmDKr1YWl5KE2538RwHLNWHIhDu25vcbUNVEuuRirjiX39N0zV2hNYqAN xjb7G3ZCdrTAkHe/wSccCyLbSYBCG2IYGOyJUAHaNk16Sele8XsfDqaRFg4gUQ4ET1dT TjGiRj5DnyIcoVf7Ca+VQyi0BzyqTr9A+N8P/Gx6DiLnWIdf/zOBbNwf/daHkHSZdZ9K Re2Rt8SGXm+vaRWORZ3EaBGDvMxo54GNZj4foW95DnfNkZL/oqF3eNGkjmYttICoYstJ xNXQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 98-v6si7091318pls.430.2018.06.14.22.45.29; Thu, 14 Jun 2018 22:45:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755727AbeFOFpA (ORCPT + 99 others); Fri, 15 Jun 2018 01:45:00 -0400 Received: from mga09.intel.com ([134.134.136.24]:40576 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755691AbeFOFoz (ORCPT ); Fri, 15 Jun 2018 01:44:55 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jun 2018 22:44:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,225,1526367600"; d="scan'208";a="237351600" Received: from bee.sh.intel.com (HELO bee) ([10.239.97.14]) by fmsmga005.fm.intel.com with ESMTP; 14 Jun 2018 22:44:53 -0700 Received: from kbuild by bee with local (Exim 4.84_2) (envelope-from ) id 1fThXY-0007Tf-G6; Fri, 15 Jun 2018 13:44:52 +0800 Date: Fri, 15 Jun 2018 13:44:40 +0800 From: kbuild test robot To: linux-scsi-owner@vger.kernel.org Cc: kbuild-all@01.org, Zhouyang Jia , Juergen Gross , Boris Ostrovsky , "James E.J. Bottomley" , "Martin K. Petersen" , xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] scsi: xen-scsifront: add error handling for xenbus_printf Message-ID: <201806151305.MldLqVQQ%fengguang.wu@intel.com> References: <1529017154-54719-1-git-send-email-jiazhouyang09@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1529017154-54719-1-git-send-email-jiazhouyang09@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: lkp@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on xen-tip/linux-next] [also build test WARNING on v4.17 next-20180614] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/linux-scsi-owner-vger-kernel-org/scsi-xen-scsifront-add-error-handling-for-xenbus_printf/20180615-070404 base: https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git linux-next reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) drivers/scsi/xen-scsifront.c:267:21: sparse: expression using sizeof(void) drivers/scsi/xen-scsifront.c:440:33: sparse: expression using sizeof(void) drivers/scsi/xen-scsifront.c:440:33: sparse: expression using sizeof(void) drivers/scsi/xen-scsifront.c:473:33: sparse: expression using sizeof(void) drivers/scsi/xen-scsifront.c:473:33: sparse: expression using sizeof(void) drivers/scsi/xen-scsifront.c:474:33: sparse: expression using sizeof(void) drivers/scsi/xen-scsifront.c:474:33: sparse: expression using sizeof(void) >> drivers/scsi/xen-scsifront.c:663:47: sparse: incorrect type in argument 1 (different base types) @@ expected struct xenbus_device *dev @@ got xenbus_device *dev @@ drivers/scsi/xen-scsifront.c:663:47: expected struct xenbus_device *dev drivers/scsi/xen-scsifront.c:663:47: got struct device * drivers/scsi/xen-scsifront.c:681:47: sparse: incorrect type in argument 1 (different base types) @@ expected struct xenbus_device *dev @@ got xenbus_device *dev @@ drivers/scsi/xen-scsifront.c:681:47: expected struct xenbus_device *dev drivers/scsi/xen-scsifront.c:681:47: got struct device * drivers/scsi/xen-scsifront.c:1022:59: sparse: incorrect type in argument 1 (different base types) @@ expected struct xenbus_device *dev @@ got xenbus_device *dev @@ drivers/scsi/xen-scsifront.c:1022:59: expected struct xenbus_device *dev drivers/scsi/xen-scsifront.c:1022:59: got struct device * drivers/scsi/xen-scsifront.c:1042:59: sparse: incorrect type in argument 1 (different base types) @@ expected struct xenbus_device *dev @@ got xenbus_device *dev @@ drivers/scsi/xen-scsifront.c:1042:59: expected struct xenbus_device *dev drivers/scsi/xen-scsifront.c:1042:59: got struct device * drivers/scsi/xen-scsifront.c:1063:19: sparse: expression using sizeof(void) drivers/scsi/xen-scsifront.c:1064:19: sparse: expression using sizeof(void) drivers/scsi/xen-scsifront.c:1065:19: sparse: expression using sizeof(void) drivers/scsi/xen-scsifront.c: In function 'scsifront_sdev_configure': drivers/scsi/xen-scsifront.c:663:21: error: passing argument 1 of 'xenbus_dev_error' from incompatible pointer type [-Werror=incompatible-pointer-types] xenbus_dev_error(&info->dev->dev, err, ^ In file included from drivers/scsi/xen-scsifront.c:50:0: include/xen/xenbus.h:224:6: note: expected 'struct xenbus_device *' but argument is of type 'struct device *' void xenbus_dev_error(struct xenbus_device *dev, int err, const char *fmt, ...); ^~~~~~~~~~~~~~~~ drivers/scsi/xen-scsifront.c: In function 'scsifront_sdev_destroy': drivers/scsi/xen-scsifront.c:681:21: error: passing argument 1 of 'xenbus_dev_error' from incompatible pointer type [-Werror=incompatible-pointer-types] xenbus_dev_error(&info->dev->dev, err, ^ In file included from drivers/scsi/xen-scsifront.c:50:0: include/xen/xenbus.h:224:6: note: expected 'struct xenbus_device *' but argument is of type 'struct device *' void xenbus_dev_error(struct xenbus_device *dev, int err, const char *fmt, ...); ^~~~~~~~~~~~~~~~ drivers/scsi/xen-scsifront.c: In function 'scsifront_do_lun_hotplug': drivers/scsi/xen-scsifront.c:1022:23: error: passing argument 1 of 'xenbus_dev_error' from incompatible pointer type [-Werror=incompatible-pointer-types] xenbus_dev_error(&dev->dev, err, ^ In file included from drivers/scsi/xen-scsifront.c:50:0: include/xen/xenbus.h:224:6: note: expected 'struct xenbus_device *' but argument is of type 'struct device *' void xenbus_dev_error(struct xenbus_device *dev, int err, const char *fmt, ...); ^~~~~~~~~~~~~~~~ drivers/scsi/xen-scsifront.c:1042:23: error: passing argument 1 of 'xenbus_dev_error' from incompatible pointer type [-Werror=incompatible-pointer-types] xenbus_dev_error(&dev->dev, err, ^ In file included from drivers/scsi/xen-scsifront.c:50:0: include/xen/xenbus.h:224:6: note: expected 'struct xenbus_device *' but argument is of type 'struct device *' void xenbus_dev_error(struct xenbus_device *dev, int err, const char *fmt, ...); ^~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +663 drivers/scsi/xen-scsifront.c 653 654 static int scsifront_sdev_configure(struct scsi_device *sdev) 655 { 656 struct vscsifrnt_info *info = shost_priv(sdev->host); 657 int err; 658 659 if (info && current == info->curr) { 660 err = xenbus_printf(XBT_NIL, info->dev->nodename, 661 info->dev_state_path, "%d", XenbusStateConnected); 662 if (err) { > 663 xenbus_dev_error(&info->dev->dev, err, 664 "%s: writing dev_state_path", __func__); 665 return err; 666 } 667 } 668 669 return 0; 670 } 671 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation