Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20180614142852.22226-1-jhogan@kernel.org>
In-Reply-To: <20180614142852.22226-1-jhogan@kernel.org>
From:   Greentime Hu <green.hu@gmail.com>
Date:   Fri, 15 Jun 2018 14:12:58 +0800
Message-ID: <CAEbi=3d_muKnGnmfu8OJZqO=2EUTSf-YjLPChupDVXxcacJejQ@mail.gmail.com>
Subject: Re: [PATCH v2] nds32: Fix build error caused by configuration flag rename
To:     jhogan@kernel.org
Cc:     Vincent Chen <deanbo422@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Guenter Roeck <linux@roeck-us.net>, matt.redfearn@mips.com,
        palmer@sifive.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

James Hogan <jhogan@kernel.org> =E6=96=BC 2018=E5=B9=B46=E6=9C=8814=E6=97=
=A5 =E9=80=B1=E5=9B=9B =E4=B8=8B=E5=8D=8810:29=E5=AF=AB=E9=81=93=EF=BC=9A
>
> From: Guenter Roeck <linux@roeck-us.net>
>
> Fix build error on nds32 due to the merge of commit e3d5980568f ("lib:
> Rename compiler intrinsic selects to GENERIC_LIB_*") during the 4.18
> merge window which renames Kconfig symbols. This had raced with commit
> aeaa7af744fa ("nds32: lib: To use generic lib instead of libgcc to
> prevent the symbol undefined issue.") merged late in the 4.17 cycle,
> which added selects to nds32 using the original Kconfig symbol names.
>
> When they came together in merge commit 763f96944c95 ("Merge tag
> 'mips_4.18' of
> git://git.kernel.org/pub/scm/linux/kernel/git/mips/linux") this resulted
> in the following build errors:
>
> nds32le-linux-ld: kernel/time/timekeeping.o: in function `timekeeping_ini=
t':
> timekeeping.c:(.init.text+0x140): undefined reference to `__ashldi3'
> nds32le-linux-ld: timekeeping.c:(.init.text+0x144): undefined reference t=
o `__ashldi3'
> nds32le-linux-ld: timekeeping.c:(.init.text+0x17e): undefined reference t=
o `__lshrdi3'
> nds32le-linux-ld: timekeeping.c:(.init.text+0x182): undefined reference t=
o `__lshrdi3'
> nds32le-linux-ld: drivers/clocksource/mmio.o: in function `clocksource_mm=
io_init':
> mmio.c:(.init.text+0x54): undefined reference to `__lshrdi3'
> nds32le-linux-ld: mmio.c:(.init.text+0x58): undefined reference to `__lsh=
rdi3'
>
> Rename all 6 selects in nds32 and adjust the ordering accordingly to be
> alphabetical.
>
> Fixes: 763f96944c95 ("Merge tag 'mips_4.18' of git://git.kernel.org/pub/s=
cm/linux/kernel/git/mips/linux")
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> [jhogan@kernel.org: Rename all 6 symbols, sort, update commit message]
> Signed-off-by: James Hogan <jhogan@kernel.org>
> Cc: Greentime Hu <green.hu@gmail.com>
> Cc: Vincent Chen <deanbo422@gmail.com>
> Cc: Matt Redfearn <matt.redfearn@mips.com>
> Cc: Palmer Dabbelt <palmer@sifive.com>
> ---
> Changes in v2:
>  - Rename all 6 symbols, not just the 3 that caused build failures.
>  - Sort selects.
>  - Update commit message.

Thank you James and Guenter.
Should I pick it in my tree? It will be ok to put in your tree. :)

Acked-by: Greentime Hu <greentime@andestech.com>