Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1D942606DB
Subject: Re: [PATCH v10 04/10] drivers: qcom: rpmh: add RPMH helper functions
To:     Doug Anderson <dianders@chromium.org>
Cc:     Andy Gross <andy.gross@linaro.org>,
        David Brown <david.brown@linaro.org>,
        linux-arm-msm@vger.kernel.org,
        "open list:ARM/QUALCOMM SUPPORT" <linux-soc@vger.kernel.org>,
        Rajendra Nayak <rnayak@codeaurora.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Stephen Boyd <sboyd@kernel.org>,
        Evan Green <evgreen@chromium.org>,
        Matthias Kaehlcke <mka@chromium.org>,
        Lina Iyer <ilina@codeaurora.org>
References: <1528737949-17495-1-git-send-email-rplsssn@codeaurora.org>
 <1528737949-17495-5-git-send-email-rplsssn@codeaurora.org>
 <CAD=FV=ULcTE14gNYFA4hWpViDd6srXztvjbVTO7vBOKKMuEdSA@mail.gmail.com>
From:   Raju P L S S S N <rplsssn@codeaurora.org>
Message-ID: <b49e2591-9eaa-f8ef-5da9-30412ae27f4e@codeaurora.org>
Date:   Fri, 15 Jun 2018 11:53:28 +0530
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <CAD=FV=ULcTE14gNYFA4hWpViDd6srXztvjbVTO7vBOKKMuEdSA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On 6/14/2018 2:39 AM, Doug Anderson wrote:
> Hi,
> 
> On Mon, Jun 11, 2018 at 10:25 AM, Raju P L S S S N
> <rplsssn@codeaurora.org> wrote:
>> +void rpmh_tx_done(const struct tcs_request *msg, int r)
>> +{
>> +       struct rpmh_request *rpm_msg = container_of(msg, struct rpmh_request,
>> +                                                   msg);
>> +       struct completion *compl = rpm_msg->completion;
>> +
>> +       rpm_msg->err = r;
>> +
>> +       if (r)
>> +               dev_err(rpm_msg->dev, "RPMH TX fail in msg addr=%#x, err=%d\n",
>> +                       rpm_msg->msg.cmds[0].addr, r);
>> +
>> +       /* Signal the blocking thread we are done */
>> +       if (compl)
>> +               complete(compl);
>> +}
>> +EXPORT_SYMBOL(rpmh_tx_done);
> 
> You're back to too many EXPORT_SYMBOL's again.  Just use this rule of thumb:
> 
> * If it's static, no EXPORT_SYMBOL.
> 
> * If the prototype is in "rpmh-internal.h", no EXPORT_SYMBOL.
> 
> * If the prototype is in "rpmh.h", then yes EXPORT_SYMBOL.
> 
> In the case of rpmh_tx_done: the protype is in rpmh-internal.h
> 
> 
> To fix, squash in crosreview.com/1099841
> 
> 
> -Doug
> 

Sure. Thanks for review.