Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp554133imm; Fri, 15 Jun 2018 02:19:57 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLwzk05HTP7ogLm49ZBjrdtc8ZhI5hIdSorSb1lTThyrk1Szux6w34mlX2FEvOmsPmF8ZCV X-Received: by 2002:a17:902:ac1:: with SMTP id 59-v6mr1083801plp.36.1529054397313; Fri, 15 Jun 2018 02:19:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529054397; cv=none; d=google.com; s=arc-20160816; b=nyW00dkdurv8KXabz+GpUdyEgu+ihMLQuCqp6J8f4yKL+PQmD2Kq8W+pb4HAudigJA HTSnNkad/2d9ROI6maUyD5yme185cQ/uvMPr1Kr0N6j3gIRJnM+HeHJzqYq3eYrNeMZ9 B3rgDmVt1AnGhm8t1y0wuyXB9ROk8kkrK9CySuc9DExlud1tZi61eCcHXwKDS5dP/LxU 0VCTYYSwxOo1JrLyNK+DQEa1FngXfd4n8Qmfb5k3RsLTB4GYR9bnCTmi3pDKUWasQDXL qDtt/PGOGaVrt1oTY1DKW5gkUokTt+MQyqivS9h4NvluhRPqV3BUdwt1m+4TN7JD3VHR B2aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=h/6l2y+xk2LkQ3nD0yMUhV5mmmkkVU732yMMHtKWuAQ=; b=d4UEs9gUM7J6Ngbhd/6VWVrrmGwDvRxOriVVN3/WKFZFqRzdBp5dYO5W2EIZkfZ+gj Gtmd2RoYc2cy6kIqoqc27Tkoo/Z+XXqXLUPnmrdUMnCFEF2X5wJq7fqGmZBLspuVT22e 74H55+cVaS9a9U+lW5pJx1Xmmbnyhe89RBHgeio6lR9T+p36vBjswPbVYd2jk5+fdbgb Vji0HszG4zV8QrkYtyqq/rZDvE/jItnaNr4uVwRjHKnwULKHoanwHUlBLqE/2VFKV0z4 GBBf/BEbIkZsqJBv8hwHhUrWsCpLG/YJUf25gZOxG+Ivc8FfO3axB58RXo3Q2/ypai0L sMDg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m21-v6si6353056pgn.599.2018.06.15.02.19.42; Fri, 15 Jun 2018 02:19:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755940AbeFOJTQ (ORCPT + 99 others); Fri, 15 Jun 2018 05:19:16 -0400 Received: from verein.lst.de ([213.95.11.211]:50023 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755804AbeFOJTO (ORCPT ); Fri, 15 Jun 2018 05:19:14 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id E49D568E45; Fri, 15 Jun 2018 11:27:41 +0200 (CEST) Date: Fri, 15 Jun 2018 11:27:41 +0200 From: Christoph Hellwig To: Anatoliy Glagolev Cc: Christoph Hellwig , linux-block@vger.kernel.org, "James E.J. Bottomley" , FUJITA Tomonori , Jens Axboe , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2] block: fix bsg_unregister and bsg_open race Message-ID: <20180615092741.GA21138@lst.de> References: <20180613221417.GA22778@xldev-tmpl.dev.purestorage.com> <20180614083806.GA18966@lst.de> <20180614234733.GA38460@xldev-tmpl.dev.purestorage.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180614234733.GA38460@xldev-tmpl.dev.purestorage.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 14, 2018 at 05:47:34PM -0600, Anatoliy Glagolev wrote: > Thanks, Christoph. Good catch releasing the mutex on failure path. > V2 patch with your suggestions applied. Looks good: Reviewed-by: Christoph Hellwig Now just re-add the changelog and resend it in a new thread.