Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp669935imm; Fri, 15 Jun 2018 04:30:02 -0700 (PDT) X-Google-Smtp-Source: ADUXVKInqWliHcJgOtHbHrPUHeo3MiJdqM81zHe/wX2VGMSSJgtreyBSI6/s3TWoZwkEPhr30ZQz X-Received: by 2002:a63:7a48:: with SMTP id j8-v6mr1205285pgn.415.1529062202528; Fri, 15 Jun 2018 04:30:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529062202; cv=none; d=google.com; s=arc-20160816; b=JjJXP0WUHwM2evRDd2PO4oWi5jVl+e/UG3IEheZac8vafaVTne7PmOiF57zToVhrQk qgzQ0/5glfc9uUlxiaUAOYkjjSbMScgNC4xUSNISjkfcKp2ymcx97mNEP/qbRJ/1VoKB ab5Rahciptgmxg0L5U9o7Xsa7ebkvSDkvhoB0FCoCSRGtH5cyE2iwyzaOLDyWdQ+lPZh J5QrMt/oV3UBHyNhrSCo2hA+RIoQI7N3CEXi3qcWIhNMapz2FYhkXLUaqLtvFlU5x4Qo oRiPQQSTDulLlYAqjeKndc9ByxEs9bSL2X2SiBws5dmZ9U/DEwztX+VZxuwxuYfzfMJp li7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=zvVJSj0BGf+AgYri3egFX20HbwmEu/fzFApUjQ+Y+e4=; b=koi4r6B//gXaEGUBAosdTNd/hodgfluZpUTxyhQQaSTzpMRs8pDRNkcuEzo3hCLGqw BP4+jFlHD0zCrUx00aSY8dmCok61yleOqULxWp61qdZqScD70hUEQtOEPbZLMctJ6w3l x/vzrjzjktzSye8rVVOpaGCtVIx1ylhdKo7XNyPmzf2lSkITmT6bNZq/PP2ThBmpWTLt 6+YdqYyDJTTB2SAybyT+FYLEmeh6eqtivqBK7Y9r0oMI8JfRb+bj+VXIH7BpfG8bz3Ki Ox8cncYVs34j+QP+GzhY5dT3YoOoCkNeWaOrMlB1dfILkUnItfoVgC9GZx6Iq7VfDftM 4ULQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v11-v6si6349433pgf.380.2018.06.15.04.29.46; Fri, 15 Jun 2018 04:30:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965778AbeFOL3V (ORCPT + 99 others); Fri, 15 Jun 2018 07:29:21 -0400 Received: from muru.com ([72.249.23.125]:47412 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965641AbeFOL3U (ORCPT ); Fri, 15 Jun 2018 07:29:20 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id ACBF28076; Fri, 15 Jun 2018 11:31:57 +0000 (UTC) Date: Fri, 15 Jun 2018 04:29:16 -0700 From: Tony Lindgren To: Maciej Purski Cc: Mark Brown , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Carlos Hernandez , Marek Szyprowski Subject: Re: [PATCH v2] regulator: core: Enable voltage balancing Message-ID: <20180615112916.GK112168@atomide.com> References: <20180605044554.GC5738@atomide.com> <1528886026-9457-1-git-send-email-m.purski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1528886026-9457-1-git-send-email-m.purski@samsung.com> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, * Maciej Purski [180613 10:39]: > Call regulator_balance_voltage() instead of set_voltage_rdev() > in set_voltage_unlocked() and in enabling and disabling functions, > but only if the regulator is coupled. > > Signed-off-by: Maciej Purski > > --- > Changes in v2: > - fix compile errors > - make debug messages more informative Thanks for updating it. This series still hangs after loading modules on beagleboard-x15: [ 26.679749] smps12: regulator_set_voltage: 3381 [ 26.684529] smps12: regulator_set_voltage_unlocked: 3045 [ 26.695616] smps12: _regulator_do_set_voltage: 2912 [ 26.701275] smps12: regulator_set_voltage: 3381 [ 26.706002] smps12: regulator_set_voltage_unlocked: 3045 [ 26.712349] smps12: _regulator_do_set_voltage: 2912 [ 26.719329] abb_mpu: regulator_set_voltage: 3381 [ 26.724105] abb_mpu: regulator_set_voltage_unlocked: 3045 So it seems to be the abb_mpu where it hangs? Regards, Tony