Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp671335imm; Fri, 15 Jun 2018 04:31:09 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJU5YFp+AzyIUcGOQyJijVwBSoNRWnpyQTEqkY8TVcIVaoab5RSp6G0/5u6Oa/3uiWZKOPW X-Received: by 2002:a62:6941:: with SMTP id e62-v6mr1533598pfc.56.1529062269212; Fri, 15 Jun 2018 04:31:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529062269; cv=none; d=google.com; s=arc-20160816; b=O2JeBWQgkxONw9YfTeGVN3lpJ5nbXw2C5XARLWy9ln4p79ZKm4zMtMnLlA8YR5dA0o VGwaQpGGKgVby6tzKJpNNC+8AVZj7tz6brQrsdrrqX8cP8Nu2y9YGl2WxFt8HGCbiNKX X1GElEetPKi3EAw0IYKNtHaGOSv3bdKBmQl0DnHvsext7bdU4VtriT3LrTfFt8oNmWuS TMnfcXtGklS4Jo338SxLAy5Xc6wDM4kbs73F9IiSh2dWcZ6gxsooSZuaiRixZ9EYajom w++nXsVg1q2z192bWGRDP4qTl9Yj7u5J1LXwwfWQPZ/0v+DtubbE8vb+nXJrA7SGCuCX iYFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :arc-authentication-results; bh=pPaEAQlPwxuuZ7A0WYvpBnWV3DcCrVu94RnyPHlhHKk=; b=XCUezBcYMrqUEYRgHvjHEdB5WB0zMK+XmPcZP3qrKZa5uD5pFBZwmZ1DFREEgixgUL OT+u0ZTTbZdqkD6XwCLb90B2NbIkQ+mHGSAthhpXeJ6KlcAm4z+vaVI1RUVwO3MtpjDJ qnnW5N+E+nUweOzkPDVJE0DKH4LuamxBQiAlX9wWtiaCpyEnY8f12TWWJB+1XD4COuoS SxOs2wX8sp19ndC7CDlKA5wfPf1XnU61AAxcFE2UFGB8SlLRGAv/w0o90oNKyKhcg0VH btI7sAzTa/2P5ejx6Xt7r2KZIq7N2sTysk1/wAoOBMx6fBXFLyEElFdhZmD1CCT/TzVV 1bfQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e90-v6si7499310pfb.185.2018.06.15.04.30.53; Fri, 15 Jun 2018 04:31:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965822AbeFOL37 (ORCPT + 99 others); Fri, 15 Jun 2018 07:29:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42594 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965641AbeFOL35 (ORCPT ); Fri, 15 Jun 2018 07:29:57 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4C93730832F4; Fri, 15 Jun 2018 11:29:57 +0000 (UTC) Received: from redhat.com (ovpn-120-46.rdu2.redhat.com [10.10.120.46]) by smtp.corp.redhat.com (Postfix) with SMTP id 3017A121A59; Fri, 15 Jun 2018 11:29:49 +0000 (UTC) Date: Fri, 15 Jun 2018 14:29:43 +0300 From: "Michael S. Tsirkin" To: Wei Wang Cc: virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, linux-mm@kvack.org, mhocko@kernel.org, akpm@linux-foundation.org, torvalds@linux-foundation.org, pbonzini@redhat.com, liliang.opensource@gmail.com, yang.zhang.wz@gmail.com, quan.xu0@gmail.com, nilal@redhat.com, riel@redhat.com, peterx@redhat.com Subject: Re: [PATCH v33 0/4] Virtio-balloon: support free page reporting Message-ID: <20180615142610-mutt-send-email-mst@kernel.org> References: <1529037793-35521-1-git-send-email-wei.w.wang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1529037793-35521-1-git-send-email-wei.w.wang@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Fri, 15 Jun 2018 11:29:57 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 15, 2018 at 12:43:09PM +0800, Wei Wang wrote: > - remove the cmd id related interface. Now host can just send a free > page hint command to the guest (via the host_cmd config register) > to start the reporting. Here we go again. And what if reporting was already started previously? I don't think it's a good idea to tweak the host/guest interface yet again. -- MST