Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 1/2] x86: x86_64_defconfig: Enable KSM.
To:     =?UTF-8?Q?Daniel_D=c3=adaz?= <daniel.diaz@linaro.org>,
        x86@kernel.org
Cc:     anders.roxell@linaro.org, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" 
        <linux-kernel@vger.kernel.org>
References: <1529016629-2948-1-git-send-email-daniel.diaz@linaro.org>
From:   "Austin S. Hemmelgarn" <ahferroin7@gmail.com>
Message-ID: <bc4cf4cb-e2b5-47c3-e29f-8ddf27a6a307@gmail.com>
Date:   Fri, 15 Jun 2018 08:23:39 -0400
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <1529016629-2948-1-git-send-email-daniel.diaz@linaro.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2018-06-14 18:50, Daniel Díaz wrote:
> As per the documentation, Kernel Samepage Merging (available
> since 2.6.32) is a memory-saving de-duplication feature,
> enabled by CONFIG_KSM=y and activated via sysfs. More
> information can be found here:
>    https://www.kernel.org/doc/Documentation/vm/ksm.txt
> 
> When enabled in the kernel, the default is to not do anything
> at all, until it is activated at run-time with:
>    echo 1 > /sys/kernel/mm/ksm/run
> 
As pointed out by a couple of others, this doesn't explain why this is a 
good idea.  All you're doing here is giving a reason that it won't have 
a negative impact on most users.

Two points that may be worth adding, but also don't really argue for it 
being a significant improvement:

* Pretty much all of the major distributions that use pre-built kernels 
have it enabled in their kernels (At minimum, Debian, Ubuntu, Fedora 
(and by extension RHEL and CentOS), openSUSE (and by extension SLES), 
Arch, and Alpine have it enabled), so enabling this in defconfig would 
bring it a bit closer to parity with distribution kernels in terms of 
core features.

* Software other than QEMU is starting to take advantage of it if 
available (for example, Netdata [1] can mark it's in-memory TSDB's for 
deduplication, which usually cuts it's memory usage roughly in half).


[1] https://my-netdata.io/