Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp983341imm; Fri, 15 Jun 2018 09:16:31 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLXLskaPyxU2FoejA3Zb00+v6WosmYwpstP7zqkjIJIf4bq0GoGO8zaisIjWXXWH9eOq2yk X-Received: by 2002:a63:6ec1:: with SMTP id j184-v6mr2207563pgc.332.1529079391693; Fri, 15 Jun 2018 09:16:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529079391; cv=none; d=google.com; s=arc-20160816; b=kBdwQzSHcXSvwvJUlOhSt/gboStzR63QsKTKRqIIF/GBJdz6iFXWTTB330tj5YJDbx 0qrFBUN+oUx8RhJGC12GX4aMic7rNNdGJ6ug81VTC35/+CDNDeebf6jXIzPoa8Ct7RRX KXF85uDewOxnHw6gVFMSqeiQoIKmEudy346xfmHiMJ16Ab81ZvAK+PzCMAHnM4cn8gTl /J1rOI9+F/lYU4UO1Gw1AtcSCcgde0QPvip68VZqGvbRrZLr1j21NGM8mom9VAL+SLoK sxCxWmEyErmsnpe6ALAeh8k7y2ZMlGEVSQB4Tw8dopGwf1OCXMmQgARn0sd1mwJgnrIv hqIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=FKeDdRfU9hf3zg2j1yUQjEOfUD8Cp04Lnnjye5qvdhw=; b=vqwyPin0GFkXQSm4dfda4hZcaqAtSNUpysQlh3MKeO5Pj2r9GIKzGL3qpit7bz8nY0 nUkzSYlsmE25g3OMoLt24rluwlVeotxyHzODNMBubu0/vyI4lmfBxe+GwQOI0g2afIVQ t+o6/1LcAFnxO9GW77NQuWnBzq825V53SKuMX62kR78wT1lYhY7D7d9F33te7uwyjR9w CudnngFXTXehfxnjWqswBD6WvrIzf8udkQ2I2iNVvHtyZ1h8dlmPD3P5gBNPiPpNOCn9 Poy/VYgPoly7C9s9uZte67Nby1JiggouuI6gjrHyrvgWwW8TodpnYuvxFHjTe0dhv/P3 2E1g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f69-v6si6698662pgc.551.2018.06.15.09.16.09; Fri, 15 Jun 2018 09:16:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966007AbeFOQPi (ORCPT + 99 others); Fri, 15 Jun 2018 12:15:38 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:59582 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964779AbeFOQPh (ORCPT ); Fri, 15 Jun 2018 12:15:37 -0400 Received: from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net [74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D28D614214B36; Fri, 15 Jun 2018 09:15:36 -0700 (PDT) Date: Fri, 15 Jun 2018 09:15:36 -0700 (PDT) Message-Id: <20180615.091536.1647251866604964944.davem@davemloft.net> To: jiazhouyang09@gmail.com Cc: santosh@chelsio.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net: cxgb3: add error handling for sysfs_create_group From: David Miller In-Reply-To: <1529031977-57911-1-git-send-email-jiazhouyang09@gmail.com> References: <1528984571-53320-1-git-send-email-jiazhouyang09@gmail.com> <1529031977-57911-1-git-send-email-jiazhouyang09@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 15 Jun 2018 09:15:37 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zhouyang Jia Date: Fri, 15 Jun 2018 11:06:17 +0800 > When sysfs_create_group fails, the lack of error-handling code may > cause unexpected results. > > This patch adds error-handling code after calling sysfs_create_group. > > Signed-off-by: Zhouyang Jia > --- > v1->v2: > - Turn off led when sysfs_create_group fails Applied, thank you.