Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1145239imm; Fri, 15 Jun 2018 12:00:13 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIbDEno+/uEVaDkHKu0raL9y4MVHEvKMV1PzhMWPsJR2dtHQ1lO3C4jxZAzKbIyry+TNykz X-Received: by 2002:a63:7f1b:: with SMTP id a27-v6mr2730222pgd.410.1529089213301; Fri, 15 Jun 2018 12:00:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529089213; cv=none; d=google.com; s=arc-20160816; b=jREgZm25HVSswwtPVOjbe4hBCZqyNCtm6Y0IBBW13Sri+VxoG2+38N7T43jn3Q3jSA LaiiMLe3HUz5Ek8Dya4OkCAQ//t76uYj4E+Y8Mv/hp64le/lXH4++3G4GEtyqoHGbhfg s/aM6jP1EdHmQ3iLS8LwiISj13SUcY+j8PBp7SoNRARJPayc9o/LtFTEx0PCxUmycOSP 5mQ94O03nDpkirUMs9oeHTq4M0xAWApZ2QV3zAFwIgObp7goOC58Cuhe/147mgDlI0YU uAOZkSpE+xlzgNAyFbXcbVItdKpFgyO7jgNr4ml9y2PIvS4reMXbhbQkHiR3FZOSc8EN ozhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date :arc-authentication-results; bh=zrd07hySOb394kn0hQxkzXok7foBZ+5gz12Ap1adY4U=; b=yy5t+D5svnm5ARRCYe9iyVXxmUrfGzXd22f4neD6G7Um4XyO0D1/vcJdPVWqLu1590 dXVwOQl2jgCgRiB+hM6r6c6sAF0hGUcVIIrRv9qKS4C1ZlXICDYRxv6CMg1chUuxCpaP VWXG05RGhPDB8ylueVXIt4eD052ESVPXsn17mxjEzHLj2jBftMtJB6OXni7QxAt5cf42 u4Th22dMLaYyiHBKt5qnZ2TTwlv3tNFcvVhzABeG94G8ZCeQGhJoN9Iv91DKn89LVSwx WhjMrBkGkYuoZRakxYC/UiXqsvAUqc9J8udSUR8iTzRm2kupjIh3a/9VYqENGK3FLnB7 NoAw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i137-v6si6987114pgc.130.2018.06.15.11.59.58; Fri, 15 Jun 2018 12:00:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756530AbeFOS5v (ORCPT + 99 others); Fri, 15 Jun 2018 14:57:51 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:51498 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756509AbeFOS5u (ORCPT ); Fri, 15 Jun 2018 14:57:50 -0400 Received: from p4fea482e.dip0.t-ipconnect.de ([79.234.72.46] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1fTtum-0005Wl-N8; Fri, 15 Jun 2018 20:57:40 +0200 Date: Fri, 15 Jun 2018 20:57:40 +0200 (CEST) From: Thomas Gleixner To: Tom Lendacky cc: Konrad Rzeszutek Wilk , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, x86@kernel.org, andrew.cooper3@citrix.com, Ingo Molnar , "H. Peter Anvin" , Borislav Petkov , David Woodhouse , Kees Cook , KarimAllah Ahmed Subject: Re: [PATCH v1 3/3] x86/bugs: Switch the selection of mitigation from CPU vendor to CPU features In-Reply-To: <5090fe69-61fd-99cb-f9d0-908cd6250d25@amd.com> Message-ID: References: <20180601145921.9500-1-konrad.wilk@oracle.com> <20180601145921.9500-4-konrad.wilk@oracle.com> <2a3e0323-7086-f764-1a3b-7ce4891e8784@amd.com> <20180611140116.GA26199@char.us.oracle.com> <5090fe69-61fd-99cb-f9d0-908cd6250d25@amd.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Jun 2018, Tom Lendacky wrote: > On 6/11/2018 9:01 AM, Konrad Rzeszutek Wilk wrote: > >> I think you will have to keep the case statements and explicitly check for > >> X86_FEATURE_AMD_SSBD before using SPEC_CTRL. > > > > .. we could or alternatively add an extra check for X86_FEATURE_AMD_SSBD ? > > Whichever you feel is best, so long as we only use SPEC_CTRL for SSBD on > AMD when X86_FEATURE_AMD_SSBD is present. Is there anyone working on a fix or has this been forgotten? Thanks, tglx