Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180606194144.16990-1-malat@debian.org>
References: <20180606194144.16990-1-malat@debian.org>
From:   Tony Luck <tony.luck@gmail.com>
Date:   Fri, 15 Jun 2018 11:59:10 -0700
Message-ID: <CA+8MBbKj4A5kh=hE0vcadzD+=cEAFY7OCWFCzvubu6cWULCJ0A@mail.gmail.com>
Subject: Re: [PATCH] mm/memblock: add missing include <linux/bootmem.h>
To:     Mathieu Malaterre <malat@debian.org>
Cc:     Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jun 6, 2018 at 12:41 PM, Mathieu Malaterre <malat@debian.org> wrote=
:
> Commit 26f09e9b3a06 ("mm/memblock: add memblock memory allocation apis")
> introduced two new function definitions:
>   =E2=80=98memblock_virt_alloc_try_nid_nopanic=E2=80=99
> and
>   =E2=80=98memblock_virt_alloc_try_nid=E2=80=99.
> Commit ea1f5f3712af ("mm: define memblock_virt_alloc_try_nid_raw")
> introduced the following function definition:
>   =E2=80=98memblock_virt_alloc_try_nid_raw=E2=80=99
>
> This commit adds an includeof header file <linux/bootmem.h> to provide th=
e
> missing function prototypes. Silence the following gcc warning (W=3D1):
>
>   mm/memblock.c:1334:15: warning: no previous prototype for =E2=80=98memb=
lock_virt_alloc_try_nid_raw=E2=80=99 [-Wmissing-prototypes]
>   mm/memblock.c:1371:15: warning: no previous prototype for =E2=80=98memb=
lock_virt_alloc_try_nid_nopanic=E2=80=99 [-Wmissing-prototypes]
>   mm/memblock.c:1407:15: warning: no previous prototype for =E2=80=98memb=
lock_virt_alloc_try_nid=E2=80=99 [-Wmissing-prototypes]
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>

Sadly that breaks ia64 build:

  CC      mm/memblock.o
mm/memblock.c:1340: error: redefinition of =E2=80=98memblock_virt_alloc_try=
_nid_raw=E2=80=99
./include/linux/bootmem.h:335: error: previous definition of
=E2=80=98memblock_virt_alloc_try_nid_raw=E2=80=99 was here
mm/memblock.c:1377: error: redefinition of =E2=80=98memblock_virt_alloc_try=
_nid_nopanic=E2=80=99
./include/linux/bootmem.h:343: error: previous definition of
=E2=80=98memblock_virt_alloc_try_nid_nopanic=E2=80=99 was here
mm/memblock.c:1413: error: redefinition of =E2=80=98memblock_virt_alloc_try=
_nid=E2=80=99
./include/linux/bootmem.h:327: error: previous definition of
=E2=80=98memblock_virt_alloc_try_nid=E2=80=99 was here
make[1]: *** [mm/memblock.o] Error 1
make: *** [mm/memblock.o] Error 2

-Tony