Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1362629imm; Fri, 15 Jun 2018 16:09:49 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIL4zu0Dzmpp8HVQ3ZKk5y8fz9qlmrlii36gi72WwhUt07ACy5OB0i/WapFZg4XhEEGAl8c X-Received: by 2002:a65:6319:: with SMTP id g25-v6mr3337619pgv.437.1529104189547; Fri, 15 Jun 2018 16:09:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529104189; cv=none; d=google.com; s=arc-20160816; b=D3i5wNxB0T/vZjBwhZNxwXSIbDyg/CuCPOpmuwBDOF9BJf9GizykzIbbFseIUdC4Md cSLbQZtht2tK0w3aBljEpquGOC5dlzNVipgBjCbxJoZa3pU3vRigRvkcAcc8GC5pwddj rtqMIWr8vCgob6gLQ1zn/Av2l3/FFf5Xd/k4O8omCYk5upXbwTPqsfVXMsSqe3rGhE2U /Og/fAzCZHCPUUZjM1x4bmRVTsitXmL6vKJG9z2Zpu8wC9G4CqhY3cUMhz3nnc/Xny/6 w490jX5z/zSpATC/DPC+zIt0LdHbSsRHqEfpCCg5n76SJl7zEt6efSLuOoTzOtcvkqZu bklA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature :arc-authentication-results; bh=TjHm1RDGvK+d81PIAOpBXuy1jNwfkFS3Esx0ryO77+M=; b=u9Qysshj6jF0LxsOFnoF+myCLPvss69DM6n13tKR3iTWp7m2mFkKcandk9CqgrXdHE YRX7in0DqwuFzOlnS/7mz6QUrBSeLwYrpmdKoHVfGR9uSwbGuCuOKvA3AKSLERPYdikF s5iaAJ8xGt4d5xwkeLrq1Ylv8WgdNylk3+W2+BinCMwH0Rh4qRalSIoHTjulIpq2qg6I dGYqzt5mfib5/mIeFnkgBzCkbL3Whm6H28VH6bCJ2E8mqHmumcUHeh3SejVywtNo5YBl A1wHAZI4mOAmvXtZiHPG4FRGNYA8HS3c0Ga1qPwLC7Pi1nB0zk3A+ouWDGgJIRd86gfN 0I1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=Wwxz6uOV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d10-v6si9040718pfh.119.2018.06.15.16.09.32; Fri, 15 Jun 2018 16:09:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=Wwxz6uOV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756713AbeFOXJH (ORCPT + 99 others); Fri, 15 Jun 2018 19:09:07 -0400 Received: from mail-it0-f68.google.com ([209.85.214.68]:51771 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753761AbeFOXJF (ORCPT ); Fri, 15 Jun 2018 19:09:05 -0400 Received: by mail-it0-f68.google.com with SMTP id n7-v6so4872548itn.1; Fri, 15 Jun 2018 16:09:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TjHm1RDGvK+d81PIAOpBXuy1jNwfkFS3Esx0ryO77+M=; b=Wwxz6uOVbMvYXRTXUsk4HxKBc7KkCRz3z1Nx7pz7/UFronEgjajIxMxt8kGln42WZv 3vefJAkogPcHqJVp73+MigLTC0RIIonBfj8g4lrzfEpNILVbMD8NxJ8tkjuhva6WNPsW N03AFsPPCmDrEjctuNgCL++rhbx/70St0pzt0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TjHm1RDGvK+d81PIAOpBXuy1jNwfkFS3Esx0ryO77+M=; b=NqIYatW7wO6Ow739Xzd/AyTT1Pf9p94jo+qbWYLw0xjeVYdfR3FuRRIdMXC0PLCyvU keASl6E6W26j1L3zvqaKMhcGrTlgjNvhYPzBRhptvXa0pcWoB20Qpu0oPDxRlqXiIu+0 daJTysCvvijMzIGkQhlkTX06XWYSVX+fHZxvpK6hT10iL6pzIpt8N7kcacOZIm0uaLdd Ldr9iEb6tEA0v5i2Ts61G7zWJ85TrlJzCKKvCf1mTbWOO+n5TFi28QQqNhDPBCFxbkun eot5cwJ0yhxUdWC3I9u9oljlX2E4K6i3AK0uFfiXnViMRpnuWd1k6X0xXTGxQAVrBO2Q 6tyA== X-Gm-Message-State: APt69E0vlgsOfjdQI8zYKiojXDVtS1DthBOf6HW7DwAHctgaDuRcAU2n ulsEJRchWA1dYbFJtuEZYCYDaPKdz+W00uaIYG4= X-Received: by 2002:a24:8046:: with SMTP id g67-v6mr2897923itd.16.1529104144426; Fri, 15 Jun 2018 16:09:04 -0700 (PDT) MIME-Version: 1.0 References: <1529037793-35521-1-git-send-email-wei.w.wang@intel.com> <1529037793-35521-2-git-send-email-wei.w.wang@intel.com> In-Reply-To: <1529037793-35521-2-git-send-email-wei.w.wang@intel.com> From: Linus Torvalds Date: Sat, 16 Jun 2018 08:08:53 +0900 Message-ID: Subject: Re: [PATCH v33 1/4] mm: add a function to get free page blocks To: wei.w.wang@intel.com Cc: virtio-dev@lists.oasis-open.org, Linux Kernel Mailing List , virtualization , KVM list , linux-mm , "Michael S. Tsirkin" , Michal Hocko , Andrew Morton , Paolo Bonzini , liliang.opensource@gmail.com, yang.zhang.wz@gmail.com, quan.xu0@gmail.com, nilal@redhat.com, Rik van Riel , peterx@redhat.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 15, 2018 at 2:08 PM Wei Wang wrote: > > This patch adds a function to get free pages blocks from a free page > list. The obtained free page blocks are hints about free pages, because > there is no guarantee that they are still on the free page list after > the function returns. Ack. This is the kind of simple interface where I don't need to worry about the MM code calling out to random drivers or subsystems. I think that "order" should be checked for validity, but from a MM standpoint I think this is fine. Linus