Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1378975imm; Fri, 15 Jun 2018 16:33:43 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJpoC8rmhflb1qEuARp/h3E5Sz43t8Wz0XGAvwHto8HTeV4tNwzkAeHwdZNse4AcwzV6zkM X-Received: by 2002:a63:721d:: with SMTP id n29-v6mr3308035pgc.194.1529105623402; Fri, 15 Jun 2018 16:33:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529105623; cv=none; d=google.com; s=arc-20160816; b=M459eMEPWHWOheD1pzsUEG6ZPysV/AMkaQdvpP6lRQgQNf0voyiCZvQ7XFxbgHENmt AbPfVtSQATJVH+MO1EyplIpCNPaCq85albuVR5E613DI6wrAkISst7gCo4McIcWq4UcR wn762mWnbDJNTM0IpLjQCdt5f7mUaiv+CzZ1OYnKfTVzyWtiB7KZupWUbWj27itW1tzN wCUsNZcPaOmTk35UQugT44L/mBuSLb5WxSktuCFpTqmEUW46rqENZb6Vqf6Kq/6hqSyX WYwGlqzps1tR9emoE+liwZSG+T9BgaOF/HhhUWZlSym7jJ59NZDXAeqxQCv5UhJhl6Mg MGLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=VAiARrl+oqSn2z+8IEcf9NQ1aMqdnL/b6txQI4cyEaM=; b=wkZD8DNvA3jGnh+vvixN34KnIJuIuhFDCSOnMa9Za7Z3MvIl+k/hUmx7/Knh/wod5n KI1EIxmVd9/QHEt0vL7D9qiW6neuyU/TIg1KLeJsUOXe8hXN/CqOG5m7kXQNXYdjy7BA a8LxYA+bKm3zknMu4L1Lpd8OgTsNXyYkTzWMmKd/Q1+OpMokYSzHKyq157V/e+UPEbry 9W9mOEImG9cIDJtckEy8vgeRc0kXzkzX40koa2oUeeAkPRJiR67iaqlrol34IVONob5x o8RQQKrPCU3dVdSFVejcabRTHOvohzW6biwuVdnck8FA3JgiwKg0nQUN/QJBohaRLNmg nSvw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v7-v6si9245609plz.86.2018.06.15.16.33.14; Fri, 15 Jun 2018 16:33:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756796AbeFOXcm (ORCPT + 99 others); Fri, 15 Jun 2018 19:32:42 -0400 Received: from mga07.intel.com ([134.134.136.100]:51450 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753345AbeFOXcl (ORCPT ); Fri, 15 Jun 2018 19:32:41 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jun 2018 16:32:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,228,1526367600"; d="scan'208";a="237595201" Received: from agluck-desk.sc.intel.com (HELO agluck-desk) ([10.3.52.160]) by fmsmga005.fm.intel.com with ESMTP; 15 Jun 2018 16:32:40 -0700 Date: Fri, 15 Jun 2018 16:32:40 -0700 From: "Luck, Tony" To: Andrew Morton Cc: Mathieu Malaterre , linux-mm@kvack.org, Linux Kernel Mailing List Subject: Re: [PATCH] mm/memblock: add missing include Message-ID: <20180615233236.GA17678@agluck-desk> References: <20180606194144.16990-1-malat@debian.org> <20180615121716.37fb93385825b0b2f59240cc@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This both compiles and boots on ia64. Builds OK on x86_64 with an Enterprise OS .config that includes: CONFIG_HAVE_MEMBLOCK=y CONFIG_NO_BOOTMEM=y -Tony ---- diff --git a/mm/memblock.c b/mm/memblock.c index cc16d70b8333..0a54d488f767 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -1225,6 +1225,7 @@ phys_addr_t __init memblock_alloc_try_nid(phys_addr_t size, phys_addr_t align, i return memblock_alloc_base(size, align, MEMBLOCK_ALLOC_ACCESSIBLE); } +#if defined(CONFIG_HAVE_MEMBLOCK) && defined(CONFIG_NO_BOOTMEM) /** * memblock_virt_alloc_internal - allocate boot memory block * @size: size of memory block to be allocated in bytes @@ -1432,6 +1433,7 @@ void * __init memblock_virt_alloc_try_nid( (u64)max_addr); return NULL; } +#endif /** * __memblock_free_early - free boot memory block