Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1379051imm; Fri, 15 Jun 2018 16:33:50 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLj29rayAHqiZZby9kyt3kaX1nxTyG4WxMaJHkzYNoSCqn6hlyspRVo6gujbN51ycweNn8o X-Received: by 2002:a17:902:42c3:: with SMTP id h61-v6mr4210028pld.319.1529105630554; Fri, 15 Jun 2018 16:33:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529105630; cv=none; d=google.com; s=arc-20160816; b=HXBInmwAaBn0m71EktawtL7zyP8gVAQOISN04XcXtdt1ptoSdLKI2DDV/oUa1Jn635 A/KQ6q0GlPDnoy8n+pgM77EvRS/bqcEsYLo6E7Zn6otSs/hdnJHfXUGEOhGm7F1qLjha oCeJ7poT+pvrtqL+sAiWTtTU6vDtOT0K8Y6bwDuZWZIhpb3V60kLLGbKkNxG+c1N4R39 EvFQgyBkwSYphbzZc4/PLLCYiugwk1d3Ja3mkFicoiS6TIb+C2mhqIjvzBGNxUvuTULy Nyf32spld6ATHZ6rIdrPyVxz5HR/U/tgisAG0grpf00+UbYRP2CxM5mdGv5gY1REDj8e F5cQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=771TQKyx3HFxkbPiP1OXTSSOKZ4/agX8BAJiOMdFzWg=; b=wo2v88oGCXyfwPNs1FCE+xacXgzYGjRSM2gHyBpshF7BGCLzO34vLhRLRyvqgAEK3A b15Pnj79LovT6vJjSrR3IDlTfAjS+VTnyZsv5zWMUVgSy9usAXrCeR97MaC196gr7b5W 0gFtU2gGf7WB73EqXMCQidNWKvuPMRxhiOMe2dWHcwo7tOJyayiTdS1I7p4RxXfcpc5P qKCPZwn7jh2EJbR3JzAcAZp0LsAR+AkexWq80sLPfMUstTdX2TW9hUemdYBQg94tC0wy mLSHz6FM0GfS50pq0UKJYJepf+9cWZFdLbHj3TSLhCUFnX/wjuv0IUnvwc28p4FIBuwC q5fA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=B3zbrGQS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 33-v6si9183403plk.299.2018.06.15.16.33.36; Fri, 15 Jun 2018 16:33:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=B3zbrGQS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756817AbeFOXdA (ORCPT + 99 others); Fri, 15 Jun 2018 19:33:00 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:42530 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756807AbeFOXc6 (ORCPT ); Fri, 15 Jun 2018 19:32:58 -0400 Received: by mail-pf0-f195.google.com with SMTP id w7-v6so5534948pfn.9; Fri, 15 Jun 2018 16:32:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=771TQKyx3HFxkbPiP1OXTSSOKZ4/agX8BAJiOMdFzWg=; b=B3zbrGQSc0pfJk8XmCTxOZKN92z0v7qKm2cyfqWab5hgUfXzPz2yYww4Tq9D1BiUF6 MEjMi8W6JsQ8J/odrST74JUSHgmfM5fo5FOVvQEM1n9NsKogCk3tFKMlFBMWTE8AgraY 7Z8xIoIPjfrCIZnYjhR3FkSme9nMbYMO5K0Wj9tw10xzJI8OnFRRMQpf13QyjZk+54m/ xK/fe4LGZWZTbR8mUf2pGEd6n2Bz3ZMtObvoV3qbTO+D7C0JubKtkgNu8qvEmyy9zQVh jLzGOjkK4DOHnGPxuXZnQwJSlaJ/nSO1lFBy3s6crItQXnvPuiJuFPFkWBfH/+sbNTh0 J3lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=771TQKyx3HFxkbPiP1OXTSSOKZ4/agX8BAJiOMdFzWg=; b=B4DsQ/SpGYT+w5sY1Atm7Hik7XA3KW2Gv8Vz8u2GpTbb3mGzB0MdN/s6kUcyhJ6d18 u3ZepCS+z1IQ5SW6TESGVhHd1wSFn4JCJKvDniAwGBg3WquBimQD4QyEojCmgsEwkNmM sMf3XrhcxZ/yIf+lX1MBIlFzeI73Aop8HVytsP92KRhenadrt09vWX3t9j+ch60tz3/F bfAlu59I8BwVXgYoTkZumHET/7GH5wgwoVzovhOojME0tYjBMDlU3bIkjTTuL6OCY7vX ZxfBvm98FBTLelcL01CbWkwgW899//iNnAyN1gGWHgU1ubgVMvvtStegeytbW3KokyrQ C0jQ== X-Gm-Message-State: APt69E3wwuzPNJDzViHqfO71omljO4DSM5pGgYPSb6gUC5t2PUC3T8g2 nC7AIAHjESFIHztxi86MzHc= X-Received: by 2002:a65:5143:: with SMTP id g3-v6mr3342121pgq.190.1529105577398; Fri, 15 Jun 2018 16:32:57 -0700 (PDT) Received: from [192.168.43.97] ([1.1.125.127]) by smtp.gmail.com with ESMTPSA id r2-v6sm16780476pfa.49.2018.06.15.16.32.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Jun 2018 16:32:56 -0700 (PDT) Subject: Re: [PATCH 1/3] drm: mxsfb: Change driver.name to mxsfb-drm To: Fabio Estevam , Marek Vasut Cc: "devicetree@vger.kernel.org" , "linux-fbdev@vger.kernel.org" , "marcofrk@gmail.com" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "stefan@agner.ch" , dl-linux-imx , "kernel@pengutronix.de" , Fabio Estevam , Leonard Crestez , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "l.stach@pengutronix.de" References: <47ea7572011735b68a8a70f0e11bdf00cb2fd86a.1529091248.git.leonard.crestez@nxp.com> <07be6d9a85b6be655fc2b084be81d8bf9715b57a.camel@nxp.com> <638457fd-85da-8fec-d146-517c43f71813@denx.de> From: Marek Vasut Message-ID: <22e2aecc-3735-8ad6-3f36-75ae2b8f2498@gmail.com> Date: Sat, 16 Jun 2018 01:29:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/16/2018 12:22 AM, Fabio Estevam wrote: > On Fri, Jun 15, 2018 at 6:36 PM, Marek Vasut wrote: > >> Having two drivers in the kernel with different set of bugs is always bad. > > Sure, but breaking dtb's is also bad. You picked only the first part of my argument, the less important one ;-) > Can the mxsfb driver be modified to handle the old style bindings? Maybe, but do we care ? Cfr my comment about the amount of users who will be affected by this. > The IPU drm driver is capable of handling both the old style where the > display timing is passed in dts and the new drm style. > > For example: > > arch/arm/boot/dts/imx6qdl-sabresd.dtsi uses the drm style binding > arch/arm/boot/dts/imx6qdl-sabreauto.dtsi uses the old style of passing > the display timings in dts > > Both formats are accepted by the ipu drm driver. > > Can't mxsfb drm driver support both? Then we don't need to worry about > breaking dtb's and could safely remove the mxs fbdev driver. This might be a way forward, but again, does it justify the effort ? We will be adding compatibility code which we will have to maintain for maybe a handful of users I think. -- Best regards, Marek Vasut