Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262321AbTIHNgP (ORCPT ); Mon, 8 Sep 2003 09:36:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262399AbTIHNgN (ORCPT ); Mon, 8 Sep 2003 09:36:13 -0400 Received: from mailhost.tue.nl ([131.155.2.7]:22545 "EHLO mailhost.tue.nl") by vger.kernel.org with ESMTP id S262321AbTIHNfo (ORCPT ); Mon, 8 Sep 2003 09:35:44 -0400 Date: Mon, 8 Sep 2003 15:35:42 +0200 From: Andries Brouwer To: Arnd Bergmann Cc: Linus Torvalds , Andreas Schwab , , Matthew Wilcox Subject: Re: [PATCH] use size_t for the broken ioctl numbers Message-ID: <20030908133542.GA15564@win.tue.nl> References: <200309081503.20459.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200309081503.20459.arnd@arndb.de> User-Agent: Mutt/1.3.25i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1085 Lines: 22 On Mon, Sep 08, 2003 at 03:03:20PM +0200, Arnd Bergmann wrote: > +#define _IOR(type,nr,size) _IOC(_IOC_READ,(type),(nr),(_IOC_TYPECHECK(size))) > +#define _IOW(type,nr,size) _IOC(_IOC_WRITE,(type),(nr),(_IOC_TYPECHECK(size))) > +#define _IOWR(type,nr,size) _IOC(_IOC_READ|_IOC_WRITE,(type),(nr),(_IOC_TYPECHECK(size))) > +#define _IOR_BAD(type,nr,size) _IOC(_IOC_READ,(type),(nr),sizeof(size)) > +#define _IOW_BAD(type,nr,size) _IOC(_IOC_WRITE,(type),(nr),sizeof(size)) > +#define _IOWR_BAD(type,nr,size) _IOC(_IOC_READ|_IOC_WRITE,(type),(nr),sizeof(size)) Yes, good. Then I have another trivial request: change the identifier used for the third parameter. Since it is called "size" people think that it is a size. The new checking will hit them, but still, it would be good to use the correct identifiers. What about "argtype"? Andries - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/