Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp2196996imm; Sat, 16 Jun 2018 11:44:12 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJwCtx9v2IQpCMWJ3ir2C8VCuwyoo5NoW8TY8gbl7ugpajjcb/xhqlRVZCIz4OqCe8ZTUQy X-Received: by 2002:a65:4a92:: with SMTP id b18-v6mr5813889pgu.107.1529174651949; Sat, 16 Jun 2018 11:44:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529174651; cv=none; d=google.com; s=arc-20160816; b=nLeqARVKb1BFYc/h+qDtt5fq4p/x9NoWdwqNInOFmuAHiltuGw5XvpAIJZIgPRbMGC 9pY88uMv2IcusOIvXGgF6l4EwtJ3ra8WJD7xTdtobfzwRnsv6l6vnZ3zxiOQ/QkVMm0v XDZP6AYjnIRybjgmJmOvpVMm/BirIUDkihJRt2ChMNc4VCt5jdtOEBtSAk0L3GERoGCk VfkPjahELgihC+Oqvkif/8d9Gy+0cERhAUgWqMtTqQiHW3ZVccJWPSz4Aw//t1XH6xXG Awbn5zFeqQlckevX6UOXb90KjerXgXVebimabr+65TAD13fkeSO31zq9n+ZEtCL3jcUx 7MQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature :arc-authentication-results; bh=SxnT7IeDDFvAM3/pyOC2CTcwocS6ZwOOGxIsQwg7ERk=; b=QK8DItolCQyZP/RawysU7gRE1G31C2mn8WJcCQim9TJcdcKNk64BrEa6E9XwdFlew7 vKULAVRM5C94J2f1PMPfbGtR1e/CsOs1bKjxB+uFrdHpu3RUj10QUdzHef/UwOH7QDBo L6MpTsmGL+JHgki2kk9gmDWPFvb2RZ6Ng8JkAQ0drGG4lnSukw10lPESXdgRptyVjxHy qR1kR1r2cMzkrKPwgcuNx60lyaod1hcn8kyEsFqmkEn5HSm9XtNOVvgkksryZu3nMcKL 5S2duF1ucIgb/6XNoR+lCAmuSV01hrD56FRds7l90626LU/nb+gq9MCKbvenfXtPQSvA V9lg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=LZu+yq8A; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n3-v6si10820168pld.116.2018.06.16.11.43.57; Sat, 16 Jun 2018 11:44:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=LZu+yq8A; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932903AbeFPSnG (ORCPT + 99 others); Sat, 16 Jun 2018 14:43:06 -0400 Received: from mail-ua0-f196.google.com ([209.85.217.196]:44586 "EHLO mail-ua0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932594AbeFPSnE (ORCPT ); Sat, 16 Jun 2018 14:43:04 -0400 Received: by mail-ua0-f196.google.com with SMTP id f30-v6so8427994uab.11; Sat, 16 Jun 2018 11:43:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SxnT7IeDDFvAM3/pyOC2CTcwocS6ZwOOGxIsQwg7ERk=; b=LZu+yq8AEKpzqkc91XLP8e5T9VU30DVhJaBt29EIZbStwSUz6JPdSVvT6Kr8P52C1A OD1VcbMxTpKn975b0wRvLmd4xtu50AenKpJkAtKU+6MWrovAGz3i4z0scE97lR5xAymc XrNWXyxS8iYxPw/GDPCu0aarqhGXQYg4Q1mJQHjTlJNXwFNkAQs4zDUPTa8yqmwpGPVG 9506UXIceuBKk3UQFDz8vNNxaBXK8PIJld7mmcxunZNnSKdvZGJQ+tjy7C7LVVKzu7iM 2vBlFmcGCbjQqStvda0EYZ4xCq/JqAhkIaHQy/acck8ReSdU0SepsUVEgRJ8GOfppxDQ 0S2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SxnT7IeDDFvAM3/pyOC2CTcwocS6ZwOOGxIsQwg7ERk=; b=dy0NiXU4gIPlTfeesxKMb1m9GvhnLf5xM+DDg4Ps0nEDpL4jIlhHsVXKNtGn+wpvw2 4pR6TqTMrHljA1N4tuf1CXnqPvAZtNYgOKmtcB+xCvYqrilbu3wHUE1X8rjBBjcleL30 j2ZCDguAe1Th0qUcVbcESlVJ+fEXZJOX59krr0yb1lSDPqaaJmHLiDePbZ57nBK51kiL p3Qu1Q1O3H9DSJmIQkuZDF0hrfLMhiI9DoVi2Epb47qJNrNOJa5F5MVjcpKZf8cNbmXp iOY79g5Koe96DhFjKsrF93ragn85FH1b+cBKIsWDb8/I7kcqP/hBb0ljE8LHpYrsFtsN y1kw== X-Gm-Message-State: APt69E1W+bq+DKeMDWQ45UG2vjX21qOCrRoDGepysqacFE6usNQgN2We HxFl7oGUTkY+sjpZdP83NffGjyohzlghJPsADFk= X-Received: by 2002:ab0:1b9b:: with SMTP id k27-v6mr4244618uai.122.1529174583818; Sat, 16 Jun 2018 11:43:03 -0700 (PDT) MIME-Version: 1.0 References: <20180615132017.23889-1-andriy.shevchenko@linux.intel.com> <20180615132017.23889-4-andriy.shevchenko@linux.intel.com> <20180615222346.GC371@yury-thinkpad> In-Reply-To: <20180615222346.GC371@yury-thinkpad> From: Andy Shevchenko Date: Sat, 16 Jun 2018 21:42:52 +0300 Message-ID: Subject: Re: [PATCH v2 3/5] bitmap: Add bitmap_alloc(), bitmap_zalloc() and bitmap_free() To: Yury Norov Cc: Andy Shevchenko , agk@redhat.com, Mike Snitzer , dm-devel@redhat.com, shli@kernel.org, linux-raid@vger.kernel.org, Dmitry Torokhov , linux-input , Andrew Morton , Linux Kernel Mailing List , Mika Westerberg Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 16, 2018 at 1:24 AM Yury Norov wrote: > On Fri, Jun 15, 2018 at 04:20:15PM +0300, Andy Shevchenko wrote: > > A lot of code become ugly because of open coding allocations for bitmaps. > > > > Introduce three helpers to allow users be more clear of intention > > and keep their code neat. > > I like the idea. But in following patches you switch to new API only > couple of drivers. I have converted much more, indeed. I published only for couple of drivers as an example. This is I mentioned in cover letter. > I think, it worth to switch more, especially core > users to make new API visible for developers. Brief grepping for > candidates showse only 17 suspected places: Yes, but not in this series. Since it covers many subsystems and drivers the applying that kind of series would take ages. That's why I have decided to submit for one subsystem only. -- With Best Regards, Andy Shevchenko