Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp2891519imm; Sun, 17 Jun 2018 06:40:31 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKzALacWaPedM8h8te+qUI60/DHk71ACedVmI5JmKdQnLAW25BabMmD9CNNbrEj1vvReHd8 X-Received: by 2002:a17:902:778e:: with SMTP id o14-v6mr10066116pll.214.1529242831830; Sun, 17 Jun 2018 06:40:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529242831; cv=none; d=google.com; s=arc-20160816; b=gOMMeu2C8f8/32NOFaU6aaSE5S6L1lLVCI2BI/sYQPDI2M09jYnnzpaCok1QZHFHFX ZP1pbVCs4Q7I717PD2YirHKWyaQpxS286FdWvMJ8erQvSdsiekjccL9QbNBwK7xUYSDL 7U3bKcJkQKM76L1By0WriqmaqaOUBWfwF7+iru+BPoav5IT0N/4JOMVOkQHsFKuMI5n9 +asIUNCnFAGVAMSbeF3r+u48BI6uyQfYuMD9XgFRv/7pzn1CvCkMZrwXzhgc5jtLD4UG zzKAToDi006Y4/lRlR7iC4f1R20HOYR+WOsC7frBH742Ss07xNDNbADIrMMZH6YfBAzb 2a5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id :arc-authentication-results; bh=2THukkb8AItKSXGfNO1XDH+GJYC4tbo25FeL0GEfv+8=; b=vIXjIMp9bYvQuCjXPgM3xCtlVcXIlLaoWIzT7HGShrtGZgSyJa+pGPPDFi1MGxi96a kbKEjco3ptcfMJcWpsvE/vziLSWNxKaRMohk+nh0fbqQrvXdJuRzoypLh43R2pL0P0Rs ePuhTRavMBpgGk8tEkpjw3q7a4rcj8bapUjE/pHnzHlCNA2lHp3yqzORS4y5CugbgoIF ROPT2ApLi6cdMi6XUqdv1/S559TeIEoHKSqR+Bdt02ejFlCTojEft4JABrje0cIQB1JS xbb+DWy+cBQadMizH2V42XhQJYykYz/J/jRyMXknbVfeweNHmF7Dw8uzYH0+1MgnmoSX g/iA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o11-v6si10273521pgp.586.2018.06.17.06.40.17; Sun, 17 Jun 2018 06:40:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754359AbeFQNjw (ORCPT + 99 others); Sun, 17 Jun 2018 09:39:52 -0400 Received: from mout.gmx.net ([212.227.15.19]:40979 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753970AbeFQNju (ORCPT ); Sun, 17 Jun 2018 09:39:50 -0400 Received: from homer.simpson.net ([188.174.240.203]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0LztHH-1gGirC39SV-0150dV; Sun, 17 Jun 2018 15:38:41 +0200 Message-ID: <1529242717.4472.3.camel@gmx.de> Subject: Re: [tip:x86/pti] x86/asm: Pad assembly functions with INT3 instructions From: Mike Galbraith To: Borislav Petkov Cc: Alexey Dobriyan , torvalds@linux-foundation.org, tglx@linutronix.de, mingo@kernel.org, jpoimboe@redhat.com, luto@kernel.org, peterz@infradead.org, brgerst@gmail.com, hpa@zytor.com, linux-kernel@vger.kernel.org, dvlasenk@redhat.com, h.peter.anvin@intel.com, linux-tip-commits Date: Sun, 17 Jun 2018 15:38:37 +0200 In-Reply-To: <20180617120012.GB16877@zn.tnic> References: <20180507213755.GA32406@avx2> <1529235613.4572.7.camel@gmx.de> <20180617120012.GB16877@zn.tnic> Content-Type: text/plain; charset="ISO-8859-15" X-Mailer: Evolution 3.26.6 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:pwCDEx0mG02bUtnWVpbGK0xYugS/A5fGADDKPwvcBIKucazboKV GiHDlRIDY5KuMC5UzSUBiWVSg5u1krMKeeppj1RVIvIKYB0gfsgDoJ+DagXq03Ot6/+YjXT o//c0tlaNSLGG5mXHDTG6MVsNDtKIS+EXjKOlIk4Iai3qcOAtVIrkv5+pqUt1RPMAEBiWPI smUFuPyoGBkHBJBMam3jQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:zDnIGCRwvXc=:ebuhYf7/7oJ5SsE+TVR4ui O1lWhQTsY2oSMHza3Ymcy4ZVDHrQMaEsKRC16ReGE2Qde8CCbX0RzupyvsWGV6RrKC2BNs6Zd 0GtDTF6fBFYeVh7+cKS901d9+9se8h1y9IV+uolfJFSzxAi6Fhbj+AOB9BNGy324v3gGB9F+Q PKW1b+kyDpDOY6POdvXkaVi+P7gGoAzocFLNbitPFuxTio2C4FjMtFUXK3DmlnH43UGr61tBn DEVhGl9H3P4xYF4aziFGx3PZvTOUfH4jWljAGFTL3Jg1AB/48DwoVUJKnjdOEzdiQu+MJxvRT MhZmx3iCANYJTkU07n6bQBl+wvWXJ2QjtELHjuSiAih4YHeWiKeHA6xEKJF0LnndUSdM90zm8 +uxFb1uZme42bmO8FjvGotS5cL467ZOM1gemaiYlcAQEgaYDgjvgktcFxRDsScX650iypPNAX PA2d67/xTyL4Af5tHDPGFx5N0OkqtLNSSz1NXeydEyIAyXjPogxQS807VJDw3ZbufqxevTf+H X14Z3rKRav35P+BJ3zby2uCKO57pptVI5flbh+jq4C1I5sSa5HUGoeMSf/EnnEIIpMEqJf6d6 0c2p5yYXLClA6sRD0K8vgUFlNIvQFY097U2QLILzjEkLXOX1BA/JhnxXXIMbN3UwwJvk+0s80 8Lxu/kqH94puILVpDPZpeKVl7kRbaahpCedHu4jbSRQD4bcriVifn2Yvx+DQcjHJXNavigF42 TzrQmJbsgBYDhgxulKJwR1B/F7rwTp/MGaBL0f8WB46jn7zfakjVoHZ9DqTSZClo+PbezmNvL zCy8cW5 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2018-06-17 at 14:00 +0200, Borislav Petkov wrote: > On Sun, Jun 17, 2018 at 01:40:13PM +0200, Mike Galbraith wrote: > > On Mon, 2018-05-14 at 05:53 -0700, tip-bot for Alexey Dobriyan wrote: > > > Commit-ID: 51bad67ffbce0aaa44579f84ef5d05597054ec6a > > > Gitweb: https://git.kernel.org/tip/51bad67ffbce0aaa44579f84ef5d05597054ec6a > > > Author: Alexey Dobriyan > > > AuthorDate: Tue, 8 May 2018 00:37:55 +0300 > > > Committer: Ingo Molnar > > > CommitDate: Mon, 14 May 2018 11:43:03 +0200 > > > > > > x86/asm: Pad assembly functions with INT3 instructions > > > > > > Use INT3 instead of NOP. All that padding between functions is > > > an illegal area, no legitimate code should jump into it. > > > > Is dinky patchlet suggesting cryptomgr is being naughty? > > > > (revert silences spew, but..) > > > > ... > > [ 21.041608] int3: 0000 [#1] SMP PTI > > [ 21.041754] CPU: 3 PID: 935 Comm: cryptomgr_test Tainted: G E 4.17.0.g075a1d3-tip-default #146 > > [ 21.041888] Hardware name: MEDION MS-7848/MS-7848, BIOS M7848W08.20C 09/23/2013 > > [ 21.042035] RIP: 0010:crypto_aegis128_aesni_enc_tail+0x74/0x80 [aegis128_aesni] > > [ 21.042171] Code: 38 dc ca 66 0f 38 dc d3 66 0f 38 dc de 66 0f ef e5 f3 0f 7f 27 f3 0f 7f 47 10 f3 0f 7f 4f 20 f3 0f 7f 57 30 f3 0f 7f 5f 40 cc cc cc cc cc cc cc cc cc cc cc cc 48 83 fe 10 0f 82 c3 03 00 00 > > Looks like it misses a RET: Bingo. [ 28.751069] RIP: 0010:crypto_aegis128l_aesni_enc_tail+0xcd/0xd0 [aegis128l_aesni] Next next next.. > --- > From 6ac281ee69f4cb5b581d5f49662fb56b6326155a Mon Sep 17 00:00:00 2001 > From: Borislav Petkov > Date: Sun, 17 Jun 2018 13:57:42 +0200 > Subject: [PATCH] x86/crypto: Add a missing RET > > crypto_aegis128_aesni_enc_tail() needs to return too. > > Signed-off-by: Borislav Petkov > --- > arch/x86/crypto/aegis128-aesni-asm.S | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/crypto/aegis128-aesni-asm.S b/arch/x86/crypto/aegis128-aesni-asm.S > index 9254e0b6cc06..717bf0776421 100644 > --- a/arch/x86/crypto/aegis128-aesni-asm.S > +++ b/arch/x86/crypto/aegis128-aesni-asm.S > @@ -535,6 +535,7 @@ ENTRY(crypto_aegis128_aesni_enc_tail) > movdqu STATE3, 0x40(STATEP) > > FRAME_END > + ret > ENDPROC(crypto_aegis128_aesni_enc_tail) > > .macro decrypt_block a s0 s1 s2 s3 s4 i > -- > 2.17.0.582.gccdcbd54c >