Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1529273537.2289.239.camel@codethink.co.uk>
Subject: Re: [PATCH 4.4 229/268] media: cx23885: Set subdev host data to
 clk_freq pointer
From:   Ben Hutchings <ben.hutchings@codethink.co.uk>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org
Cc:     stable@vger.kernel.org, Brad Love <brad@nextdimension.cc>,
        Mauro Carvalho Chehab <mchehab@s-opensource.com>,
        Sasha Levin <alexander.levin@microsoft.com>
Date:   Sun, 17 Jun 2018 23:12:17 +0100
In-Reply-To: <20180528100229.115203250@linuxfoundation.org>
References: <20180528100202.045206534@linuxfoundation.org>
         <20180528100229.115203250@linuxfoundation.org>
Organization: Codethink Ltd.
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 2018-05-28 at 12:03 +0200, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Brad Love <brad@nextdimension.cc>
> 
> [ Upstream commit 5ceade1d97fc6687e050c44c257382c192f56276 ]
> 
> Currently clk_freq is ignored entirely, because the cx235840 driver
> configures the xtal at the chip defaults. This is an issue if a
> board is produced with a non-default frequency crystal. If clk_freq
> is not zero the cx25840 will attempt to use the setting provided,
> or fall back to defaults otherwise.

This depends on (at least):

commit 3ee9bc12342cf546313d300808ff47d7dbb8e7db
Author: Brad Love <brad@nextdimension.cc>
Date:   Tue Mar 6 14:15:34 2018 -0500

    media: cx25840: Use subdev host data for PLL override

Ben.

> Signed-off-by: Brad Love <brad@nextdimension.cc>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
> Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  drivers/media/pci/cx23885/cx23885-cards.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> --- a/drivers/media/pci/cx23885/cx23885-cards.c
> +++ b/drivers/media/pci/cx23885/cx23885-cards.c
> @@ -2124,6 +2124,10 @@ void cx23885_card_setup(struct cx23885_d
>  				&dev->i2c_bus[2].i2c_adap,
>  				"cx25840", 0x88 >> 1, NULL);
>  		if (dev->sd_cx25840) {
> +			/* set host data for clk_freq configuration */
> +			v4l2_set_subdev_hostdata(dev->sd_cx25840,
> +						&dev->clk_freq);
> +
>  			dev->sd_cx25840->grp_id = CX23885_HW_AV_CORE;
>  			v4l2_subdev_call(dev->sd_cx25840, core, load_fw);
>  		}

-- 
Ben Hutchings, Software Developer                         Codethink Ltd
https://www.codethink.co.uk/                 Dale House, 35 Dale Street
                                     Manchester, M1 2HF, United Kingdom