Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   valdis.kletnieks@vt.edu
To:     Nicolas Pitre <nicolas.pitre@linaro.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Dave Mielke <Dave@mielke.cc>,
        Samuel Thibault <samuel.thibault@ens-lyon.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] vt: preserve unicode values corresponding to screen characters
In-Reply-To: <20180617190706.14614-2-nicolas.pitre@linaro.org>
References: <20180617190706.14614-1-nicolas.pitre@linaro.org>
 <20180617190706.14614-2-nicolas.pitre@linaro.org>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="==_Exmh_1529276384_2593P";
         micalg=pgp-sha1; protocol="application/pgp-signature"
Content-Transfer-Encoding: 7bit
Date:   Sun, 17 Jun 2018 18:59:44 -0400
Message-ID: <117799.1529276384@turing-police.cc.vt.edu>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--==_Exmh_1529276384_2593P
Content-Type: text/plain; charset=us-ascii

On Sun, 17 Jun 2018 15:07:03 -0400, Nicolas Pitre said:

> diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
> index 1eb1a376a0..7b636638b3 100644
> --- a/drivers/tty/vt/vt.c
> +++ b/drivers/tty/vt/vt.c
> @@ -317,6 +317,171 @@ void schedule_console_callback(void)
>  	schedule_work(&console_work);
>  }
>
> +/*
> + * Code to manage unicode-based screen buffers
> + */
> +
> +#ifdef NO_VC_UNI_SCREEN

This preprocessor variable seems to be dangling in the breeze, with
no way for it to get set?  As a result, we pick up the #else define by
default.

--==_Exmh_1529276384_2593P
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Comment: Exmh version 2.8.0 04/21/2017

iQEVAwUBWybn4I0DS38y7CIcAQI9hgf+KaUp8bw6OLI3BroIso2q62HSKJZJSImI
bkhkcR5hEODpXgfJfRnIkDhVZ7SgMWxmyHQyF6qWz0eR/5rPCaOo9by9Vyc187LH
AVidMis4qgQTWYIPGVFICfjNBMSHU2Rya590Tf8B6Cld5SgirKsqQy1ELXwlKJ/4
b9txVlkYd4pkoi3CTVydFgQ4hu99hfNS5qOFwQIKDPl+nMDLG5JMUCjmjv1JrYnZ
2s1P5I/wUtqyOBoUrJmaRdcjoyBo1BJ/opdyH5Nz8m6WGMO9vTMcXN2BDrO1fUzt
qoyIQg7YvO/yN9Hb8tfENoCLYbHndVlt8UXf01vkd3t8dn7G+zy46Q==
=Gzaz
-----END PGP SIGNATURE-----

--==_Exmh_1529276384_2593P--