Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 17 Jun 2018 19:17:51 -0400 (EDT)
From:   Nicolas Pitre <nicolas.pitre@linaro.org>
To:     valdis.kletnieks@vt.edu
cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Dave Mielke <Dave@mielke.cc>,
        Samuel Thibault <samuel.thibault@ens-lyon.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] vt: preserve unicode values corresponding to
 screen characters
In-Reply-To: <117799.1529276384@turing-police.cc.vt.edu>
Message-ID: <nycvar.YSQ.7.76.1806171909250.16670@knanqh.ubzr>
References: <20180617190706.14614-1-nicolas.pitre@linaro.org> <20180617190706.14614-2-nicolas.pitre@linaro.org> <117799.1529276384@turing-police.cc.vt.edu>
User-Agent: Alpine 2.21 (LFD 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, 17 Jun 2018, valdis.kletnieks@vt.edu wrote:

> On Sun, 17 Jun 2018 15:07:03 -0400, Nicolas Pitre said:
> 
> > diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
> > index 1eb1a376a0..7b636638b3 100644
> > --- a/drivers/tty/vt/vt.c
> > +++ b/drivers/tty/vt/vt.c
> > @@ -317,6 +317,171 @@ void schedule_console_callback(void)
> >  	schedule_work(&console_work);
> >  }
> >
> > +/*
> > + * Code to manage unicode-based screen buffers
> > + */
> > +
> > +#ifdef NO_VC_UNI_SCREEN
> 
> This preprocessor variable seems to be dangling in the breeze, with
> no way for it to get set?  As a result, we pick up the #else define by
> default.

That's actually what's intended here.

If vc_screen.c ever becomes configurable then this could be used to 
compile out this code. Or if someone wants to disable it for some 
debugging reasons. For now it is just a self-explanatory placeholder 
with very little chance of being set by mistake for any other purpose.


Nicolas