Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   valdis.kletnieks@vt.edu
To:     Nicolas Pitre <nicolas.pitre@linaro.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Dave Mielke <Dave@mielke.cc>,
        Samuel Thibault <samuel.thibault@ens-lyon.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] vt: preserve unicode values corresponding to screen characters
In-Reply-To: <nycvar.YSQ.7.76.1806171909250.16670@knanqh.ubzr>
References: <20180617190706.14614-1-nicolas.pitre@linaro.org> <20180617190706.14614-2-nicolas.pitre@linaro.org> <117799.1529276384@turing-police.cc.vt.edu>
 <nycvar.YSQ.7.76.1806171909250.16670@knanqh.ubzr>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="==_Exmh_1529277815_2593P";
         micalg=pgp-sha1; protocol="application/pgp-signature"
Content-Transfer-Encoding: 7bit
Date:   Sun, 17 Jun 2018 19:23:35 -0400
Message-ID: <204888.1529277815@turing-police.cc.vt.edu>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--==_Exmh_1529277815_2593P
Content-Type: text/plain; charset=us-ascii

On Sun, 17 Jun 2018 19:17:51 -0400, Nicolas Pitre said:
> On Sun, 17 Jun 2018, valdis.kletnieks@vt.edu wrote:

> > This preprocessor variable seems to be dangling in the breeze, with
> > no way for it to get set?  As a result, we pick up the #else define by
> > default.
>
> That's actually what's intended here.
>
> If vc_screen.c ever becomes configurable then this could be used to
> compile out this code. Or if someone wants to disable it for some
> debugging reasons. For now it is just a self-explanatory placeholder
> with very little chance of being set by mistake for any other purpose.

Oh, OK.  It's code that makes sense if it's intentional - but could just as
easily been an unintended debugging/whatever leftover...

--==_Exmh_1529277815_2593P
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Comment: Exmh version 2.8.0 04/21/2017

iQEVAwUBWybtd40DS38y7CIcAQIQFQf9HXDPSvciReAmSJmv1yDb1Z5NEvELgzHO
fsYkumb/fRffwTt3aKQYXSw6ijwd6TqonpUVpdpWAgfSKtjaJQNlBbLQubu5j0zJ
FK0cIbFSLf0ABcOtafFqaLIVSIrfbjrKyCBCTGllxlocZxE60zYWdTnhnzwFYN66
32+qGShB/y6x9X8irJMEiZWya5iLutlrUTbsOBGXVg1dxzTv3LtcmnMZX/308qwD
iGZMqXFWeg16hNAAADCbTh4UlNBZ7P3xJVGQZKO0sn5sCMvDxNHyqc1FAitQeadf
/+Dgv5ZHF8SXRlzjUzBbhq2VQuZ+cXhFd8XiiNz2xzhsWiAIZKchwA==
=k3xZ
-----END PGP SIGNATURE-----

--==_Exmh_1529277815_2593P--