Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] drm/amdgpu: use first uvd instance to avoid clang build
 error
To:     Stefan Agner <stefan@agner.ch>,
        Alex Deucher <alexander.deucher@amd.com>
Cc:     James Zhu <James.Zhu@amd.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        "David (ChunMing) Zhou" <David1.Zhou@amd.com>,
        David Airlie <airlied@linux.ie>, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20180617085218.7753-1-stefan@agner.ch>
From:   James Zhu <jamesz@amd.com>
Organization: AMD RTG
Message-ID: <625b2c05-c923-cd5c-cc48-cbc51ba3d3ee@amd.com>
Date:   Sun, 17 Jun 2018 22:03:40 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <20180617085218.7753-1-stefan@agner.ch>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Received-SPF: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jun 2018 02:03:44.8341 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: fad608ab-7d62-482a-677b-08d5d4bfb917
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB0107
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2018-06-17 04:52 AM, Stefan Agner wrote:
> Explicitly use the first uvd instance to avoid a build error when
> using clang 6:
> drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:1148:52: error: expected ')'
>                  container_of(work, struct amdgpu_device, uvd.inst->idle_work.work);
>                                                                   ^
> drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:1148:3: note: to match this '('
>                  container_of(work, struct amdgpu_device, uvd.inst->idle_work.work);
>                  ^
> ./include/linux/kernel.h:967:21: note: expanded from macro 'container_of'
>          ((type *)(__mptr - offsetof(type, member))); })
>                             ^
> ./include/linux/stddef.h:17:32: note: expanded from macro 'offsetof'
>                                  ^
> ./include/linux/compiler-gcc.h:170:20: note: expanded from macro
>        '__compiler_offsetof'
>          __builtin_offsetof(a, b)
>                            ^
> drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:1147:24: error: initializing
>        'struct amdgpu_device *' with an expression of incompatible type 'void'
>          struct amdgpu_device *adev =
>                                ^
> 2 errors generated.
>
> Fixes: 10dd74eac4db ("drm/amdgpu/vg20:Restruct uvd.inst to support multiple instances")
> Cc: James Zhu <James.Zhu@amd.com>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> index bcf68f80bbf0..6666a5888c44 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> @@ -1145,7 +1145,7 @@ int amdgpu_uvd_get_destroy_msg(struct amdgpu_ring *ring, uint32_t handle,
>   static void amdgpu_uvd_idle_work_handler(struct work_struct *work)
>   {
>   	struct amdgpu_device *adev =
> -		container_of(work, struct amdgpu_device, uvd.inst->idle_work.work);
> +		container_of(work, struct amdgpu_device, uvd.inst[0].idle_work.work);
Hi Alex,
If all instances share one idle work from hardware view currently and in 
the future ,
should we move struct delayed_work idle_work from struct amdgpu_uvd_inst 
to struct amdgpu_uvd?
James
>   	unsigned fences = 0, i, j;
>   
>   	for (i = 0; i < adev->uvd.num_uvd_inst; ++i) {