Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 18 Jun 2018 07:37:50 +0100
From:   Lee Jones <lee.jones@linaro.org>
To:     Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc:     linux-kernel@vger.kernel.org,
        Gwendal Grignou <gwendal@chromium.org>, kernel@collabora.com
Subject: Re: [PATCH v2 3/8] mfd: cros_ec: Add or fix SPDX-License-Identifier
 in all files.
Message-ID: <20180618063750.GH31141@dell>
References: <20180605175429.9072-1-enric.balletbo@collabora.com>
 <20180605175429.9072-4-enric.balletbo@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20180605175429.9072-4-enric.balletbo@collabora.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 05 Jun 2018, Enric Balletbo i Serra wrote:

> And get rid of the license text that is no longer necessary. Also fix
> the license as sometimes doesn't match what the header with the value in
> the MODULE_LICENSE macro. Assuming that the desired license is GPL-2.0+,
> all the files are updated to this license version.
> 
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
> 
> Changes in v2: None
> 
>  drivers/mfd/cros_ec.c                | 26 ++++++++------------------
>  drivers/mfd/cros_ec_dev.c            | 23 +++++------------------
>  drivers/mfd/cros_ec_dev.h            | 16 ++--------------
>  drivers/mfd/cros_ec_i2c.c            | 18 ++++--------------
>  drivers/mfd/cros_ec_spi.c            | 20 +++++---------------
>  include/linux/mfd/cros_ec.h          | 10 +---------
>  include/linux/mfd/cros_ec_commands.h | 10 +---------
>  include/linux/mfd/cros_ec_lpc_mec.h  | 14 +++-----------
>  include/linux/mfd/cros_ec_lpc_reg.h  | 14 +++-----------
>  9 files changed, 32 insertions(+), 119 deletions(-)
> 
> diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c
> index 58e05069163e..5b6a1c541543 100644
> --- a/drivers/mfd/cros_ec.c
> +++ b/drivers/mfd/cros_ec.c
> @@ -1,21 +1,11 @@
> -/*
> - * ChromeOS EC multi-function device
> - *
> - * Copyright (C) 2012 Google, Inc
> - *
> - * This software is licensed under the terms of the GNU General Public
> - * License version 2, as published by the Free Software Foundation, and
> - * may be copied, distributed, and modified under those terms.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - *
> - * The ChromeOS EC multi function device is used to mux all the requests
> - * to the EC device for its multiple features: keyboard controller,
> - * battery charging and regulator control, firmware update.
> - */
> +// SPDX-License-Identifier: GPL-2.0+
> +// ChromeOS EC multi-function device.
> +//
> +// Copyright (C) 2012 Google, Inc
> +//
> +// The ChromeOS EC multi function device is used to mux all the requests
> +// to the EC device for its multiple features: keyboard controller,
> +// battery charging and regulator control, firmware update.

I must admit I haven't seen a great many patches like this.  Is C++
comments for the SPDX header *and* the Copyright text the done thing
now then?

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog