Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp3643710imm; Mon, 18 Jun 2018 01:26:06 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIp3pmiBvakRitJux4jwjmF8xJz0vaAshHgmAwVFkWA5cPThiQ7LbCk6nytB3d23Ww2OZuF X-Received: by 2002:a62:d388:: with SMTP id z8-v6mr12623561pfk.8.1529310366761; Mon, 18 Jun 2018 01:26:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529310366; cv=none; d=google.com; s=arc-20160816; b=mipad3dh6aoKC5ovAgs0DiJnwxZNAfdJMHD68irlNYD3Bx9HbOHraHmNuk0udI6IPp KEVNiOXFf3qGTW1DH6xLpxnlJMN6qYwLPoAS3+DweG87rxVlldljgJ6HaedzUKtMKm+N y3ISb1ZQFACK+v/ciFhr9ApbpzIhCVeYTFMsAYaAEP39yZw/RVI92Aae8UksfxU5e/6d InEi2Tyk+jx43Y3r5AtkH2dYwviB6A79mILQKoM9qWh1RSiMexT6xhrs1zpEhgmtpVdD It+LaBaGamB75/NAe1W3XDSxfnmoJ9E12UiWdneUWhHZbdhJbpHIw+HwRJYnb7/eZ5MH x0qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=HJ/ong1H/USLSgA/CBAf1RXMfhKiGtAXFO/4xLZx1X4=; b=OYvIozpca13an9FQLa7YafWcsT5molI6tGYZtV1nPqHPuRX3EMVIi9yopPAUB52NZS Hfb1R5ZUuL0mdtGcNXvwjfSFSCm8hPSMJBGFoSAZ7FQ2IwJ1jdiunsWAOkaHxybTnm7X RHhvIBhEObL/F0F4IGedEc+j64qjMQvOW2CQFyjfQC7smL7rnaqZNE+ZTBv8vs8xfK9q QyJglkaiKcAtEW50Xf9+YQ4xGIhxfgzQmS8/knjFhbeFD8jTA4EVhpVruPxqG7o7v8Jy F8LAz3+YvWnwmyKhqHTBp8H5kGWy1dT82mquYFYtv8sq3fLMbwgHmM1fMlgsrybXRKAP F1LA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z3-v6si11872741pgr.49.2018.06.18.01.25.53; Mon, 18 Jun 2018 01:26:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936154AbeFRIYb (ORCPT + 99 others); Mon, 18 Jun 2018 04:24:31 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:56014 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936091AbeFRIYW (ORCPT ); Mon, 18 Jun 2018 04:24:22 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 3909CBAD; Mon, 18 Jun 2018 08:24:21 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tomi Valkeinen , Benoit Parrot , Peter Ujfalusi , Sean Paul , Sasha Levin Subject: [PATCH 4.16 195/279] drm/omap: check return value from soc_device_match Date: Mon, 18 Jun 2018 10:13:00 +0200 Message-Id: <20180618080616.985131718@linuxfoundation.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180618080608.851973560@linuxfoundation.org> References: <20180618080608.851973560@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.16-stable review patch. If anyone has any objections, please let me know. ------------------ From: Tomi Valkeinen [ Upstream commit 4d6cb5e2fee52af17001e92950f0894304706ee4 ] soc_device_match() can return NULL, so add a check and fail if soc_device_match() fails. Signed-off-by: Tomi Valkeinen Link: https://patchwork.freedesktop.org/patch/msgid/20180502091159.7071-2-tomi.valkeinen@ti.com Reviewed-by: Benoit Parrot Reviewed-by: Peter Ujfalusi Signed-off-by: Sean Paul Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/omapdrm/dss/hdmi4_core.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) --- a/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c +++ b/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c @@ -922,8 +922,13 @@ int hdmi4_core_init(struct platform_devi { const struct hdmi4_features *features; struct resource *res; + const struct soc_device_attribute *soc; - features = soc_device_match(hdmi4_soc_devices)->data; + soc = soc_device_match(hdmi4_soc_devices); + if (!soc) + return -ENODEV; + + features = soc->data; core->cts_swmode = features->cts_swmode; core->audio_use_mclk = features->audio_use_mclk;