Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp3670753imm;
        Mon, 18 Jun 2018 01:59:42 -0700 (PDT)
X-Google-Smtp-Source: ADUXVKKdxwhwVuCM0tA8dv/rqGTQKG8KAy7+gvIxx3w2xo0Yb9b9TUZniI3sbTEfg7r7xLdKSI8U
X-Received: by 2002:a65:578c:: with SMTP id b12-v6mr10396706pgr.315.1529312382146;
        Mon, 18 Jun 2018 01:59:42 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1529312382; cv=none;
        d=google.com; s=arc-20160816;
        b=R57y5XE2/jTkfG+bAg0wkiCtA8aQuXqEvPrKElSsPCXo+MC6yW91zCHBE/ZNtOQacV
         KanFVBnUMEr2s+dak7P9i6wTBN3XnUBQTwuSUP4JvR+mVgJjWmW+/mAKcSDhj4YpOAdh
         Li/cEMbpxe+hkexLqoT2Ve5KLb6FzS8yw8j6ObuE3XXtVrX3TFDngIK5VAfOEyGAb4De
         A5CX/QKvoTwE4PGe/4OTqzYXRnHUjt/zmiwF0ZHVy8GQkOYUNdAh4b9qaFri2WLQgsbC
         hyhDIroMg3wWanLFwxbNrv8eV3ScjZP8dRBUGpM61ChhlA33Q7/m4I5OTG1PeowqhlbP
         Vnmw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:organization:in-reply-to
         :content-disposition:mime-version:references:mail-followup-to
         :message-id:subject:cc:to:from:date:arc-authentication-results;
        bh=P3vYOULvbL/oDifrRJhJNvJMcjNcgK9STNAZei7BdqQ=;
        b=BSZ0fDK5BZ/hKF1pnTr+px4Ixvd5OTcT2OC14IJjgeTOdytQLRr0+mr3JOHuYrfwFs
         fyAc6cHQ1zYWZ8UatwJFoo+JkonfW73oSp6C9tndwXxGadBBopkbLm9bxyni9aW0M9rG
         nT9rH8XLJxU7TumVJFw6W+76CFz5UNQCyq1DQEluRMQntafIADVD9um6zdfdfhOz1x+9
         9YcAYKwpiR+MWXPVbjYYiE2sQBEYOK5QMjn+U8tWA5AM89vDr1vtvjFNz2DlBQ/atFvr
         TBY6y5P5DALmuNmrvMujrIqWUjKwJ4hDNqdaDO5wqMJwAzOtI5XxYjgQJaEmHkWMCnWc
         yp/w==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id f90-v6si4908614plf.390.2018.06.18.01.59.28;
        Mon, 18 Jun 2018 01:59:42 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S967670AbeFRI6i (ORCPT <rfc822;chenl.lei@gmail.com> + 99 others);
        Mon, 18 Jun 2018 04:58:38 -0400
Received: from hera.aquilenet.fr ([185.233.100.1]:57174 "EHLO
        hera.aquilenet.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S966711AbeFRI6g (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 18 Jun 2018 04:58:36 -0400
Received: from localhost (localhost [127.0.0.1])
        by hera.aquilenet.fr (Postfix) with ESMTP id 2874CFA5;
        Mon, 18 Jun 2018 10:58:35 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at aquilenet.fr
Received: from hera.aquilenet.fr ([127.0.0.1])
        by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
        with ESMTP id 8ThKQAQvqf6N; Mon, 18 Jun 2018 10:58:34 +0200 (CEST)
Received: from var.youpi.perso.aquilenet.fr (dhcp-13-150.lip.ens-lyon.fr [140.77.13.150])
        by hera.aquilenet.fr (Postfix) with ESMTPSA id 8A1DA6AC;
        Mon, 18 Jun 2018 10:58:34 +0200 (CEST)
Received: from samy by var.youpi.perso.aquilenet.fr with local (Exim 4.91)
        (envelope-from <samuel.thibault@ens-lyon.org>)
        id 1fUpze-0007G5-79; Mon, 18 Jun 2018 10:58:34 +0200
Date:   Mon, 18 Jun 2018 10:58:34 +0200
From:   Samuel Thibault <samuel.thibault@ens-lyon.org>
To:     Justin Skists <justin.skists@juzza.co.uk>
Cc:     devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
        "Speakup is a screen review system for Linux." 
        <speakup@linux-speakup.org>, Gregory Nowak <greg@gregn.net>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: speakup: refactor synths array to use a list
Message-ID: <20180618085834.an3h4ykz4t3j3epl@var.youpi.perso.aquilenet.fr>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
        Justin Skists <justin.skists@juzza.co.uk>,
        devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
        "Speakup is a screen review system for Linux." <speakup@linux-speakup.org>,
        Gregory Nowak <greg@gregn.net>, linux-kernel@vger.kernel.org
References: <20180604095212.GA18381@tanglefoot>
 <20180606132628.fxykchbznrwzgwqt@var.youpi.perso.aquilenet.fr>
 <20180611225703.csi47cdafhy6rxcf@var.youpi.perso.aquilenet.fr>
 <20180611235122.GA28343@gregn.net>
 <20180612063105.7urgjfckrwjvqs6k@var.youpi.perso.aquilenet.fr>
 <20180618053444.GA1614@gregn.net>
 <1117674358.626563.1529311304239@email.1and1.co.uk>
 <20180618084634.j3jugh3gqnl2bz7o@var.youpi.perso.aquilenet.fr>
 <2123576446.627448.1529312132509@email.1and1.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2123576446.627448.1529312132509@email.1and1.co.uk>
Organization: I am not organized
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Justin Skists, le lun. 18 juin 2018 09:55:32 +0100, a ecrit:
> When I was going through the driver code, to become familiar with it, there
> were a few places that I thought needed a closer look.

Yes, cleanup work is probably needed in various places.

Samuel