Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp3700512imm; Mon, 18 Jun 2018 02:33:56 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJWcBJZjPuKYFXiU3Hofpl8ncfB1fihEylONGa6vxoViuKZB/sJkn9O+YwBqqJnuR2sPXXi X-Received: by 2002:a63:5401:: with SMTP id i1-v6mr10096430pgb.187.1529314436023; Mon, 18 Jun 2018 02:33:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529314435; cv=none; d=google.com; s=arc-20160816; b=qHQTxNny5j4mxO308W3JEtV/FOsWEn0PVjZ3EhU4KDde8k1IGUWeV/kuW8j0dHuPmi 49CJ+QxMI04wEvGfJAMUdBIBm/rA9JZ9JM7iuF6iylkZP2ydHfeZb3tKc1g62qCGSaCP U7Yk98NcL6n/Gn5aVBR1HIcA9vX43qrWdOq2g+BJkqzKcKFHk+e2EiYD8lR0FfHXZgP2 xco97C8QtPhTwu6Km25yUlDLIPjTg9RY2g/ToKjwZmQhdQP9I2bdtuJGfQOKLWbwUTf3 8U/RCvgPCSgRcLN0F7siSpahuah7DUiNxhySeMQrPhKAt/I3lw6I53kwzPNT1OLKA+Pf yG/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=dMKE2kr3lk9vdEif7BAfirCWNf/Ulb83zMM0oo5BRFA=; b=ad0C9I3guVdxoo0zYelEbKQ1+qf9xVf4+EIZW4okKDrSUefS/033u3HPN+CI0Opsw9 EAzQKmPiV/pEf0NV9K5iVf4LTOP+wEJEkOX0jpWfWY90MUKigRDU8kV1x7EjG0jgUKmL ZI1RPtJ7MQlxGtZ/NkpBCiJLrdx2r4DaeA+eHuW9myLzBTxw5rcHlImbad1U2cKKEg+Q v3FU0SauN8d2BtAgcm3dHN4JIMN+W26cu1cSUBwqPLhFkm8JnUYX09R7dT86/iZR8EOf SIMnJc0wc3wlT7tOUnVx0D+rLioUM4GBZOAL4/fpe/VHwP3Y/80w/uHXz/BaadtsDrzX 2reA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d2-v6si14909320plo.42.2018.06.18.02.33.41; Mon, 18 Jun 2018 02:33:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936473AbeFRJcR (ORCPT + 99 others); Mon, 18 Jun 2018 05:32:17 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:56100 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936210AbeFRIYp (ORCPT ); Mon, 18 Jun 2018 04:24:45 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 058DBBAD; Mon, 18 Jun 2018 08:24:44 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ma Yuying , Igor Russkikh , "David S. Miller" , Sasha Levin Subject: [PATCH 4.16 202/279] net: aquantia: driver should correctly declare vlan_features bits Date: Mon, 18 Jun 2018 10:13:07 +0200 Message-Id: <20180618080617.257018691@linuxfoundation.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180618080608.851973560@linuxfoundation.org> References: <20180618080608.851973560@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.16-stable review patch. If anyone has any objections, please let me know. ------------------ From: Igor Russkikh [ Upstream commit 8c61ab7f111a2b29d051348b9cb9a39804ebf1f8 ] In particular, not reporting SG forced skbs to be linear for vlan interfaces over atlantic NIC. With this fix it is possible to enable SG feature on device and therefore optimize performance. Reported-by: Ma Yuying Signed-off-by: Igor Russkikh Signed-off-by: David S. Miller Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c +++ b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c @@ -246,6 +246,8 @@ void aq_nic_ndev_init(struct aq_nic_s *s self->ndev->hw_features |= aq_hw_caps->hw_features; self->ndev->features = aq_hw_caps->hw_features; + self->ndev->vlan_features |= NETIF_F_HW_CSUM | NETIF_F_RXCSUM | + NETIF_F_RXHASH | NETIF_F_SG | NETIF_F_LRO; self->ndev->priv_flags = aq_hw_caps->hw_priv_flags; self->ndev->priv_flags |= IFF_LIVE_ADDR_CHANGE;