Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 18 Jun 2018 17:40:48 +0200
Message-ID: <s5hy3fcw1a7.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     "Stefan Agner" <stefan@agner.ch>
Cc:     "Jaroslav Kysela" <perex@perex.cz>, <alsa-devel@alsa-project.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: ctxfi: use enum type CT_SUM_CTL where appropriate
In-Reply-To: <20180617134652.1638-1-stefan@agner.ch>
References: <20180617134652.1638-1-stefan@agner.ch>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, 17 Jun 2018 15:46:49 +0200,
Stefan Agner wrote:
> 
> Currently a variable of type enum CT_AMIXER_CTL is used for enum
> CT_SUM_CTL values. This leads to warnings when using clang:
> sound/pci/ctxfi/ctmixer.c:945:32: warning: implicit conversion from enumeration type
>       'enum CT_SUM_CTL' to different enumeration type 'enum CT_AMIXER_CTL'
>       [-Wenum-conversion]
>         for (i = AMIXER_MASTER_F, j = SUM_IN_F;
>                                     ~ ^~~~~~~~
> sound/pci/ctxfi/ctmixer.c:975:29: warning: implicit conversion from enumeration type
>       'enum CT_SUM_CTL' to different enumeration type 'enum CT_AMIXER_CTL'
>       [-Wenum-conversion]
>         for (i = AMIXER_PCM_F, j = SUM_IN_F; i <= AMIXER_PCM_S; i++, j++) {
>                                  ~ ^~~~~~~~
> 
> Introduce enum CT_SUM_CTL k and it instead.
> 
> Signed-off-by: Stefan Agner <stefan@agner.ch>

Applied, thanks.


Takashi