Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20180618144404.21055-1-mika.westerberg@linux.intel.com>
In-Reply-To: <20180618144404.21055-1-mika.westerberg@linux.intel.com>
From:   Yehezkel Bernat <yehezkelshb@gmail.com>
Date:   Mon, 18 Jun 2018 18:54:00 +0300
Message-ID: <CA+CmpXuACmU_S69tQmtC1CGbx-jn0g5NJF_p1dNTTaRMPCp+5g@mail.gmail.com>
Subject: Re: [PATCH] thunderbolt: Notify userspace when boot_acl is changed
To:     Mika Westerberg <mika.westerberg@linux.intel.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Andreas Noever <andreas.noever@gmail.com>,
        michael.jamet@intel.com, christian@kellner.me,
        Mario Limonciello <mario.limonciello@dell.com>, lukas@wunner.de
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jun 18, 2018 at 5:44 PM Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
>
> The commit 9aaa3b8b4c56 ("thunderbolt: Add support for preboot ACL")
> introduced boot_acl attribute but missed the fact that now userspace
> needs to poll the attribute constantly to find out whether it has
> changed or not. Fix this by sending notification to the userspace
> whenever the boot_acl attribute is changed.
>
> Fixes: 9aaa3b8b4c56 ("thunderbolt: Add support for preboot ACL")
> Reported-by: Christian Kellner <ckellner@redhat.com>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
>  drivers/thunderbolt/domain.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/thunderbolt/domain.c b/drivers/thunderbolt/domain.c
> index 6281266b8ec0..a923ebdeb73c 100644
> --- a/drivers/thunderbolt/domain.c
> +++ b/drivers/thunderbolt/domain.c
> @@ -213,6 +213,10 @@ static ssize_t boot_acl_store(struct device *dev, struct device_attribute *attr,
>                 goto err_free_acl;
>         }
>         ret = tb->cm_ops->set_boot_acl(tb, acl, tb->nboot_acl);
> +       if (!ret) {
> +               /* Notify userspace about the change */
> +               kobject_uevent(&tb->dev.kobj, KOBJ_CHANGE);
> +       }
>         mutex_unlock(&tb->lock);
>
>  err_free_acl:
> --
> 2.17.1
>

Acked-by: Yehezkel Bernat <yehezkelshb@gmail.com>