Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp4139797imm; Mon, 18 Jun 2018 09:46:43 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJKDHqEFrZRDLlj2RgclZN+EutTNAoHXDhcqT0SnikNfnCPzCBaf/bnQM+GZY2ukkyVDAK1 X-Received: by 2002:a62:4556:: with SMTP id s83-v6mr14381306pfa.73.1529340403929; Mon, 18 Jun 2018 09:46:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529340403; cv=none; d=google.com; s=arc-20160816; b=tlpLQ71q7DKFyTJykhFX5MJAEeUxWeyvshWm5aPUjv6HlFys7iOyhDBPTRJfdUogs4 oiEvU+cQrEwx6CCBHhg2+IAsnhWOYyzjaGFM+zHYgw96GUakRAZJgZoyZc9Xu9bV5Iru NZMkkz/mDd76KDD6wP3MJJeOgUxDc58MBKx5yidChLq73Hxb5Mry8J4t3oz/9iW9NPMU oJkEiGYI7nh12F/dvYUsMl4DTdiwvhLn3DonSCzRzvN+qT26JwDVIrK+QRB53HxkrQIl Wy7Wpi92HtilYjUmMueJWn3DHgBxTYegGXElQ8XlRozRrQjlq9fcP7HRU8GIjZ6Gous2 HNrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=+C7FXlcRCtjcV0OUeBDyj/Vdh6BpA/drbamlLdPkz6k=; b=AwfU2ANBDsBhHetSRke5LPvQeW8a9ytH5EA567Wq1CFwjBc890ZAzQ6mQan41CjUIv FTQJB0qbdF49b2d1UfFzrljpHPnAvIHvKqruKUX7+hGOve5pZqVg/w+5JtX3nz2v0D6W k/xYn93N5zBWLkDXykCjL00uR+C3OlQourzUMP7J9kRkPSFFhOhhzEvkX/mjUuPKVuq1 jZ1B4jiraDHgCqhB4xOnW/VzEuMG4rS+3nwkv7O57qe0BVVLAMk256xZ9AoDVB948fud MwjnnKPduY6Cuk/Sfsb7bETdKP4RTesoAsUqVqxMxvy/Jj3rPUgYq9zvi87bSvYQwBJb 0zRg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1-v6si14233185plu.282.2018.06.18.09.46.30; Mon, 18 Jun 2018 09:46:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934644AbeFRQoj (ORCPT + 99 others); Mon, 18 Jun 2018 12:44:39 -0400 Received: from mail.skyhub.de ([5.9.137.197]:35826 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754743AbeFRQoi (ORCPT ); Mon, 18 Jun 2018 12:44:38 -0400 X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de Received: from mail.skyhub.de ([127.0.0.1]) by localhost (blast.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id v1_tEBNumVyp; Mon, 18 Jun 2018 18:44:37 +0200 (CEST) Received: from zn.tnic (p200300EC2BE29C00329C23FFFEA6A903.dip0.t-ipconnect.de [IPv6:2003:ec:2be2:9c00:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 41FE71EC0136; Mon, 18 Jun 2018 18:44:37 +0200 (CEST) Date: Mon, 18 Jun 2018 18:44:34 +0200 From: Borislav Petkov To: "Maciej S. Szmigiero" Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 8/8] x86/microcode/AMD: Don't scan past the CPU equivalence table data Message-ID: <20180618164434.GC24921@zn.tnic> References: <04a252b1e06673b8a1f62196093d0573d302fc1b.1526767245.git.mail@maciej.szmigiero.name> <20180605085506.GB27701@nazgul.tnic> <957d6884-f24b-0d40-7584-d4386d05af21@maciej.szmigiero.name> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <957d6884-f24b-0d40-7584-d4386d05af21@maciej.szmigiero.name> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 12, 2018 at 11:08:31PM +0200, Maciej S. Szmigiero wrote: > That was the solution before this patch series version (6) - there was > a variable holding the CPU equivalence table size for the late loader, > but you didn't like it:> Instead of adding yet another global var which needs handling too, > > and touching so many places, just do all checks and preparations in > > install_equiv_cpu_table() so that the rest of the code can get what it > > expects: terminating zero entry and proper size. So what's wrong with computing the size in the late loader just like you do in parse_container()? -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.