Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp4226723imm; Mon, 18 Jun 2018 11:13:19 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJ13F23pBgQj+cJkzyfc1grza4lRtAVuShgytGuz5mvoJgqNU+ksGRXDlWXFtlVmE+WuOty X-Received: by 2002:a65:6591:: with SMTP id u17-v6mr11628972pgv.401.1529345598993; Mon, 18 Jun 2018 11:13:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529345598; cv=none; d=google.com; s=arc-20160816; b=kqWJQHCCw64NJODEkCW0SnhcDzAcUEc+sKfB0VfZ2PtSaju+JqAFRtEBcOBjj6679V GvPm6ZLce9Jmlnxbvu/hkn93gYgP8DASroJjGBcfPisknUdH8sHdb7buTQa1MWALkoDT TTXHGxnk1xyx2fKMetJDk/UaIEoBTaS6zzP4ENFh/7i8DQ+m5zn65fVwzzA57v+axUPm DTB2JsNS6HQMGHo3w5YzpjDZdeoeZolew/laTXXYju1yNgLGhLU5zWSRNReqpaeLL/5t UVuXVW/ARoQg5Delm4pqOEzjyrG7uVaYUS4auA6hzRADykHzm9maNALpdm+pnD8PRzK6 mxow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature:arc-authentication-results; bh=eph15OybexIE3hvuODyKCM6Qg3Hi4QuhYEDFTNZPxys=; b=V3IedaVEetGWULjHc1nx1VS0ag3ScPce8zXD97vsDUsi3PDKkXKa8ZPmDItCWxTMMC zAPYShCUGRZOTTC9VG0smjwNChiN0J4AHwubuJhcjibUEDSmf7AdZeg9a/Tv0bRwC6DI Are3+C9z0/LvV0MKj4HSxHPZX/RZJFaNZilYLLPALapIhH5L7XxOrvJuFviiK8UcKXz2 F9l97mjTT+ilExI88c8c+PF2RqIUwN+tgBVRCQf5RKmQn+CgiXdRiSYebGXXzFxLXJjB ApkeCK2TVv9O/hf4HNxlCEU+TYJfvFbkUlRF8gHruwXM2aQFUaluXESaJQ1lI95TA+wk E+XQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=XSSRWD+p; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f192-v6si15922465pfa.252.2018.06.18.11.13.04; Mon, 18 Jun 2018 11:13:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=XSSRWD+p; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935819AbeFRSL0 (ORCPT + 99 others); Mon, 18 Jun 2018 14:11:26 -0400 Received: from smtprelay6.synopsys.com ([198.182.37.59]:42849 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935533AbeFRSLY (ORCPT ); Mon, 18 Jun 2018 14:11:24 -0400 Received: from mailhost.synopsys.com (mailhost2.synopsys.com [10.13.184.66]) by smtprelay.synopsys.com (Postfix) with ESMTP id D8BE41E04FD for ; Mon, 18 Jun 2018 20:11:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1529345483; bh=KklUq1GJk9Bw5hmSaZKjX9Pu+3ekeecZANQ/EjIDMuI=; h=Subject:To:CC:References:From:Date:In-Reply-To:From; b=XSSRWD+pQq+EFQNleU7sxdp+cKmC54hPkDh+47mm8LBjARnjME3KUBMWduSje6pno qDmB2Q0UAFfnwwKcbX2aokI+vOdxVfp/+Vixjr8VOzO4qv9EeDI8LJs/NVLm4UEJ6s m2cnMkbWUqA9LKqS1jfWx7k+YQaDP+DXvOiZr3pXOPWn2ta2zGUJww/3RsioJXCb+m 8TaXSoyjEeELmvvlCwE/MYybym9GA8Db3sWPlSOuZca+TfHHnvAK+jhFmlaS1yAunU dv8nHG6cPXsdGzlAC3hDi5+zbQWkGeskU8z9VXBsIMG3POeNr70c69buWYnEbkcx1t IT+hpso2WiNng== Received: from us01wehtc1.internal.synopsys.com (us01wehtc1.internal.synopsys.com [10.12.239.235]) by mailhost.synopsys.com (Postfix) with ESMTP id 3EA7C3FFE; Mon, 18 Jun 2018 11:11:22 -0700 (PDT) Received: from IN01WEHTCB.internal.synopsys.com (10.144.199.106) by us01wehtc1.internal.synopsys.com (10.12.239.231) with Microsoft SMTP Server (TLS) id 14.3.361.1; Mon, 18 Jun 2018 11:11:01 -0700 Received: from IN01WEHTCA.internal.synopsys.com (10.144.199.103) by IN01WEHTCB.internal.synopsys.com (10.144.199.105) with Microsoft SMTP Server (TLS) id 14.3.361.1; Mon, 18 Jun 2018 23:40:59 +0530 Received: from [10.10.161.98] (10.10.161.98) by IN01WEHTCA.internal.synopsys.com (10.144.199.243) with Microsoft SMTP Server (TLS) id 14.3.361.1; Mon, 18 Jun 2018 23:40:58 +0530 Subject: Re: [PATCH] ARC: Add PCIe support for ARC HSDK platform To: Alexey Brodkin , "gustavo.pimentel@synopsys.com" CC: "robh@kernel.org" , "linux-kernel@vger.kernel.org" , "Eugeniy.Paltsev@synopsys.com" , "sboyd@codeaurora.org" , "linux-snps-arc@lists.infradead.org" References: <3e9a2f384fd831fb2639ad99ec43ce0f019ac17c.1529333762.git.gustavo.pimentel@synopsys.com> From: Vineet Gupta Openpgp: preference=signencrypt Autocrypt: addr=vgupta@synopsys.com; keydata= xsFNBFEffBMBEADIXSn0fEQcM8GPYFZyvBrY8456hGplRnLLFimPi/BBGFA24IR+B/Vh/EFk B5LAyKuPEEbR3WSVB1x7TovwEErPWKmhHFbyugdCKDv7qWVj7pOB+vqycTG3i16eixB69row lDkZ2RQyy1i/wOtHt8Kr69V9aMOIVIlBNjx5vNOjxfOLux3C0SRl1veA8sdkoSACY3McOqJ8 zR8q1mZDRHCfz+aNxgmVIVFN2JY29zBNOeCzNL1b6ndjU73whH/1hd9YMx2Sp149T8MBpkuQ cFYUPYm8Mn0dQ5PHAide+D3iKCHMupX0ux1Y6g7Ym9jhVtxq3OdUI5I5vsED7NgV9c8++baM 7j7ext5v0l8UeulHfj4LglTaJIvwbUrCGgtyS9haKlUHbmey/af1j0sTrGxZs1ky1cTX7yeF nSYs12GRiVZkh/Pf3nRLkjV+kH++ZtR1GZLqwamiYZhAHjo1Vzyl50JT9EuX07/XTyq/Bx6E dcJWr79ZphJ+mR2HrMdvZo3VSpXEgjROpYlD4GKUApFxW6RrZkvMzuR2bqi48FThXKhFXJBd JiTfiO8tpXaHg/yh/V9vNQqdu7KmZIuZ0EdeZHoXe+8lxoNyQPcPSj7LcmE6gONJR8ZqAzyk F5voeRIy005ZmJJ3VOH3Gw6Gz49LVy7Kz72yo1IPHZJNpSV5xwARAQABzS1WaW5lZXQgR3Vw dGEgKHBlcnNvbmFsKSA8dmluZWV0Zzc2QGdtYWlsLmNvbT7CwX4EEwECACgCGwMGCwkIBwMC BhUIAgkKCwQWAgMBAh4BAheABQJbBYpwBQkLx0HcAAoJEGnX8d3iisJe9TAP/3ljkSlRwToH O0E9QimJJqF52uZ0phSg1ZoavgHhGtz1mRykgeOzOITpFmYGBnf3v2Z33fDltIxTaN5TkRwl DjYvz1NTBlTLyPRbYwdCn6YyVSWj75hiGwdD0/N5M7Rb3XYsyDHvZ/tns1oGwipPmu9G+JoB VOkZw/bviE8AmGEK54PWdU1t3AnJ/3wtT6FSIPlTtCREiuZdQItjFkH0sYL1/BOXcE+XoBoQ 9hx6IEb46pop9ix/IRov2y6ZBUtDbF+SOSvImRadvD8A1ttvH51naP21Bra3ypV/GmZOR1/U 8azvgKmimYvC0345za/dS8eqrDuSh2IbEkDR0juQsFbkWS4IY5uqckzRWxHVZBas9CjpjipO C4iTzxq3CgmCyAD5qlQndJdhbsTgN18PXVAAI/phC1BtjNOoCgWgNsr8JK2TbXNF9wSR17T7 jDWCZ+Up8k5CTVQywLwJl91u5dV82WAnHnv3U1dwUX46DFMenV16ADfRrm7ib+D/O0XZMP7B sGC7PPleU+Ej/rt6V4H6VZ5RC9CXVCdUjM+ZZsqJc6/f5od4gSyswWQzCb/izU5ebxrehTUJ lPh2QCa6e46G1WzLWwZCFmQU3uUQtCXU1BBId/nL+Y3hQW0XKapvTx+zr8cZAZDXb83YE8Qs inBoGE5y9nj+ZveaVZHZRy63zsFNBFEffBMBEADXZ2pWw4Regpfw+V+Vr6tvZFRl245PV9rW FU72xNuvZKq/WE3xMu+ZE7l2JKpSjrEoeOHejtT0cILeQ/Yhf2t2xAlrBLlGOMmMYKK/K0Dc 2zf0MiPRbW/NCivMbGRZdhAAMx1bpVhInKjU/6/4mT7gcE57Ep0tl3HBfpxCK8RRlZc3v8BH OaEfcWSQD7QNTZK/kYJo+Oyux+fzyM5TTuKAaVE63NHCgWtFglH2vt2IyJ1XoPkAMueLXay6 enSKNci7qAG2UwicyVDCK9AtEub+ps8NakkeqdSkDRp5tQldJbfDaMXuWxJuPjfSojHIAbFq P6QaANXvTCSuBgkmGZ58skeNopasrJA4z7OsKRUBvAnharU82HGemtIa4Z83zotOGNdaBBOH NN2MHyfGLm+kEoccQheH+my8GtbH1a8eRBtxlk4c02ONkq1Vg1EbIzvgi4a56SrENFx4+4sZ cm8oItShAoKGIE/UCkj/jPlWqOcM/QIqJ2bR8hjBny83ONRf2O9nJuEYw9vZAPFViPwWG8tZ 7J+ReuXKai4DDr+8oFOi/40mIDe/Bat3ftyd+94Z1RxDCngd3Q85bw13t2ttNLw5eHufLIpo EyAhTCLNQ58eT91YGVGvFs39IuH0b8ovVvdkKGInCT59Vr0MtfgcsqpDxWQXJXYZYTFHd3/R swARAQABwsFlBBgBAgAPAhsMBQJbBYpwBQkLx0HdAAoJEGnX8d3iisJewe8P/36pkZrVTfO+ U+Gl1OQh4m6weozuI8Y98/DHLMxEujKAmRzy+zMHYlIl3WgSih1UMOZ7U84yVZQwXQkLItcw XoihChKD5D2BKnZYEOLM+7f9DuJuWhXpee80aNPzEaubBYQ7dYt8rcmB7SdRz/yZq3lALOrF /zb6SRleBh0DiBLP/jKUV74UAYV3OYEDHN9blvhWUEFFE0Z+j96M4/kuRdxvbDmp04Nfx79A mJEnfv1Vvc9CFiWVbBrNPKomIN+JV7a7m2lhbfhlLpUk0zGFDTWcWejl4qz/pCYSoIUU4r/V BsCVZrOun4vd4cSi/yYJRY4kaAJGCL5k7qhflL2tgldUs+wERH8ZCzimWVDBzHTBojz0Ff3w 2+gY6FUbAJBrBZANkymPpdAB/lTsl8D2ZRWyy90f4VVc8LB/QIWY/GiS2towRXQBjHOfkUB1 JiEXYH/i93k71mCaKfzKGXTVxObU2I441w7r4vtNlu0sADRHCMUqHmkpkjV1YbnYPvBPFrDB S1V9OfD9SutXeDjJYe3N+WaLRp3T3x7fYVnkfjQIjDSOdyPWlTzqQv0I3YlUk7KjFrh1rxtr poYSIQKf5HuMowUNtjyiK2VhA5V2XDqd+ZUT3RqfAPf3Y5HjkhKJRqoIDggUKMUKmXaxCkPG i91ThhqBJlyU6MVUa6vZNv8E Message-ID: <562939df-4c97-c19b-72e3-14196a651c40@synopsys.com> Date: Mon, 18 Jun 2018 11:10:51 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.10.161.98] Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/18/2018 08:20 AM, Alexey Brodkin wrote: >> +static void __init hsdk_enable_gpio_intc_wire(void) >> +{ >> + u32 val = GPIO_HAPS_INT; >> + >> + iowrite32(0xffffffff, (void __iomem *) GPIO_INTMASK); >> + iowrite32(~val, (void __iomem *) GPIO_INTMASK); >> + iowrite32(0x00000000, (void __iomem *) GPIO_INTTYPE_LEVEL); >> + iowrite32(0xffffffff, (void __iomem *) GPIO_INT_POLARITY); >> + iowrite32(val, (void __iomem *) GPIO_INTEN); >> +} > I would suggest to have a map of really used lines and enable all of them > instead of adding one-by-one occasionally. More importantly, adding any code in this file is an absolute abomination and only desired if this is a platform specific hack which can't be added in the generic driver and/or specified via the Device Tree. Here it seems like we are enabling some gpio lines which likely could be done via the gpio driver paths ? -Vineet