Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] x86/CPU/AMD: Fix LLC ID bit-shift calculation
To:     Borislav Petkov <bp@alien8.de>
Cc:     x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de,
        mingo@redhat.com
References: <1528915390-30533-1-git-send-email-suravee.suthikulpanit@amd.com>
 <20180618172048.GD24921@zn.tnic>
From:   "Suthikulpanit, Suravee" <suravee.suthikulpanit@amd.com>
Message-ID: <8552af6b-c6c6-82d7-9df9-8b928ff3f1d9@amd.com>
Date:   Mon, 18 Jun 2018 13:14:11 -0500
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <20180618172048.GD24921@zn.tnic>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Received-SPF: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jun 2018 18:14:15.8571 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 9c0b0eb5-c854-406c-9d4c-08d5d5474da4
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR12MB0131
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Boris,

On 6/18/2018 12:20 PM, Borislav Petkov wrote:
> On Wed, Jun 13, 2018 at 01:43:10PM -0500, Suravee Suthikulpanit wrote:
>> The current logic incorrectly calculates the LLC ID from the APIC ID.
>> Unless specified otherwise, the LLC ID should be calculated from
>> the count order of the number of threads sharing cache.
> 
> Don't you mean:
> 
> "... should be calculated by removing the Core and Thread ID bits"?
> 
> here?
> 
> I'm looking at
> 
> "2.1.10.2.1.3 ApicId Enumeration Requirements
> 
> ...
> 
> Each Core::X86::Apic::ApicId[ApicId] register is preset as follows:
> • ApicId[6] = Socket ID.
> • ApicId[5:4] = Node ID.
> • ApicId[3] = Logical CCX L3 complex ID
> • ApicId[2:0]= (SMT) ? {LogicalCoreID[1:0],ThreadId} : {1'b0,LogicalCoreID[1:0]}.
> 
> and in order to get a unique LLC ID, you simply need to shift out the
> CoreID and the ThreadId, right?
> 
> Or am I misreading it?
> 

This enumeration is only for the family17h model 00-1Fh of hardware 
revision. The patch is intended for the future revision of hardware.

Thanks,
Suravee