Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp4268001imm; Mon, 18 Jun 2018 11:57:36 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIDT0iCOLr3JC6/nE816AlHs5D/LdSGGuc6J2gIVXpvz/rOqI2lqUAqwE26V9ed80tnhZ5m X-Received: by 2002:a17:902:7685:: with SMTP id m5-v6mr15448699pll.76.1529348256643; Mon, 18 Jun 2018 11:57:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529348256; cv=none; d=google.com; s=arc-20160816; b=FEy2/A6rpIQychPQY/UI9mkLJrhsZlaeMiyjaLGegAxAkaYFLm8iQASVrrqJOSwpOA n8jzmxp6LXhUItAaqwGmIWtAT4WAdsrj+LhBjfFJ0PiKqlxBF56p3ATUMSqqPBMNtQi2 Lid6ioc0EuKx/ZCvtfbBgLmDPAYcdZN4BAKZmeFa2j+P/f6oj1d7dUyv/wqiJ7L7UUxv crz87gwzz6xGySRwbRXXyG+CkZ45ZoBPh1yrU+t2vdPw9iesSPQE0uIho7HkCuzw7b6+ R8RYgVxsQFguiCsBSCGQFb9lby2zfE+xMdPvZq62xGrc4/K9uAqozW7go2kbS5GVlfGk Sq9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=qP9pNgPNWy/qBzONcUv0J0u5fzqdP6wVDjMzDvHyYMA=; b=qUa60QfZixfX4omq++GbsSVSmxlJU9paETy2v6g5s3om61MSLyQ5yC3JJPIVP2X5f5 a5B9gK1A5JB2hdYlCnzRaflkKFxqqtL1bI5VVgszYm1mw+x5iutczNU+q840y/l/G1b8 EDeOtsvrI094j3LlwuNAeRzMu24wU5xu9NZwMlHwgmwvwMUWpDU6/8sxRiVP481GNQlY sL49Sez2A1O8J9b3UrOOAphJiPVlEd8A3y44GkejwsFEQ35+mM689ZvhRe+sSAKt/XM4 AWk33J5E4bKiLZhWaOEvm3/rPqosrM9IbeOCtSk80b6qv1YdK7btlqsS7pylXaWzlgSy OPDg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f13-v6si12366003pgo.265.2018.06.18.11.57.22; Mon, 18 Jun 2018 11:57:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935932AbeFRS4l (ORCPT + 99 others); Mon, 18 Jun 2018 14:56:41 -0400 Received: from www.osadl.org ([62.245.132.105]:48894 "EHLO www.osadl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935752AbeFRS4k (ORCPT ); Mon, 18 Jun 2018 14:56:40 -0400 Received: from debian01.hofrr.at (178.115.242.59.static.drei.at [178.115.242.59] (may be forged)) by www.osadl.org (8.13.8/8.13.8/OSADL-2007092901) with ESMTP id w5IIrtX6023371; Mon, 18 Jun 2018 20:53:56 +0200 From: Nicholas Mc Guire To: Greg Kroah-Hartman Cc: Geert Uytterhoeven , Nathan Chancellor , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Nicholas Mc Guire Subject: [PATCH] staging: board: drop refcount in success case Date: Mon, 18 Jun 2018 20:53:19 +0200 Message-Id: <1529347999-9316-1-git-send-email-hofrat@osadl.org> X-Mailer: git-send-email 2.1.4 X-Spam-Status: No, score=-1.9 required=6.0 tests=BAYES_00 autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on www.osadl.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The call to of_find_compatible_node() returns irqc_node with refcount incremented thus it must be explicitly decremented here after it was checked for non-NULL. Signed-off-by: Nicholas Mc Guire Fixes: commit 72ee8626eeb1 ("staging: board: Add support for translating hwirq to virq numbers") --- Problem located with an experimental coccinelle script Patch was compile-tested with: x86_64_defconfig + STAGING=y, STAGING_BOARD=y Patch is against 4.18-rc1 (localversion-next is next-20180618) drivers/staging/board/board.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/board/board.c b/drivers/staging/board/board.c index cb6feb3..8ee48e5 100644 --- a/drivers/staging/board/board.c +++ b/drivers/staging/board/board.c @@ -64,12 +64,13 @@ int __init board_staging_gic_setup_xlate(const char *gic_match, irqc_node = of_find_compatible_node(NULL, NULL, gic_match); WARN_ON(!irqc_node); if (!irqc_node) return -ENOENT; + of_node_put(irqc_node); irqc_base = base; return 0; } static void __init gic_fixup_resource(struct resource *res) { -- 2.1.4