Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1461620099-11933-1-git-send-email-toshi.kani@hpe.com> <1461620099-11933-2-git-send-email-toshi.kani@hpe.com>
In-Reply-To: <1461620099-11933-2-git-send-email-toshi.kani@hpe.com>
From:   Dan Williams <dan.j.williams@intel.com>
Date:   Mon, 18 Jun 2018 12:01:37 -0700
Message-ID: <CAA9_cmenbY9GStibRjO0BfTq0kzzzqThiLeOygJsT9L03BFsBQ@mail.gmail.com>
Subject: Re: [PATCH v3 1/2] acpi/nfit: Update nfit driver to comply with ACPI 6.1
To:     Toshi Kani <toshi.kani@hpe.com>
Cc:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Bob Moore <robert.moore@intel.com>,
        Linux ACPI <linux-acpi@vger.kernel.org>,
        "Elliott, Robert (Persistent Memory)" <elliott@hpe.com>,
        juston.li@intel.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Apr 25, 2016 at 2:43 PM Toshi Kani <toshi.kani@hpe.com> wrote:
>
> ACPI 6.1, Table 5-133, updates NVDIMM Control Region Structure
> as follows.
>  - Valid Fields, Manufacturing Location, and Manufacturing Date
>    are added from reserved range.  No change in the structure size.
>  - IDs (SPD values) are stored as arrays of bytes (i.e. big-endian
>    format).  The spec clarifies that they need to be represented
>    as arrays of bytes as well.
>

Circling back on this a couple years too late... where are you reading
this "arrays of bytes" note. As far as I can see this is wrong. JEDEC
says that vendor id is stored LSB of the id is stored at the lowest
byte in SPD, which is little endian. So it seems Linux has showing the
incorrect value for a long time now.