Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org CFFC860227
Date:   Mon, 18 Jun 2018 13:06:37 -0600
From:   Lina Iyer <ilina@codeaurora.org>
To:     Doug Anderson <dianders@chromium.org>
Cc:     Raju P L S S S N <rplsssn@codeaurora.org>,
        Andy Gross <andy.gross@linaro.org>,
        David Brown <david.brown@linaro.org>,
        linux-arm-msm@vger.kernel.org,
        "open list:ARM/QUALCOMM SUPPORT" <linux-soc@vger.kernel.org>,
        Rajendra Nayak <rnayak@codeaurora.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Stephen Boyd <sboyd@kernel.org>,
        Evan Green <evgreen@chromium.org>,
        Matthias Kaehlcke <mka@chromium.org>
Subject: Re: [PATCH v11 04/10] drivers: qcom: rpmh: add RPMH helper functions
Message-ID: <20180618190637.GG21724@codeaurora.org>
References: <1529329040-2606-1-git-send-email-rplsssn@codeaurora.org>
 <1529329040-2606-5-git-send-email-rplsssn@codeaurora.org>
 <20180618163945.GE21724@codeaurora.org>
 <CAD=FV=W_tKb2n2x9AY4T_17Q_KJcu9wsfFv4vio08W76t0d00A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <CAD=FV=W_tKb2n2x9AY4T_17Q_KJcu9wsfFv4vio08W76t0d00A@mail.gmail.com>
User-Agent: Mutt/1.10.0 (2018-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jun 18 2018 at 12:33 -0600, Doug Anderson wrote:
>Lina,
>
>On Mon, Jun 18, 2018 at 9:39 AM, Lina Iyer <ilina@codeaurora.org> wrote:
>>> +/**
>>>  * struct rsc_drv: the Direct Resource Voter (DRV) of the
>>>  * Resource State Coordinator controller (RSC)
>>>  *
>>> @@ -52,6 +78,7 @@ struct tcs_group {
>>>  * @tcs:        TCS groups
>>>  * @tcs_in_use: s/w state of the TCS
>>>  * @lock:       synchronize state of the controller
>>> + * @ctrl:       controller to handle cases like batch requests
>>
>> This is not only for batch requests.
>> This is handle to the DRV's client. @client might be a better name than
>> @ctrlr.
>
>The name "ctrlr" also matches the name of the structure.  Are you
>suggesting also renaming "struct rpmh_ctrlr" to "struct rpmh_client",
>or you think they should be different names?
>
Just the name of the variable. I was just a nice to have. I wouldn't
block for this though.

I also got a couple Bot reported issues on this and the previous
revision that I have sent to Raju. He is planning to the post the v12
tomorrow his time after fixing them. If you can wait until then, I would
recommend picking up the v12 instead of this.

Thanks,
Lina

>I'm advocating that we should land this patch series to unblock
>everything.  Hopefully you agree that's OK and if we want to change
>the name of this we can do it in a future patch.  Let me know if you
>disagree.  ...if others agree that the series should land and you
>really want the name change, I'm happy to post up a version of the
>series with the fix to help move things along...
>
>
>-Doug