Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20180618225540.GD14131@decadent.org.uk>
In-Reply-To: <20180618225540.GD14131@decadent.org.uk>
From:   Julius Werner <jwerner@chromium.org>
Date:   Mon, 18 Jun 2018 16:13:39 -0700
Message-ID: <CAODwPW92-7NBjpyxq1v-8v7H=JFDvrrh=i_bW+BfMjsfgm-ErQ@mail.gmail.com>
Subject: Re: [PATCH v2] firmware: Update Kconfig help text for Google firmware
To:     ben@decadent.org.uk
Cc:     Julius Werner <jwerner@chromium.org>,
        Thierry Escande <thierry.escande@collabora.com>,
        LKML <linux-kernel@vger.kernel.org>, pm.debian@googlemail.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

LGTM

Reviewed-by: Julius Werner <jwerner@chromium.org>
On Mon, Jun 18, 2018 at 3:55 PM Ben Hutchings <ben@decadent.org.uk> wrote:
>
> The help text for GOOGLE_FIRMWARE states that it should only be
> enabled when building a kernel for Google's own servers.  However,
> many of the drivers dependent on it are also useful on Chromebooks or
> on any platform using coreboot.
>
> Update the help text to reflect this double duty.
>
> Fixes: d384d6f43d1e ("firmware: google memconsole: Add coreboot support")
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---
> v2: Mention coreboot, and don't touch GSMI help text
>
>  drivers/firmware/google/Kconfig | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/firmware/google/Kconfig b/drivers/firmware/google/Kconfig
> index f16b381a569c..ca049ecf5cfd 100644
> --- a/drivers/firmware/google/Kconfig
> +++ b/drivers/firmware/google/Kconfig
> @@ -2,9 +2,9 @@ menuconfig GOOGLE_FIRMWARE
>         bool "Google Firmware Drivers"
>         default n
>         help
> -         These firmware drivers are used by Google's servers.  They are
> -         only useful if you are working directly on one of their
> -         proprietary servers.  If in doubt, say "N".
> +         These firmware drivers are used by Google servers,
> +         Chromebooks and other devices using coreboot firmware.
> +         If in doubt, say "N".
>
>  if GOOGLE_FIRMWARE
>