Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp4624766imm; Mon, 18 Jun 2018 19:21:45 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKdqlIKwRkNpiG2vnFO2ZJZYhkpRQBZdloYaKGbRTgjicaNtia5lW3G//b/MVVVIJ3FxJae X-Received: by 2002:a62:d712:: with SMTP id b18-v6mr16091532pfh.70.1529374905251; Mon, 18 Jun 2018 19:21:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529374905; cv=none; d=google.com; s=arc-20160816; b=SSmbQ11uA7XGzp9aXtxm6I80xs+QIchASc0f2Z+h8ZLetN6OCOap4j3s/xTXg9MWh2 jGICtBvL1FbG7e8PLmGVgKUa26zB57VGdkrq3u7lrHK3vd8qb1d/F3/D+eKs8tcpmTjw OJstbB+Uk3i5lfMxug6BR26RlIx+JLnukAWATf4CyUiHvR6VEeDrNdDv1RVWgeNNzKKJ /MOvOpwhEkH2t5scK1PFKK0XibAuUfM/vimEFSahL++oGNkgVaZ0gkx7nf7hmxGcMMWD 7W4Cu4ZzGDwGMVhSkkEtS+ehZU3asLH9qEPKQofcWAKuvLh8lIK1UUM66qK4JPyGDv7h QeQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature:arc-authentication-results; bh=h717UtL0VBb4uoOdGtl34osENkyt+C2RJJr0YIOP6iw=; b=oZIck7GARdK19J0TI+qst6Ytwq12v7nAR46W1lxRadqbKrIkgrbwz00nx1g5IRk/vg S7nxe9k12gPCrVZvF/ZSUsEJmlP/XCR1rTbKrcejW5/VRt4CJoLz0R6b1Cf8FBrh1kqe Y463Zqbcr9Mr8Wo2q/Ybg2vjE4pI7RdFjVXuaOqu1xPn8T6IgZWZ+geNyVeeE3DbOGMy 5tlPV/RtqFqLQsAGpv8vQaYv5kx32m/mFRYffQw92YuuPdVCGWrWdyXgeD8T2arzF3GM lXHBVRSNPf8jLGboiWt4pdewSOYy24BoKCsW7pPM1oqJihiAlTrLYC+q0AVlTOfvKbU0 N0Dg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=XKsB8Rlx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b9-v6si13060564pgs.139.2018.06.18.19.21.30; Mon, 18 Jun 2018 19:21:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=XKsB8Rlx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937198AbeFSCUu (ORCPT + 99 others); Mon, 18 Jun 2018 22:20:50 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:36434 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S937110AbeFSCUs (ORCPT ); Mon, 18 Jun 2018 22:20:48 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w5J2JB9n046335; Tue, 19 Jun 2018 02:20:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2017-10-26; bh=h717UtL0VBb4uoOdGtl34osENkyt+C2RJJr0YIOP6iw=; b=XKsB8Rlx7z89BdpFjzSFJlVtKe1stU8K7rLJF90FVuC76fz4YqI4p/QN8cX3VjVQTLda F+FMCDAze9Zk0YYZXwz4vbeu35YTGiOdi8OpsWH/2CYgaPjFmTXJIYF8/8EVbtcZwGtg ZiPWAnmI/C42yAmcq2vCNsl6NwN+Y6EXAykmvBbpnPHYuNLsDbv5JL/sPiNm4IXGhJ3D kXcHTzPIXulypRTOYOp2z+9PvCTufxumjoZzeJVMvgfZYdDxO4E7UTtGWsQ+rQ5faLgk uNm8l+homhCVwRmxNIzkXvuxwBC+Nr5MtKtPaCNY5B4A8pS+oK1YhYH+1uAFWiQbtkxl bw== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2120.oracle.com with ESMTP id 2jmu6xp7eb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Jun 2018 02:20:39 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w5J2KclQ001148 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Jun 2018 02:20:38 GMT Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w5J2KaZU011256; Tue, 19 Jun 2018 02:20:36 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 18 Jun 2018 19:20:35 -0700 To: Tomas Winkler Cc: "James E . J . Bottomley" , "Martin K . Petersen" , Vinayak Holikatti , Adrian Hunter , Christoph Hellwig , Vivek Gautam , Subhash Jadavani , Alex Lemberg , Avri Altman , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH resend] scsi: ufs: ufshcd_dump_regs to use memcpy_fromio From: "Martin K. Petersen" Organization: Oracle Corporation References: <20180614081409.29780-1-tomas.winkler@intel.com> Date: Mon, 18 Jun 2018 22:20:33 -0400 In-Reply-To: <20180614081409.29780-1-tomas.winkler@intel.com> (Tomas Winkler's message of "Thu, 14 Jun 2018 11:14:09 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8928 signatures=668702 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=327 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1805220000 definitions=main-1806190025 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tomas, > ufshcd_dump_regs should use memcpy_fromio to read host registers > instead of directly accessing using memcpy. The same function is > utilized in ufs-qcom. Applied to 4.19/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering