Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180618174203.4a1b4cf0@gandalf.local.home>
References: <1529297889-24551-1-git-send-email-byungchul.park@lge.com>
 <1529297889-24551-3-git-send-email-byungchul.park@lge.com> <20180618174203.4a1b4cf0@gandalf.local.home>
From:   Byungchul Park <max.byungchul.park@gmail.com>
Date:   Tue, 19 Jun 2018 14:16:36 +0900
Message-ID: <CANrsvROOfkPw265ObAPJ_H2epP2SJJsV64xcAGvOCbqHgwny1w@mail.gmail.com>
Subject: Re: [RESEND PATCH v12 2/2] sched/rt: Add support for
 SD_PREFER_SIBLING on find_lowest_rq()
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Byungchul Park <byungchul.park@lge.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Dario Faggioli <raistlin@linux.it>,
        linux-kernel@vger.kernel.org, Juri Lelli <juri.lelli@gmail.com>,
        bristot@redhat.com, kernel-team@lge.com,
        Joel Fernandes <joel@joelfernandes.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jun 19, 2018 at 6:42 AM, Steven Rostedt <rostedt@goodmis.org> wrote:
> On Mon, 18 Jun 2018 13:58:09 +0900
> Byungchul Park <byungchul.park@lge.com> wrote:
>
>> Hello Steven,
>>
>> I've changed the code a little bit to avoid a compile warning caused by
>> 'const' args of find_cpu(). Can I keep your Reviewed-by?
>>
>> BEFORE:
>> static int find_cpu(const struct cpumask *mask,
>>                   const struct sched_domain *sd,
>>                   const struct sched_domain *prefer)
>>
>> AFTER:
>> static int find_cpu(const struct cpumask *mask,
>>                   struct sched_domain *sd,
>>                   struct sched_domain *prefer)
>>
>> (I temporarily removed the Reviewed-by you gave me.)
>> Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
>
> I would fix sched_domain_span() to take a constant and keep the
> previous patch.

Right. I also considered it like you and asked it here:

   https://lkml.org/lkml/2018/1/11/106

But I didn't get any answer so tried to keep sched_domain_span()
unchanged conservatively.

Peterz, what's your opinion?

>
> -- Steve

-- 
Thanks,
Byungchul