Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp4746014imm; Mon, 18 Jun 2018 22:18:17 -0700 (PDT) X-Google-Smtp-Source: ADUXVKL45zuZL8BwvmanFerrwwp4xCwlNJbMD65+neYhbHnXMUFFUWXtErRsPA0YxMwIuiYs54MN X-Received: by 2002:a63:2dc2:: with SMTP id t185-v6mr13785156pgt.204.1529385497281; Mon, 18 Jun 2018 22:18:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529385497; cv=none; d=google.com; s=arc-20160816; b=w8lt42/VSPOC24z/CbAUxY8dqVrgPqmv62K2oSCmHuSNsEFEBcFBIvBbFV32AmLW/S PZ6zVbetSsspum7uZbnwzfiFSTQLWxy52MDqJnUG/wJBd44xUxIOT1qPeTwE2+9Abi8L arKvP27UxEml/P7yxugDUYcXEf+lkg483C9U90wJVbg2uffopjr2Mr8P32m5G4v6D7FA cWEwq1M1E6YHUa/Plmfv8AaSoj3h8X3VUTJUgwk/tzlq+lnCdxYN/joSxS9tX5j1UqvS 3lR6NyEQclfG9g8lLu0rNYbi06ic0M8xCDlNM6g1NogAzEMSU8qbO4NbVZchlL8WznWa wWfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=qOMOKnra0qcIKpa0rykziN8tqL9QbaMubxcc/OuzRcA=; b=UuhRs2Cc82gP0GZF7xqPdGjbs08ajc4mDTSiHFF4bl+hmMxoTnbQeY96y84L6xv6YI HFNeguQ/HWz8Nnh44Qwt2eE0DuUxj1PIZEYdlm1EKWeMEaa3kpaWEOwuQirtO2kvVljr BfNSFnKMWnenKl7YGATw27ZrklaaS+fsZFo92J+ZPEH04Vu99g1CkPEzODninN+yRaiK MdKX+SandDRIY8+s5mO7aux2y1zQdXuSE7gTruXujVYUi9r3BbT0cKZFYuaKHxXrEtxu L9PXIZjO/cdFsh8K+vDQT/Tn0jeBOOsZhyZPyIx91mSbu6ZfuL3sI+QN+8aaXxBDFgsB 43bA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=FlTcav8W; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g9-v6si5782091pgs.385.2018.06.18.22.18.02; Mon, 18 Jun 2018 22:18:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=FlTcav8W; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752468AbeFSFQk (ORCPT + 99 others); Tue, 19 Jun 2018 01:16:40 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:35819 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751777AbeFSFQi (ORCPT ); Tue, 19 Jun 2018 01:16:38 -0400 Received: by mail-lf0-f68.google.com with SMTP id i15-v6so28099860lfc.2 for ; Mon, 18 Jun 2018 22:16:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=qOMOKnra0qcIKpa0rykziN8tqL9QbaMubxcc/OuzRcA=; b=FlTcav8WfXFIpPfJ4xeGKfrA/hXcl48EBWC/NNeI+antUhcrSAzqMmsno+oZFZ4G3W CeBWkaxLnlyOXE7BxqIfWhSGwB6YbvX40NlrCWG2VkBMSa1PmGe36LWFFQAfIUYjIAnV zxPh6ikMFLr0iTIdUIr1pG4pXBYZKk3s3XjmAuQKbqHuBpHn7692o5xjWJgo2QpbBNo4 sfhB/pJHLeaiC5eTyxyqaWKxRpDuHhXanoO4mIR5sHYcQAR2rttfide0rPmz4yFFyol3 L95aC5ME32giMMIn2HwXBbCoM2DvJjXRzCSfDUXuBqSD+61aZafx9zOlLxJ2mwuNFDOZ zxeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=qOMOKnra0qcIKpa0rykziN8tqL9QbaMubxcc/OuzRcA=; b=iK6V9dz3NEZjFemFpytZKEVkZJyNt4pPzugsBp0o8ebizfLMElqWtf8CI+dRVW+U2n NO9mqPZ+Y7EZYEUv1hFIsVL+71seIgWCGuzOCEqjhsig/pUfU84vWS+SEnD5PPsSDtCs QJ6zWjMBS5XLsQuJpPokuIPOL8siEqEzreliGY9H5/YnIOpfoLbbIrCne1h+RcuRlNSX fLnzJHD3fXV6urBNiEYqe9hz42KXCqUb0ocWG+fTRR3GsGnpy3hAjF4G3O82l7JMXeOz Eo37xtDLf9ki+6WEdZPYnP0uMHLCVRqZizuALKRc3fKdvBAaid6jSGJ8x0AcPkYGLPuj wLqA== X-Gm-Message-State: APt69E0aDnWqkidxSHNW74n3eMUr+Ye0fH5D8QMTE94A6hstpmsUimmN jw30mCphZGSK1723VXWYgsiA1oUO5zDbarHRbTQ= X-Received: by 2002:a19:7707:: with SMTP id s7-v6mr2862386lfc.8.1529385396641; Mon, 18 Jun 2018 22:16:36 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:ab3:44ec:0:0:0:0:0 with HTTP; Mon, 18 Jun 2018 22:16:36 -0700 (PDT) In-Reply-To: <20180618174203.4a1b4cf0@gandalf.local.home> References: <1529297889-24551-1-git-send-email-byungchul.park@lge.com> <1529297889-24551-3-git-send-email-byungchul.park@lge.com> <20180618174203.4a1b4cf0@gandalf.local.home> From: Byungchul Park Date: Tue, 19 Jun 2018 14:16:36 +0900 Message-ID: Subject: Re: [RESEND PATCH v12 2/2] sched/rt: Add support for SD_PREFER_SIBLING on find_lowest_rq() To: Steven Rostedt Cc: Byungchul Park , Peter Zijlstra , Ingo Molnar , Thomas Gleixner , Dario Faggioli , linux-kernel@vger.kernel.org, Juri Lelli , bristot@redhat.com, kernel-team@lge.com, Joel Fernandes Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 19, 2018 at 6:42 AM, Steven Rostedt wrote: > On Mon, 18 Jun 2018 13:58:09 +0900 > Byungchul Park wrote: > >> Hello Steven, >> >> I've changed the code a little bit to avoid a compile warning caused by >> 'const' args of find_cpu(). Can I keep your Reviewed-by? >> >> BEFORE: >> static int find_cpu(const struct cpumask *mask, >> const struct sched_domain *sd, >> const struct sched_domain *prefer) >> >> AFTER: >> static int find_cpu(const struct cpumask *mask, >> struct sched_domain *sd, >> struct sched_domain *prefer) >> >> (I temporarily removed the Reviewed-by you gave me.) >> Reviewed-by: Steven Rostedt (VMware) > > I would fix sched_domain_span() to take a constant and keep the > previous patch. Right. I also considered it like you and asked it here: https://lkml.org/lkml/2018/1/11/106 But I didn't get any answer so tried to keep sched_domain_span() unchanged conservatively. Peterz, what's your opinion? > > -- Steve -- Thanks, Byungchul