Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp4934937imm; Tue, 19 Jun 2018 02:13:56 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIf5bbTHj5cAQRUuuvey1ByU51ZomqDqxglgkcHPTMIwHY+ENf/Q1pnncy6HyOUnpk8R8Dr X-Received: by 2002:a63:ae43:: with SMTP id e3-v6mr13694682pgp.181.1529399636637; Tue, 19 Jun 2018 02:13:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529399636; cv=none; d=google.com; s=arc-20160816; b=WeDJMabx9svjk57fgoHCkgVBWfX0YXCWLhTgNAq3W7f4Kva5deZt2SssUKfkxViXuJ tu5fNXBj7ibNUmbyzlpEhNZ4dW15l0tBQKxaNL5mu7H2I3C0DQAJlm/D/aPcLrylHgeM srrQcr2ElHPhw/q2hgxmf0xCbBzX0F6wgVPH+NnA6vxTpnf5+nkn1ULLYFQOHT2/dYtt KQHt22nGjLFGD7xCESpoGrtrvQHJ2uVHRQ3a6cNIJacs+NUkrap/cF7PI/02g6YssJMw R5IlYhl91EiwuV1PFrSqBPeXVCTc6Rz8sAUcvhvhMZtfn+rZH6U2KgsV1nYEGvpktbaG pq2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=vjAkdDk+jF6Q3+yh/sUOylUAKeYUXvM6QA/LovJ/IA4=; b=m2R+PkUWQNP5y4rUwaV71bxzRum+Q0Hih1D3jtaVBou3e7jS7GcGTDZpg0OuTOG0DL dM+N4EKjwB/2dtHPIJnf290wKMLrgqW9j/V9ianJgqRyy59ooYGVWoUtuyquKqlrwYZa NFbd5tVxLD+9u8voFY00Gf7flyjH1+zsL6xX0g7YccGcPx7+ixTB40OPKnDYiGGMqvJT 0Cm4fQzmegHdRHc6Zv8Ah/REuUw9lgMAM8FYTqxVIfZYrBQfbhy9TArslBYVp93+jLIH AiIUhO0s7+QxUh2BU47vuWmnHT+XB9G8pwKcwgi7mxhsB6C3qN1K/m6U9cgfTLN3+Nkf +c3A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z3-v6si16813357plb.228.2018.06.19.02.13.42; Tue, 19 Jun 2018 02:13:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756575AbeFSJMN (ORCPT + 99 others); Tue, 19 Jun 2018 05:12:13 -0400 Received: from mail.skyhub.de ([5.9.137.197]:37186 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756212AbeFSJML (ORCPT ); Tue, 19 Jun 2018 05:12:11 -0400 X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de Received: from mail.skyhub.de ([127.0.0.1]) by localhost (blast.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id mEx7vSJF31Hx; Tue, 19 Jun 2018 11:12:10 +0200 (CEST) Received: from zn.tnic (p200300EC2BD1DD00329C23FFFEA6A903.dip0.t-ipconnect.de [IPv6:2003:ec:2bd1:dd00:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 4E4271EC0077; Tue, 19 Jun 2018 11:12:10 +0200 (CEST) Date: Tue, 19 Jun 2018 11:12:05 +0200 From: Borislav Petkov To: Zhenzhong Duan Cc: Linux-Kernel , mingo@redhat.com, tglx@linutronix.de, Srinivas REDDY Eeda , hpa@zytor.com Subject: Re: [PATCH] x86/microcode/intel: Ensure new microcode processor flags match with cpu's pf Message-ID: <20180619091205.GA30870@zn.tnic> References: <7d20be40-4c15-4e15-a4d0-cd2efda6d701@default> <20180618195619.GH24921@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 19, 2018 at 12:49:40PM +0800, Zhenzhong Duan wrote: > Imagine kernel already found a microcode blob A with extended sig/pf > matching current cpu, then another microcode B is checked which doesn't > match current cpu... Do you see the if (!microcode_matches(mc_header, uci->cpu_sig.sig)) { call a couple of lines earlier? -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.