Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp4998935imm; Tue, 19 Jun 2018 03:26:15 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIGKRtvw9UHPobCLEDaswExw7i9GkX52FBYh2AIEIJWENLieN6dvqDn5gPMUs7fdlBaRB+c X-Received: by 2002:a17:902:7888:: with SMTP id q8-v6mr18340420pll.79.1529403975008; Tue, 19 Jun 2018 03:26:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529403974; cv=none; d=google.com; s=arc-20160816; b=vBGdFHXdUfR9UMxA0kngsTBZYGgl/V8wozZOmyhTmnACg8amqtoQgkzmqSfAsFYJXC 57vzWxP+8iV0YzqZalac/NP/3atltMI3BNqVTQ5ZyRsxXPM+7x93dc3X9KXDFesuA71M U86PxU3jasz7B//eHXLjyGiL5IXEnZy3eIQuBBjCvU6xwqCM8G4Iot9zWHDFOXUsdaLE vYnTeVDeas+zdNztdFgEBQ/HoeR7i8vAEX/FhAiTBBWl3qFS86zCsAq5f02JkJFbpXJ+ dbGXRuRTecI68ASDrjZRh0zcftj3/m1sQ93NuMlSZIDujmJiCErKWKeQZrtTYYD22VNo XWQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=Dxa5G3Rx7n/liYSKWRtOT9tUwEp1nmHk5mGRjMUjpH4=; b=jtVEJO/kYFz2Gzh+16cIS38uYglDWrVAPQMrC8i/jSx7RCU70yJXiml130QX9ls3// DdwgFfZCYFZp4rN8glwVhLyffBPOXjxbJGEsPzNyYnOrj2TQ7iNvaG93ZdKOZb7v+9dr Kd5KR7d6C3EBF709QeE6WYp5jwKjTVtYInwW70rbGLhmfbOIgdKZKPfeJ29wV5DAC4K6 0CeYYYzYLjxfK2fKHrV6YL+kfUoNByt0t7DotboHqVyv0vo9oJRhXUKZnMq5dE4hhKTy WicC2jV3Fnezd5xcGWP0A0OwSf03jIsUm39DBG/OBHfX9M0IYObG7Dcbmhrs/k8T58it c1OQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w10-v6si16544981pfg.328.2018.06.19.03.26.01; Tue, 19 Jun 2018 03:26:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757196AbeFSKZL (ORCPT + 99 others); Tue, 19 Jun 2018 06:25:11 -0400 Received: from foss.arm.com ([217.140.101.70]:47056 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757124AbeFSKZJ (ORCPT ); Tue, 19 Jun 2018 06:25:09 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B1C861435; Tue, 19 Jun 2018 03:25:08 -0700 (PDT) Received: from e108498-lin.cambridge.arm.com (e108498-lin.cambridge.arm.com [10.1.211.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BCF913F25D; Tue, 19 Jun 2018 03:25:04 -0700 (PDT) Date: Tue, 19 Jun 2018 11:25:03 +0100 From: Quentin Perret To: Juri Lelli Cc: Pavan Kondeti , peterz@infradead.org, rjw@rjwysocki.net, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, mingo@redhat.com, dietmar.eggemann@arm.com, morten.rasmussen@arm.com, chris.redpath@arm.com, patrick.bellasi@arm.com, valentin.schneider@arm.com, vincent.guittot@linaro.org, thara.gopinath@linaro.org, viresh.kumar@linaro.org, tkjos@google.com, joelaf@google.com, smuckle@google.com, adharmap@quicinc.com, skannan@quicinc.com, edubezval@gmail.com, srinivas.pandruvada@linux.intel.com, currojerez@riseup.net, javi.merino@kernel.org Subject: Re: [RFC PATCH v3 10/10] arch_topology: Start Energy Aware Scheduling Message-ID: <20180619102502.GU17720@e108498-lin.cambridge.arm.com> References: <20180521142505.6522-1-quentin.perret@arm.com> <20180521142505.6522-11-quentin.perret@arm.com> <20180619091841.GD9208@codeaurora.org> <20180619094002.GR17720@e108498-lin.cambridge.arm.com> <20180619094714.GA13617@localhost.localdomain> <20180619100224.GT17720@e108498-lin.cambridge.arm.com> <20180619101901.GC13617@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180619101901.GC13617@localhost.localdomain> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 19 Jun 2018 at 12:19:01 (+0200), Juri Lelli wrote: > On 19/06/18 11:02, Quentin Perret wrote: > > On Tuesday 19 Jun 2018 at 11:47:14 (+0200), Juri Lelli wrote: > > > On 19/06/18 10:40, Quentin Perret wrote: > > > > Hi Pavan, > > > > > > > > On Tuesday 19 Jun 2018 at 14:48:41 (+0530), Pavan Kondeti wrote: > > > > > > [...] > > > > > > > > There seems to be a sysfs interface exposed by this driver to change cpu_scale. > > > > > Should we worry about it? I don't know what is the usecase for changing the > > > > > cpu_scale from user space. > > > > > > > > This is something I've been wondering as well. TBH, I'm not sure what to > > > > do in this case. And I'm not sure to know what is the use-case either. > > > > Debugging purpose I assume ? > > > > > > > > Juri, did you have a specific use-case for this feature when the > > > > arch_topology driver was first introduced ? Or was it just to align > > > > with the existing arm/arm64 code ? > > > > > > It was requested (IIRC) because DT might have bogus values and not be > > > easily modifiable. So, this is another way to get things right for your > > > platform at runtime. > > > > Right, but that also allows you to set different capacities to CPUs > > inside the same freq domain, which isn't supported by the EM framework, > > at least for now. So I would prefer to assume that your values in DT must > > to be correct to use EAS, and leave the code as-is for now. > > It's actually built on the (current) assumption that siblings share > capacity [1], so it seems to align with what EM requires. > > [1] https://elixir.bootlin.com/linux/latest/source/drivers/base/arch_topology.c#L71 But there is not hard guarantee that the core_sibling mask and the frequency domains are aligned :-( Hikey 620 is an example where they might be misaligned (I think)