Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp5033280imm; Tue, 19 Jun 2018 04:03:40 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIzxQyP7MZaPhXxUehgDkSkART1hTaYxdx22PNUWY3KUypCvsP8IOuCbMysIjYpuAzv9y0V X-Received: by 2002:a63:5f8b:: with SMTP id t133-v6mr14496285pgb.68.1529406219976; Tue, 19 Jun 2018 04:03:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529406219; cv=none; d=google.com; s=arc-20160816; b=0RSdXtcqc3zjNx3qyJodqRQOtYW/HpDz95qlzqYJkVBa84iTywXOqjVuRpoMUZ5FOb X2SLRJz++aJJR6CYb73HIjwqTOjSXhweKpSKelPgp/+d9wNNTNUk6ZRvUfhMwJ/uWS22 BG9zIyukLsyO13VMBQb6KrecIsySNWx2DS67c50hZrT06FOb+PyUOlIboHJCqCpYxe4k BQyXPu1ngTdKfg7u8oJtJ4xqadd+0WQYT/iaW4f4zmk5ohJZcwn1/XxWVxW7LTMOud2Z jyxH6JBmrsO4/O91BLSYKhxcqtSBtGSTc9AhgzMEBYYgAkhjfy7kiLoQQm8ZmHa0/hkx iLfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=t6lg73DyadxcLf5Sae6k0+ma+WH8+i6QvtVXh6xrJHY=; b=igypwIkbxstBP3Z5jyxxHCucVR6L/9iLcPq+zn7VIkBOGXKRMvkOlvbo+AxiMctmS+ cSsrKo4b21ts62ohvn3xGKOkPl/SFoXOfqPXzqOaN2s1EKMWUemMlgokFZohKl+g8xsO DA/lxXw40RZrSaozfjUBYd2rw5SBOaEo5H9tQklvaXsWKWZOC/eakB+iPC4AjFWlfW9s bNG2OwIJYdqVqdjrtgi3/lZJDqqMu/XvqVGawta/BBHsxappjgphuGRLqrm5TfYpQVj+ L62d0etNs+MObfQKQ4LO/UgJk+JJCaVTC3djB4Hy9o/CcRhje4pi+jCpnNVkPVklMkdC Dsyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=CHkA1qSs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d65-v6si13912883pgc.70.2018.06.19.04.03.17; Tue, 19 Jun 2018 04:03:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=CHkA1qSs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937653AbeFSLCg (ORCPT + 99 others); Tue, 19 Jun 2018 07:02:36 -0400 Received: from merlin.infradead.org ([205.233.59.134]:38722 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S937591AbeFSLCe (ORCPT ); Tue, 19 Jun 2018 07:02:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=t6lg73DyadxcLf5Sae6k0+ma+WH8+i6QvtVXh6xrJHY=; b=CHkA1qSsYvEQxcOjvebUsL1nn B8j0MsYy5W9hX25hsiT39OlYH2LILR5FEgRsSJTm6lNpIzgNYTZwgCuXgcDZeAPwCovZsvKf0xAL9 zeGXPQ0dSRg+939lXLryc0QsHc/Q7waex7DDhka5ynvXcKrW42Vo/DcQWiuWEm1gQa+sYI1UmkMVo 7qVvSljz+WWCWkxLMbQptOFWdTxgnLk7Ifzb/YdP/BR/KruBDpi+zRAIuhz7MVG4Yd/mNpeXxA6Fb AzwWx0UbfYW7P1s1gRcyZ1twUBsWx88CfyJZtcphhV/IoKVg4MaKgGyDaZ3uPO8jgKq6wZGUvhNMY /AVwce6cw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fVEOm-0007nY-Mn; Tue, 19 Jun 2018 11:02:09 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 9071020298BAC; Tue, 19 Jun 2018 13:02:05 +0200 (CEST) Date: Tue, 19 Jun 2018 13:02:05 +0200 From: Peter Zijlstra To: Thomas Hellstrom Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-graphics-maintainer@vmware.com, pv-drivers@vmware.com, Ingo Molnar , Jonathan Corbet , Gustavo Padovan , Maarten Lankhorst , Sean Paul , David Airlie , Davidlohr Bueso , "Paul E. McKenney" , Josh Triplett , Thomas Gleixner , Kate Stewart , Philippe Ombredanne , Greg Kroah-Hartman , linux-doc@vger.kernel.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org Subject: Re: [PATCH 1/3] locking: WW mutex cleanup Message-ID: <20180619110205.GE2476@hirez.programming.kicks-ass.net> References: <20180619082445.11062-1-thellstrom@vmware.com> <20180619082445.11062-2-thellstrom@vmware.com> <20180619094409.GK2458@hirez.programming.kicks-ass.net> <8ea67e74-5ed4-2157-8e51-43f15047b3e4@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8ea67e74-5ed4-2157-8e51-43f15047b3e4@vmware.com> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 19, 2018 at 12:44:52PM +0200, Thomas Hellstrom wrote: > On 06/19/2018 11:44 AM, Peter Zijlstra wrote: > > On Tue, Jun 19, 2018 at 10:24:43AM +0200, Thomas Hellstrom wrote: > > > From: Peter Ziljstra > > > > > > Make the WW mutex code more readable by adding comments, splitting up > > > functions and pointing out that we're actually using the Wait-Die > > > algorithm. > > > > > > Cc: Ingo Molnar > > > Cc: Jonathan Corbet > > > Cc: Gustavo Padovan > > > Cc: Maarten Lankhorst > > > Cc: Sean Paul > > > Cc: David Airlie > > > Cc: Davidlohr Bueso > > > Cc: "Paul E. McKenney" > > > Cc: Josh Triplett > > > Cc: Thomas Gleixner > > > Cc: Kate Stewart > > > Cc: Philippe Ombredanne > > > Cc: Greg Kroah-Hartman > > > Cc: linux-doc@vger.kernel.org > > > Cc: linux-media@vger.kernel.org > > > Cc: linaro-mm-sig@lists.linaro.org > > > Co-authored-by: Thomas Hellstrom > > > Signed-off-by: Thomas Hellstrom > > > --- > > > Documentation/locking/ww-mutex-design.txt | 12 +- > > > include/linux/ww_mutex.h | 28 ++--- > > > kernel/locking/mutex.c | 202 ++++++++++++++++++------------ > > > 3 files changed, 145 insertions(+), 97 deletions(-) > > Acked-by: Peter Zijlstra (Intel) > > Hi Peter, > > Do you want to add a SOB, since you're the main author? Sure, here goes: Signed-off-by: Peter Zijlstra (Intel)