Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp5147872imm; Tue, 19 Jun 2018 05:58:53 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLjExO0r/0ZUWs/poK4iCGJ2qIbzWfPTiOTU1FZ7weXbp8k174Z7b+aVKro6YXvVYtrZcEu X-Received: by 2002:a63:7d4c:: with SMTP id m12-v6mr14584071pgn.201.1529413133721; Tue, 19 Jun 2018 05:58:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529413133; cv=none; d=google.com; s=arc-20160816; b=S4SquP053VE4KGPFpsdbx5dDnl++3s6WfoUAsS85JIk3lQrHbc5DIPIZ+jVZgMWuYD oXECYW7LzWTFI9m3ynpdQ9wKXBO9+NcUOJ6Dr1Os2A618lxv/6mIHKi/prQPxdMd2C+4 DyHbp0ZVoT5yFhclqbni1GVvRJfz380eyeyEJbVIPDYmM7pp31E/BLNrxzcaxsHnn+az sEgOX8pV8wG8gpgopwyi271iRJm7CS9L7uYTpeXOxL7e5Yk/oMl/Z1e6G7yVpQGB//GZ kkkwG2GHoWqgclbxGSwO+OMeJnKQ6BSjnlQggfm5p4msUgzgRfNw1PlpV4NBWfeyLhmu zZ0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:references:in-reply-to:subject:cc:to:from :arc-authentication-results; bh=VhQdYrU5iKlTxE9IabscqAUSAuw5A9LtVVHeBMUXz9A=; b=b8cQMv7M49NXE74T81vSTnUIHrHeaosQV95drJGzvt27pPFYi7dw0yyYZjwrvFkTSh GIKdt2mOtqx1Gk7LroM65xsll+/ooqRpmfj32Pm6xLqV5UxZOZkc4x4K7qPigf/mRNq8 jWo4fbGUKUAS1wfh1XiRzoTNZHH+YDwY1723PPoGaKJCXqe/ILjs3ebNu4BiC5NHd12R 2BNoHZdVvx6qEjLQyWPMgQabaKr6qykdLpO/kVX6eI0ZCirKtaIttInjeJ/HmgDwG5LY n4gNbqw3af/GpiDwFoF1g2vdbPY6YNOjmDq2+K//SeIx8Fm3COPr/6oMOmHuhVNGuQEa hgVQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d8-v6si13930219pgq.162.2018.06.19.05.58.40; Tue, 19 Jun 2018 05:58:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757197AbeFSM52 convert rfc822-to-8bit (ORCPT + 99 others); Tue, 19 Jun 2018 08:57:28 -0400 Received: from ozlabs.org ([203.11.71.1]:59287 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756580AbeFSM51 (ORCPT ); Tue, 19 Jun 2018 08:57:27 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPSA id 4197KK18XDz9s1B; Tue, 19 Jun 2018 22:57:25 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au From: Michael Ellerman To: Souptick Joarder , Frederic Barrat Cc: Arnd Bergmann , Sabyasachi Gupta , Greg KH , linux-kernel@vger.kernel.org, fbarrat@linux.vnet.ibm.com, Matthew Wilcox , Andrew Donnellan , brajeswar.linux@gmail.com, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] misc: ocxl: Change return type for fault handler In-Reply-To: References: <20180611202904.GA25538@jordon-HP-15-Notebook-PC> <5c6942da-c847-c53a-a571-4ec96f2a993d@linux.ibm.com> Date: Tue, 19 Jun 2018 22:57:24 +1000 Message-ID: <87wouvvsqz.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Souptick Joarder writes: > On Thu, Jun 14, 2018 at 9:36 PM, Frederic Barrat wrote: >> Le 11/06/2018 à 22:29, Souptick Joarder a écrit : >>> >>> Use new return type vm_fault_t for fault handler. For >>> now, this is just documenting that the function returns >>> a VM_FAULT value rather than an errno. Once all instances >>> are converted, vm_fault_t will become a distinct type. >>> >>> Ref-> commit 1c8f422059ae ("mm: change return type to vm_fault_t") >>> >>> There is an existing bug when vm_insert_pfn() can return >>> ENOMEM which was ignored and VM_FAULT_NOPAGE returned as >>> default. The new inline vmf_insert_pfn() has removed >>> this inefficiency by returning correct vm_fault_ type. >>> >>> Signed-off-by: Souptick Joarder >>> --- >> >> >> Thanks! >> >> Tested and >> Acked-by: Frederic Barrat > > Frederic, is this patch queued for 4.19 ? Not yet, you're a bit early. 4.18-rc1 only came out the other day :) Your patches are tracked here: http://patchwork.ozlabs.org/project/linuxppc-dev/list/?submitter=67924 They should appear in 4.19 unless something conflicts with them. cheers