Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp5167798imm; Tue, 19 Jun 2018 06:14:58 -0700 (PDT) X-Google-Smtp-Source: ADUXVKL++2CF6AFtIVyEXMOiosPM1aN9g/erNzIpTrICRHU74wrPHB8xBdoMosgUIiTM+kOgAYB1 X-Received: by 2002:a17:902:6bca:: with SMTP id m10-v6mr18994634plt.6.1529414098915; Tue, 19 Jun 2018 06:14:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529414098; cv=none; d=google.com; s=arc-20160816; b=npkK+zS4G+pWloqmi6tdcaHnCe00YYvvQDrFhLfZsaT+1rTcT686XUdWzobSjU8Fpn 7bqlm2KamMeRxbsGeYzzQ4gduJNyMj/Y5du3PiirUtOBi8wi2ApVELFxPRT0nBkiB/19 kXXadgjql4s8g8iJ5NFGQsWzN5RnW28i1FrWP1ET0OIbPFMpY89pNNXoPN3YDT2e28R7 ya44LR76Hjj0puzmR+YQxpalqAJ8mpVL63uub9stlDyHUv5ifoCRK8vIdVvHS3oR3Qra 6RLBAtiWNL9M8chLW3MvC9HTV1z+SrC2B7EEaPmkJkQfO2P8HnZJlPAZ05rYuwGxj2Cm D4Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :arc-authentication-results; bh=CbzkBKTpOjRR4Y7YGXMkum7RnUa53K0cMn/GKDrDvb4=; b=qRtzgnI/gx6QoGkjvcuG6JTqR0DSC2QOGAZdA5I1RCpl/F4yQMawbXLVaiD73ei+pH 3AIyRlid+lfOX8Wag2QjS2ffTDoIzYQwI8auRjO8EDGkOGqG1Cc5IshvNbug8Lz51pWA 06MAGqg/mbbPiKxyEEMiQXmlgLJp4ZOLMkmhYCxdKmMVWo+pzy7kAAuPE0MUsK/fV/Jr cqVaoE6Zvne6KzTdEESIb85EHbQrJjV6i0vCeolKmLJdA2oGG1zIyXnLJxH2cvYBRijC Qsx5wEm4ApxdmqGMaP+DAqt8fBD3P7kSKvTI6vh0Bw2f2s7vttWe7oC/vJjaYnA8wGqT feVw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w11-v6si10698012pge.422.2018.06.19.06.14.37; Tue, 19 Jun 2018 06:14:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938011AbeFSNMa (ORCPT + 99 others); Tue, 19 Jun 2018 09:12:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:45970 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S937989AbeFSNM0 (ORCPT ); Tue, 19 Jun 2018 09:12:26 -0400 Received: from gandalf.local.home (cpe-66-24-56-78.stny.res.rr.com [66.24.56.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E95AC208A1; Tue, 19 Jun 2018 13:12:24 +0000 (UTC) Date: Tue, 19 Jun 2018 09:12:23 -0400 From: Steven Rostedt To: Joel Fernandes Cc: Joel Fernandes , linux-kernel@vger.kernel.org, kernel-team@android.com, Josh Triplett , Lai Jiangshan , Mathieu Desnoyers , "Paul E. McKenney" , Byungchul Park Subject: Re: [PATCH 2/2] rcutorture: Fix rcu_barrier successes counter Message-ID: <20180619091223.702f05d6@gandalf.local.home> In-Reply-To: <20180619073115.GA241700@joelaf.mtv.corp.google.com> References: <20180619062215.221564-1-joel@joelfernandes.org> <20180619062215.221564-2-joel@joelfernandes.org> <20180619073115.GA241700@joelaf.mtv.corp.google.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 19 Jun 2018 00:31:15 -0700 Joel Fernandes wrote: > Hi Paul, > Think some more about this counter, I think you mean 'successes' as in > 'successful attempts' than 'successful test' ? If so, then perhaps you can > drop this patch. It wasn't clear to me what the 'successes' meant so I may > have been a bit misled into changing its meaning. If on the other hand, it > means 'successful test', then yes this patch would be Ok then. thanks! -Joel > In either case, it sounds like a comment should be added to clarify what n_barrier_successes actually means ;-) -- Steve