Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20180612070906.5305-1-aaron.ma@canonical.com> <CAN+gG=EDc8WsC3MjbY1VnYyo7G1ZBUboM2_T-Zd8r322dOvwTA@mail.gmail.com>
 <32d6c8c8-7662-3ab4-ca92-2357ca668f4b@canonical.com>
In-Reply-To: <32d6c8c8-7662-3ab4-ca92-2357ca668f4b@canonical.com>
From:   Benjamin Tissoires <benjamin.tissoires@gmail.com>
Date:   Tue, 19 Jun 2018 15:46:09 +0200
Message-ID: <CAN+gG=Fn5bpnWYMJGprAB0-8WoH8ju-5MoiqVHiaO9QMyhpjnQ@mail.gmail.com>
Subject: Re: [PATCH] Input: elan: enable middle button of touchpads on
 ThinkPad P52
To:     aaron.ma@canonical.com
Cc:     linux-input <linux-input@vger.kernel.org>,
        linux-kernel@vger.kernel.org, KT Liao <kt.liao@emc.com.tw>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jun 19, 2018 at 3:13 PM Aaron Ma <aaron.ma@canonical.com> wrote:
>
> On 06/19/2018 08:21 PM, Benjamin Tissoires wrote:
> > On Tue, Jun 12, 2018 at 9:10 AM Aaron Ma <aaron.ma@canonical.com> wrote:
> >> PNPID is better way to identify the type of touchpads.
> >> Enable middle button support on 2 types of touchpads on Lenovo P52.
> >>
> >> Cc: stable@vger.kernel.org
> >> Cc: KT Liao <kt.liao@emc.com.tw>
> >> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
> >> ---
> >>  drivers/input/mouse/elantech.c | 9 ++++++++-
> >>  1 file changed, 8 insertions(+), 1 deletion(-)
> > Looks good to me:
> > Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> >
> > Aaron, our internal tests show that the P52 shows a lot of lost
> > synchronization in pre-v4.18 kernels. Do you have a fix for that too?
> >
>
> https://lkml.org/lkml/2018/5/28/694
> should fix the sync issue.

Thanks for the pointer :)
I have missed that one.

>
>
> > In v4.18 we need to fix the elan_i2c module as right now the touchpad
> > is muted when booted with such a kernel.
>
> Does this touchpad support elan_i2c?

Yes it does. And starting from v4.18 the touchpad will switch to
elan_i2c by default. However, I'll have to provide some fixes as some
elan_i2c commands are not working :(

Cheers,
Benjamin

>
> Regards,
> Aaron
>
> >
> > Cheers,
> > Benjamin
> >
> >> diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
> >> index fb4d902c4403..67b061dd4494 100644
> >> --- a/drivers/input/mouse/elantech.c
> >> +++ b/drivers/input/mouse/elantech.c
> >> @@ -1175,6 +1175,12 @@ static const struct dmi_system_id elantech_dmi_has_middle_button[] = {
> >>         { }
> >>  };
> >>
> >> +static const char * const middle_button_pnp_ids[] = {
> >> +       "LEN2131", /* ThinkPad P52 w/ NFC */
> >> +       "LEN2132", /* ThinkPad P52 */
> >> +       NULL
> >> +};
> >> +
> >>  /*
> >>   * Set the appropriate event bits for the input subsystem
> >>   */
> >> @@ -1194,7 +1200,8 @@ static int elantech_set_input_params(struct psmouse *psmouse)
> >>         __clear_bit(EV_REL, dev->evbit);
> >>
> >>         __set_bit(BTN_LEFT, dev->keybit);
> >> -       if (dmi_check_system(elantech_dmi_has_middle_button))
> >> +       if (dmi_check_system(elantech_dmi_has_middle_button) ||
> >> +               psmouse_matches_pnp_id(psmouse, middle_button_pnp_ids))
> >>                 __set_bit(BTN_MIDDLE, dev->keybit);
> >>         __set_bit(BTN_RIGHT, dev->keybit);
> >>
> >> --
> >> 2.17.1
> >>
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> >> the body of a message to majordomo@vger.kernel.org
> >> More majordomo info at  http://vger.kernel.org/majordomo-info.html