Date: Mon, 8 Sep 2003 19:12:15 -0700
From: Andrew Morton <akpm@osdl.org>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: mingo@redhat.com, drepper@redhat.com, roland@redhat.com,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] use group_leader->pgrp (was Re: setpgid and threads)
Message-Id: <20030908191215.22f501a2.akpm@osdl.org>
In-Reply-To: <1063072786.4004.11.camel@localhost.localdomain>
References: <1061424262.24785.29.camel@localhost.localdomain>
	<20030820194940.6b949d9d.akpm@osdl.org>
	<1063072786.4004.11.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 873
Lines: 26

Jeremy Fitzhardinge <jeremy@goop.org> wrote:
>
> On Wed, 2003-08-20 at 19:49, Andrew Morton wrote:
> > Using current->thread_group->foo sounds like a reasonable solution
> 
> Here's a patch to use group_leader->pgrp rather than just ->pgrp so that
> all threads in a group appear to have the same process group ID.

Just a quick maintainance thing:


> -				if (is_orphaned_pgrp(current->pgrp))
> +				if (is_orphaned_pgrp(current->group_leader->pgrp))

Would it make sense to do this via

	if (is_orphaned_pgrp(process_group(current)))

and to then rename task_struct.pgrp to something else, to pick up any
missed conversions?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/