Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp5302543imm; Tue, 19 Jun 2018 08:16:13 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIazIP6AHdOTK2vQIubhpfYO7y1x010RmXQVI+saLmxrIo8dXtKdLbQe5bLJOKIIvPOlcpP X-Received: by 2002:a62:e401:: with SMTP id r1-v6mr18593929pfh.172.1529421373702; Tue, 19 Jun 2018 08:16:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529421373; cv=none; d=google.com; s=arc-20160816; b=EE/dOLu2jvDtzHI9Mzv4Ux0fwexjtKE7JQM/Cp84hjxJw9OvPuR8EC7nZL2lf4MQL1 HJBRe07o75e4pIqkKru+GLsrCPOyOxOz3iot/qUPB8uEnbD4bQm8l5jtu7KrDyX8HLtv w+shSqithm6xMVu7YchSGzI5Fy524cxbh7ADXisBdr6GF2FdXWJEhk6XqaulZJPmkD+b oFoh5QkCzt+BBz/NsCnpoDBl+uHSRJ+DYvRtp3htn8LUFAH9/iudO0gia0Of1EMWkaE8 5ie7T8WkcAq7Z5vGzpVCeO+hktrgwfHdJtNP+Ut3TixLNyh+M+e9bmOrk+BEYkmJI1IA 7tUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=HBYpgfhLZL4OhZCZNQlNeiGvIw+QYmMtIQndGaiH+/8=; b=u0cSu2sTtlFqsQnGh0Mdi80X2CWSkgkvT71ZmxMaiVsGZ5MplVnvUHcuDujCRJDnpn rR2TsKWtVLB0l7URKdtQBsu2ydq5MjBBZhNF0KiQFH9Cx108UoTvum25fwoMpEPuKpwj BL2Qwl1Xoig5AB/i0E5CluYskv6yNoVJQIqkjpHDhZ/W/JlIXb3KnEWXsX7XkPGJsLlS a4HhRrhwCHQlkaVYMDPoZ9yKOEXMfc5DfdeRKywtQA+cS3rwkYEz8NIUrxB3YHpsATJP okygBvr6swwZXeiIQo3hqt2qJm3uIkhLKZagYNkLlfvJgP1i0/CR4WUV3yAXL4sCxKDi aGcA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q17-v6si16739220pff.173.2018.06.19.08.15.59; Tue, 19 Jun 2018 08:16:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966330AbeFSPPD (ORCPT + 99 others); Tue, 19 Jun 2018 11:15:03 -0400 Received: from mx2.suse.de ([195.135.220.15]:54786 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S937576AbeFSPPB (ORCPT ); Tue, 19 Jun 2018 11:15:01 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext-too.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 41A2AAE0C; Tue, 19 Jun 2018 15:15:00 +0000 (UTC) Date: Tue, 19 Jun 2018 17:14:25 +0200 From: Michal Hocko To: Punit Agrawal Cc: Lorenzo Pieralisi , Xie XiuQi , Hanjun Guo , Bjorn Helgaas , tnowicki@caviumnetworks.com, linux-pci@vger.kernel.org, Catalin Marinas , "Rafael J. Wysocki" , Will Deacon , Linux Kernel Mailing List , Jarkko Sakkinen , linux-mm@kvack.org, wanghuiqiang@huawei.com, Greg Kroah-Hartman , Bjorn Helgaas , Andrew Morton , zhongjiang , linux-arm Subject: Re: [PATCH 1/2] arm64: avoid alloc memory on offline node Message-ID: <20180619151425.GH13685@dhcp22.suse.cz> References: <16c4db2f-bc70-d0f2-fb38-341d9117ff66@huawei.com> <20180611134303.GC75679@bhelgaas-glaptop.roam.corp.google.com> <20180611145330.GO13364@dhcp22.suse.cz> <87lgbk59gs.fsf@e105922-lin.cambridge.arm.com> <87bmce60y3.fsf@e105922-lin.cambridge.arm.com> <8b715082-14d4-f10b-d2d6-b23be7e4bf7e@huawei.com> <20180619120714.GE13685@dhcp22.suse.cz> <874lhz3pmn.fsf@e105922-lin.cambridge.arm.com> <20180619140818.GA16927@e107981-ln.cambridge.arm.com> <87wouu3jz1.fsf@e105922-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87wouu3jz1.fsf@e105922-lin.cambridge.arm.com> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 19-06-18 15:54:26, Punit Agrawal wrote: [...] > In terms of $SUBJECT, I wonder if it's worth taking the original patch > as a temporary fix (it'll also be easier to backport) while we work on > fixing these other issues and enabling memoryless nodes. Well, x86 already does that but copying this antipatern is not really nice. So it is good as a quick fix but it would be definitely much better to have a robust fix. Who knows how many other places might hit this. You certainly do not want to add a hack like this all over... -- Michal Hocko SUSE Labs